fix(scripts): centralize ISO 8601 timestamp regex in CIHelpers by MauroDruwel · Pull Request #1343 · microsoft/hve-core

MauroDruwel · 2026-04-11T18:50:03Z

Pull Request

Description

Add Get-StandardTimestampPattern to CIHelpers.psm1 returning the canonical
regex for validating Get-StandardTimestamp output. Replace all standalone
hardcoded ISO 8601 timestamp patterns across five test files with calls to this
function, eliminating duplication and drift.

Three distinct regex variants had already emerged across the test suite:

Variant	Where	Risk
`\.\d+Z$`	CIHelpers, SecurityHelpers, FrontmatterValidation	Canonical
`\.\d{3,7}Z$`	SecurityClasses	Silently rejects valid timestamps with >7 fractional digits
`.*Z$`	Invoke-YamlLint	Matches anything before `Z`, defeats validation purpose

The new function returns a single source of truth so all assertions stay in sync
automatically if the timestamp format changes.

Relationship to #1314

This PR was born from the review discussion on #1314, filed separately as #1333.

	#1314	This PR
What	Renames JSON keys `timestamp` → `Timestamp`	Centralizes the regex that validates timestamp values
Scope	4 linting scripts + 5 test files	`CIHelpers.psm1` + 5 test files
File overlap	None	None
Merge order	Independent	Independent

Both PRs are needed — they address different layers of the same standardization
effort (#1003). #1314 fixes how timestamps are named in JSON output; this PR
fixes how timestamps are validated in tests. Neither blocks the other and they
can merge in any order without conflicts.

Note: FrontmatterValidation.Tests.ps1 still uses lowercase
$hash['timestamp'] — that key casing is #1314's scope, intentionally left
untouched here.

Related Issue(s)

Closes #1333

Type of Change

Code & Documentation:

Bug fix (non-breaking change fixing an issue)

Other:

Script/automation (.ps1, .sh, .py)

Testing

Replaced regex strings with (Get-StandardTimestampPattern) calls in 5 test files
Added 2 new verification tests in CIHelpers.Tests.ps1:
- Get-StandardTimestampPattern returns a non-empty string
- Pattern matches actual Get-StandardTimestamp output (cross-validation)
Added explicit CIHelpers module imports to 3 test files that lacked direct
access (SecurityClasses, SecurityHelpers, FrontmatterValidation)

Files Changed

Module (new function + export):

scripts/lib/Modules/CIHelpers.psm1 — Get-StandardTimestampPattern function and Export-ModuleMember entry

Tests (hardcoded regex → function call):

scripts/tests/lib/CIHelpers.Tests.ps1 — replaced regex; added Describe 'Get-StandardTimestampPattern' block
scripts/tests/linting/FrontmatterValidation.Tests.ps1 — replaced 2 regexes; added CIHelpers import
scripts/tests/linting/Invoke-YamlLint.Tests.ps1 — replaced 1 regex (already imported CIHelpers)
scripts/tests/security/SecurityClasses.Tests.ps1 — replaced 1 regex; added CIHelpers import
scripts/tests/security/SecurityHelpers.Tests.ps1 — replaced 1 regex; added CIHelpers import

Checklist

Required Checks

Documentation is updated (if applicable)
Files follow existing naming conventions
Changes are backwards compatible (if applicable)
Tests added for new functionality (if applicable)

Required Automated Checks

Markdown linting: npm run lint:md
Spell checking: npm run spell-check
Frontmatter validation: npm run lint:frontmatter
Skill structure validation: npm run validate:skills
Link validation: npm run lint:md-links
PowerShell analysis: npm run lint:ps
Plugin freshness: npm run plugin:generate
Docusaurus tests: npm run docs:test

Security Considerations

This PR does not contain any sensitive or NDA information
Any new dependencies have been reviewed for security issues
Security-related scripts follow the principle of least privilege

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

katriendg

Lovely to have you pick up an issue from the backlog @MauroDruwel 🙏 It's looking all good to me!

codecov-commenter · 2026-04-13T07:11:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.65%. Comparing base (29a2df1) to head (1dfedea).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   87.66%   87.65%   -0.01%     
==========================================
  Files          61       61              
  Lines        9328     9329       +1     
==========================================
  Hits         8177     8177              
- Misses       1151     1152       +1

Flag	Coverage Δ
pester	`85.22% <100.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
scripts/lib/Modules/CIHelpers.psm1	`97.90% <100.00%> (+0.01%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rezatnoMsirhC

Thank you for your contribution! Overall things look pretty neat, but I left a few comments to ensure we maintain regression detection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

MauroDruwel · 2026-04-17T18:34:55Z

Thanks so much for the careful review, @rezatnoMsirhC. Really appreciate the feedback here.

I pushed an update that addresses your points:

I changed the Get-StandardTimestamp test back to an inline literal regex, so it can catch regressions independently.
I expanded Get-StandardTimestampPattern tests with explicit positive and negative literal cases.

Would love a second look when you have time.

## Pre-Release 3.3.101 ### ✨ Features - add removed maturity tier and retire owasp-docker (#1444) - add evaluation dataset creator (#1279) - align RAI planner with guide, remove scoring, improve UX (#1287) - add PSGallery staleness check and BOM cleanup (#1379) - ISA-95 network planner agent (#1177) - auto-generate collection.md with maturity filtering (#1316) - add folder-consistency check and standardize WARN outp… (#1350) - add synth-data-generate prompt to data-science collection (#1419) - add canonical deck workflow and customer-card rendering for design thinking (#1413) - add Figma MCP integration for DT artifact export (#1222) - introduce `owasp-docker` (#1245) - replace hve-core-specific references with portable discovery-based language (#1335) - introduce `owasp-cicd` (#1246) - add secure-by-design knowledge skill (#1223) - introduce `owasp-infrastructure` (#1244) - introduce `owasp-mcp` (#1207) - add OutputPath parameter to Invoke-LinkLanguageCheck.ps1 (#1229) - add -OutputPath parameter to Validate-SkillStructure.ps1 (#1225) - add maintainer-only skip-review label guard (#1293) - add extension collections overview and integrate into getting started flow (#950) - add agentic workflows for automated issue triage, implementation, PR review, dependency review, and doc-staleness detection (#1219) - consolidate package-lock.json version sync into Update-VersionFiles.ps1 (#1240) - add standards code review agent and full review orchestrator (#1174) - standardize pytest-mock as Python mocking framework (#1170) - add Jira backlog workflows and Jira/GitLab skills (#978) - add centralized version bump script and supply-chain attestation (#1183) ### 🐛 Bug Fixes - pin PowerShell-Yaml to 0.4.7 across all install sites (#1378) - close fork-PR/workflow-file-PR secret-strip gap and normalize upload-artifact version (#1421) - replace stream-based lookahead with array indexing in list-changed-files.sh (#1376) - centralize ISO 8601 timestamp regex in CIHelpers (#1343) - update stale documentation date in release-process.md (#1363) - pin basic-ftp to 5.3.0 to resolve GHSA-rp42-5vxx-qpwr (#1374) - add bot filter to dependency PR review workflow (#1362) - resolve pip-audit findings in powerpoint, gitlab, and jira skill lock files (#1360) - standardize Timestamp JSON key casing across all lint result files (#1314) - add synchronize trigger to PR Review workflow (#1323) - standardize timestamp in Validate-SkillStructure.ps1 to use Get-StandardTimestamp (#1280) - add parallel subagent dispatch and structured JSON contracts to code-review-full (#1304) - standardize timestamp in SecurityHelpers.psm1 to use Get-StandardTimestamp (#1284) - standardize timestamps in Test-DependencyPinning.ps1 and SecurityClasses.psm1 (#1282) - derive collection artifact counts from YAML at build time (#1275) - standardize timestamp in FrontmatterValidation.psm1 to use Get-StandardTimestamp (#1285) - standardize timestamp in Markdown-Link-Check.ps1 to use Get-StandardTimestamp (#1283) - escape hyphens in Mermaid diagram on Collections page (#1262) - add summary timestamp to PSScriptAnalyzer output (#1211) - fix plugin compatibility and robustness for coding-standards code review agents (#1289) - standardize timestamp in Test-CopyrightHeaders.ps1 to use Get-StandardTimestamp (#1278) - standardize timestamp in Invoke-YamlLint.ps1 to use Get-StandardTimestamp (#1270) - standardize timestamp in Invoke-LinkLanguageCheck.ps1 to use Get-StandardTimestamp (#1264) - fix dependency-review path filters and sparse-checkout cone mode (#1259) - replace invalid bare tool names with official tool identifiers (#1198) - fix broken links and remove orphaned reference in code review docs (#1257) - exclude Python env dirs from skill validation warnings (#1255) - pin happy-dom and serialize-javascript to resolve Dependabot vulnerabilities (#1253) - remove Mermaid diagram and add missing collection cards (#1247) - disable MCP servers by default to prevent token limit errors (#1144) - sync package-lock.json after pre-release version bump (#1236) - separate mermaid node declarations and add dynamic diagram generation with tests (#1215) - replace anchor links in meeting-analyst with bold text references (#1201) - remove recursive symlinks in jira and gitlab skill directories (#1233) - validate-installation scripts now check .github/skills directory (#1010) (#1206) - resolve npm audit vulnerabilities via dependency overrides (#1200) - add post-release triggers to scorecard workflow (#1186) - add missing .md extensions to relative links in agent documentation (#1180) ### 📚 Documentation - broaden Security Review description beyond OWASP (#1385) - document maintainer advisory mode and skip-review label guard (#1386) - document ExcludePaths/OutputPath for Invoke-LinkLanguageCheck (#1383) - CLI getting-started: clarify plugin install commands as alternatives (-all vs base) (#1251) ### ♻️ Refactoring - align agent and prompt folder names to collection identifier (#1210) ### 🔧 Maintenance - pin PSScriptAnalyzer to 1.25.0 and sync stale workflow version comments (#1389) - bump lxml from 6.0.2 to 6.1.0 in /.github/skills/experimental/powerpoint (#1424) - bump @vscode/vsce from 3.7.1 to 3.9.1 in the npm-dependencies group (#1390) - bump the github-actions group across 1 directory with 7 updates (#1391) - bump follow-redirects from 1.15.11 to 1.16.0 in /docs/docusaurus (#1356) - upgrade Node.js from 20 to 24 and bump cspell to v10 (#1353) - bump basic-ftp from 5.2.0 to 5.2.1 (#1324) - update github/gh-aw-actions requirement to 536ea1bad8c6715d098a9dc1afea8d403733acfe in the github-actions group across 1 directory (#1298) - update security instruction attributions and compliance (#1294) - bump the npm-dependencies group with 2 updates (#1297) - pre-release 3.3.41 (#1252) - streamline RAI Planner phase structure and documentation (#1273) - bump happy-dom from 20.8.8 to 20.8.9 in /docs/docusaurus (#1237) - pre-release 3.3.27 (#1191) - bump pygments from 2.19.2 to 2.20.0 in /.github/skills/gitlab/gitlab (#1234) - bump path-to-regexp from 0.1.12 to 0.1.13 in /docs/docusaurus (#1226) - bump the github-actions group with 4 updates (#1231) - add missing folders and alphabetize location lists (#1193) - bump brace-expansion (#1224) - bump handlebars from 4.7.8 to 4.7.9 in /docs/docusaurus (#1217) - bump brace-expansion from 5.0.3 to 5.0.5 in /docs/docusaurus (#1213) - pre-release 3.3.10 (#1187) - bump markdownlint-cli2 from 0.21.0 to 0.22.0 in the npm-dependencies group (#1175) - bump the github-actions group with 3 updates (#1176) - pre-release 3.3.1 (#1165) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(scripts): centralize ISO 8601 timestamp regex in CIHelpers

528e64e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

MauroDruwel requested a review from a team as a code owner April 11, 2026 18:50

katriendg approved these changes Apr 13, 2026

View reviewed changes

katriendg and others added 2 commits April 13, 2026 11:07

Merge branch 'main' into fix/centralize-timestamp-regex

81778f5

Merge branch 'main' into fix/centralize-timestamp-regex

32f8669

rezatnoMsirhC requested changes Apr 16, 2026

View reviewed changes

Comment thread scripts/lib/Modules/CIHelpers.psm1

Comment thread scripts/tests/lib/CIHelpers.Tests.ps1 Outdated

Comment thread scripts/tests/lib/CIHelpers.Tests.ps1

MauroDruwel and others added 2 commits April 17, 2026 19:58

Merge branch 'microsoft:main' into fix/centralize-timestamp-regex

c40b46c

test(scripts): strengthen timestamp pattern regression checks

1dfedea

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

MauroDruwel requested a review from rezatnoMsirhC April 17, 2026 18:36

rezatnoMsirhC approved these changes Apr 20, 2026

View reviewed changes

rezatnoMsirhC merged commit 77a8cfa into microsoft:main Apr 20, 2026
46 checks passed

This was referenced Apr 20, 2026

chore(main): pre-release 3.3.101 #1274

Merged

chore(main): release hve-core 4.0.0 #1184

Open

github-actions Bot mentioned this pull request Apr 20, 2026

docs: update scripts/lib/README.md to document missing CIHelpers functions #1412

Open

MauroDruwel deleted the fix/centralize-timestamp-regex branch April 23, 2026 17:37

hve-core-release-please Bot mentioned this pull request Apr 27, 2026

chore(main): pre-release 4.1.195 #1476

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scripts): centralize ISO 8601 timestamp regex in CIHelpers#1343

fix(scripts): centralize ISO 8601 timestamp regex in CIHelpers#1343
rezatnoMsirhC merged 5 commits into
microsoft:mainfrom
MauroDruwel:fix/centralize-timestamp-regex

MauroDruwel commented Apr 11, 2026

Uh oh!

katriendg left a comment

Uh oh!

codecov-commenter commented Apr 13, 2026 •

edited

Loading

Uh oh!

rezatnoMsirhC left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MauroDruwel commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MauroDruwel commented Apr 11, 2026

Pull Request

Description

Relationship to #1314

Related Issue(s)

Type of Change

Testing

Files Changed

Checklist

Required Checks

Required Automated Checks

Security Considerations

Uh oh!

katriendg left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rezatnoMsirhC left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MauroDruwel commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Apr 13, 2026 •

edited

Loading