Pull Request

Description

The validate-installation.ps1 and validate-installation.sh scripts were silently skipping .github/skills, allowing a "validated successfully" result even when skills were missing from the installation. This fix adds .github/skills to the required directory checks and adds an informational (non-failing) check for optional experimental subdirectories.

Related Issue(s)

Fixes #1010

Type of Change

Select all that apply:

Code & Documentation:

• Bug fix (non-breaking change fixing an issue)
• New feature (non-breaking change adding functionality)
• Breaking change (fix or feature causing existing functionality to change)
• Documentation update

Infrastructure & Configuration:

• GitHub Actions workflow
• Linting configuration (markdown, PowerShell, etc.)
• Security configuration
• DevContainer configuration
• Dependency update

AI Artifacts:

• Reviewed contribution with prompt-builder agent and addressed all feedback
• Copilot instructions (.github/instructions/*.instructions.md)
• Copilot prompt (.github/prompts/*.prompt.md)
• Copilot agent (.github/agents/*.agent.md)
• Copilot skill (.github/skills/*/SKILL.md)

Other:

• Script/automation (.ps1, .sh, .py)

Testing

Ran the existing Pester test suite with the updated test file. All 14 tests pass:
Tests Passed: 14, Failed: 0, Skipped: 0, Inconclusive: 0, NotRun: 0

New tests added:

->Checks skills directory - creates agents, prompts, instructions but omits skills, asserts output matches Missing.*skills

->Passes validation when experimental directories are absent — confirms absence of experimental dirs does not cause failure

->Reports optional experimental directories when present confirms skills/experimental and agents/experimental are reported with Found optional: when present

Manual Smoke Test

Missing skills — should fail

./validate-installation.ps1 -BasePath ./test-no-skills -Method 1

❌ Missing: .../.github/skills

All dirs present — should pass

./validate-installation.ps1 -BasePath ./hve-core -Method 1

✅ Installation validated successfully

Checklist

Required Checks

• Documentation is updated (if applicable)
• Files follow existing naming conventions
• Changes are backwards compatible (if applicable)
• Tests added for new functionality (if applicable)

Required Automated Checks

The following validation commands must pass before merging:

• Markdown linting: npm run lint:md
• Spell checking: npm run spell-check
• Frontmatter validation: npm run lint:frontmatter
• Skill structure validation: npm run validate:skills
• Link validation: npm run lint:md-links
• PowerShell analysis: npm run lint:ps
• Plugin freshness: npm run plugin:generate

Security Considerations

• This PR does not contain any sensitive or NDA information
• Any new dependencies have been reviewed for security issues
• Security-related scripts follow the principle of least privilege

Additional Notes

All existing tests were updated to include .github/skills in their fixture setup so they continue to pass with the new required directory check.