Skip to content

feat(prompts): add security review prompts#1118

Merged
katriendg merged 6 commits intomicrosoft:mainfrom
obrocki:feat/security-review-prompts
Mar 20, 2026
Merged

feat(prompts): add security review prompts#1118
katriendg merged 6 commits intomicrosoft:mainfrom
obrocki:feat/security-review-prompts

Conversation

@obrocki
Copy link
Copy Markdown
Contributor

@obrocki obrocki commented Mar 18, 2026

Pull Request

Description

Added five security review prompt files under .github/prompts/security/ that delegate to the Security Reviewer agent. Each prompt pre-configures a specific mode or skill selection for simplified user invocation of OWASP vulnerability assessments. Registered all prompts in security and hve-core-all collections with maturity: experimental and regenerated plugin outputs.

Related Issue(s)

Closes #797

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Workflow or CI/CD changes
  • Linting or formatting changes
  • Security-related changes
  • DevContainer changes
  • Dependency updates
  • Copilot instructions (.instructions.md)
  • Copilot prompts (.prompt.md)
  • Copilot agents (.agent.md)
  • Copilot skills (SKILL.md)
  • Scripts or automation (scripts/)
  • Other: _____

Note

AI artifact contributions should be reviewed against the prompt-builder instructions for convention compliance.

Sample Prompts

User Request

/security-review
/security-review-diff
/security-review-web componentPath
/security-review-llm componentPath
/security-review-plan path/to/plan.md

Execution Flow

Each prompt delegates to the Security Reviewer agent with pre-configured inputs:

  • security-review invokes the full orchestrator in audit mode with automatic codebase profiling and OWASP skill detection.
  • security-review-diff hard-sets diff mode, uses the pr-reference skill to discover changed files, and auto-selects skills from profiling.
  • security-review-web bypasses codebase profiling entirely via the target-skill fast-path, applying only owasp-top-10.
  • security-review-llm overrides skill selection with owasp-llm, owasp-agentic while the profiler still runs for codebase context.
  • security-review-plan hard-sets plan mode, analyzing implementation plan documents for pre-implementation security risks and outputting PLAN_REPORT_V1 format.

Output Artifacts

  • Vulnerability reports written to .copilot-tracking/security/ (audit/diff modes produce VULN_REPORT_V1; plan mode produces PLAN_REPORT_V1)

Success Indicators

  • Each prompt resolves to the Security Reviewer agent and executes the expected mode/skill configuration without user intervention beyond the initial invocation.

Testing

  • Validated all 5 prompt files pass npm run lint:frontmatter (374 files, 0 errors)
  • Validated collection metadata via npm run lint:collections-metadata (11 collections, 0 errors)
  • Regenerated plugin outputs via npm run plugin:generate (security collection: 19 items, hve-core-all: 179 items)
  • Verified 10 plugin command symlinks created (5 per collection)
  • Ran npm run lint:all (all steps pass except pre-existing lint:py environment issue unrelated to this PR)

Checklist

Required Checks

  • Documentation has been updated (if applicable)
  • File naming follows existing conventions
  • Changes are backwards compatible (or breaking changes are documented)
  • Tests have been added/updated (if applicable)

AI Artifact Contributions

  • Reviewed against prompt-builder instructions
  • Feedback from prompt testing addressed

Required Automated Checks

  • npm run lint:md
  • npm run spell-check
  • npm run lint:frontmatter
  • npm run validate:skills
  • npm run lint:md-links
  • npm run lint:ps
  • npm run plugin:generate

Security Considerations

  • No sensitive data (API keys, tokens, credentials) included
  • Dependencies reviewed for known vulnerabilities (N/A)
  • Changes follow principle of least privilege (N/A)

Additional Notes

Prompt Mode Skills Profiling
security-review audit (default) Auto-detected Yes
security-review-diff diff Auto-detected Yes
security-review-web audit owasp-top-10 only No (fast-path)
security-review-llm audit owasp-llm + owasp-agentic Yes (context only)
security-review-plan plan Auto-detected Yes

Collections updated: security.collection.yml, hve-core-all.collection.yml (5 entries each, maturity: experimental)

Plugin outputs regenerated: 10 symlinks under plugins/security/commands/ and plugins/hve-core-all/commands/

GHCP Maturity

Caution

This PR contains experimental GHCP artifacts. Experimental artifacts are early-stage and may change significantly.

Artifact Kind Maturity
security-review.prompt.md prompt experimental
security-review-diff.prompt.md prompt experimental
security-review-llm.prompt.md prompt experimental
security-review-plan.prompt.md prompt experimental
security-review-web.prompt.md prompt experimental

obrocki added 2 commits March 18, 2026 15:05
…ssments

- introduce security-review, security-review-diff, security-review-llm, security-review-plan, and security-review-web prompts
- provide descriptions and requirements for each prompt
- update README and collection files to include new prompts

🔒 - Generated by Copilot
@obrocki obrocki requested a review from a team as a code owner March 18, 2026 16:09
@obrocki obrocki changed the title Feat/security review prompts feat(prompts): add security review prompts Mar 18, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.78%. Comparing base (4229df1) to head (5f93a7d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   86.91%   86.78%   -0.14%     
==========================================
  Files          59       59              
  Lines        8752     8688      -64     
==========================================
- Hits         7607     7540      -67     
- Misses       1145     1148       +3     
Flag Coverage Δ
pester 85.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamBerryiii
Copy link
Copy Markdown
Member

@obrocki - have you checked out: #1008

@JasonTheDeveloper
Copy link
Copy Markdown
Contributor

@obrocki - have you checked out: #1008

That PR (#1008) didn't introduce the prompt files required by #979 as that PR was already getting pretty massive and I felt bad for @katriendg 😅 This PR complaments #1008

@katriendg
Copy link
Copy Markdown
Contributor

Thanks @obrocki for doing this work, and I need to apologize for some of the changes I will be suggesting here.

Issue #797 was written before the Security Reviewer agent (PR #1008) merged. The issue acceptance criteria list 5 separate prompts, but now that the agent supports mode={audit|diff|plan} as a first-class argument, the -diff and -plan prompts are redundant with the main security-review prompt's mode parameter. Now that we have a better view on prompt > to agent calls, these changes will make it more finetuned and relevant.
The recommendation is to reduce from 5 prompts to 3.

Again, apologies for the scope change mid-flight, I will update the issue itself, and then posting a few comments around optimizations we could do. I also realize the issue did not list the entire set of docs to update.

A post-PR issue for the entire security reviewer agent(s) and prompt will be added to cover documentation additions.

Copy link
Copy Markdown
Contributor

@katriendg katriendg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the prompts, which are intended for easy / based command to prefill a prompt & swtich to the agent, I believe we can simplify some of the files and make them focused on what they are intending to do for the user: set a baseline of a prompt the user does not have to type in themselves and switch to the right agent.

Given that, I am suggesting some changes. With that, we also need to:

  • Update the readme for the new prompts in .github/prompts/README.md
  • Update the collections when we remove the two prompt files I mentioned in another comment
  • Revalidate the collections
  • Regenerate the plugins

obrocki and others added 3 commits March 19, 2026 11:34
…rgument hints for existing prompts

- delete security-review-diff and security-review-plan prompts
- update argument hints in security-review-llm, security-review-web, and security-review prompts to use [scope=path/to/component]

🔒 - Generated by Copilot
- include prompts for vulnerability assessments with configurable options
- enhance security review capabilities for web and LLM contexts

🔒 - Generated by Copilot
@obrocki obrocki requested a review from katriendg March 20, 2026 11:28
Copy link
Copy Markdown
Contributor

@katriendg katriendg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @obrocki for the changes. I believe we can merge this in to accompany the security agent in the next pre-release push. With every artifact as experimental we can use a testing phase for user feedback and tweak as we get usage data.

@katriendg katriendg merged commit ad30967 into microsoft:main Mar 20, 2026
32 checks passed
WilliamBerryiii added a commit that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](hve-core-v3.1.46...hve-core-v3.2.0)
(2026-03-20)


### ✨ Features

* add -OutputPath parameter to Validate-MarkdownFrontmatter.ps1
([#1134](#1134))
([fdf1bcf](fdf1bcf)),
closes [#1006](#1006)
* add action version consistency scan workflow
([#1127](#1127))
([4229df1](4229df1))
* **agent:** MVE Experiment Designer
([#976](#976))
([70f86ca](70f86ca))
* **agents:** add ADO Backlog Manager orchestrator agent
([#800](#800))
([fae3987](fae3987))
* **agents:** add meeting analyst agent for transcript analysis using
work-iq ([#502](#502))
([5345b5b](5345b5b))
* **agents:** add quick-reference line to RPI Phase 5 suggestions
([#897](#897))
([9a90f39](9a90f39))
* **agents:** add RAI Planner, enhance SSSC Planner, and redesign
Security Planner
([#979](#979))
([06f826c](06f826c))
* **agents:** add symmetric cross-system handoff to GitHub Backlog
Manager ([#952](#952))
([ba34a35](ba34a35))
* **agents:** Functional Code Review Agent — pre-PR functional
correctness reviewer
([#733](#733))
([9cf63b7](9cf63b7))
* **build:** add Python extensions and uv 0.10.8 to devcontainer
([#920](#920))
([9ca0579](9ca0579))
* **build:** add uv ecosystem to Dependabot configuration
([#913](#913))
([2a4bd39](2a4bd39))
* **build:** enable npm pinning enforcement in dependency scan
([#838](#838))
([4e9e31f](4e9e31f))
* **build:** migrate attestation actions to v4.1.0 and add SBOM
verification docs
([#841](#841))
([ca1e65b](ca1e65b))
* **collections:** add four new validator checks (orphan, duplicate,
companion, coverage)
([#869](#869))
([1a96b73](1a96b73))
* **devcontainer,security:** add enterprise artifact hub configuration
([#1032](#1032))
([1d56d25](1d56d25))
* **docs:** add Rust coding standards and guidelines
([#809](#809))
([d4c4899](d4c4899))
* **extension:** add Microsoft logo icon to VS Code Marketplace listings
([#906](#906))
([82aca41](82aca41))
* **github:** add declarative label management
([#953](#953))
([a1a6845](a1a6845))
* **instructions:** add ADO backlog shared infrastructure
([#786](#786))
([1914078](1914078))
* **instructions:** add ADO backlog sprint planning and capacity
tracking ([#788](#788))
([d6fb77d](d6fb77d))
* **instructions:** add ADO triage workflow and prompt
([#787](#787))
([cde0190](cde0190))
* **instructions:** add shared story quality conventions and sprint
planning ([#803](#803))
([a2f18e3](a2f18e3))
* **prompts:** add ADO discovery and work item prompts with agent
routing ([#790](#790))
([7e74523](7e74523))
* **prompts:** add security review prompts
([#1118](#1118))
([ad30967](ad30967))
* **scripts:** add dynamic Python skill discovery for lint/test
([#957](#957))
([0a90f57](0a90f57))
* **scripts:** add Get-StandardTimestamp utility to CIHelpers module
([#1126](#1126))
([b273a4b](b273a4b))
* **scripts:** add Python copyright header validation
([#905](#905))
([67df902](67df902))
* **scripts:** add Python skill support to Validate-SkillStructure
([#903](#903))
([68479d9](68479d9))
* **scripts:** add workflow npm command scanning to dependency pinning
([#837](#837))
([6b5ae06](6b5ae06))
* **security:** add basic security reviewer agent with owasp skills
([#1008](#1008))
([cb1fd05](cb1fd05))
* **security:** add sigstore attestation bundles and fix
component-detection action
([#1148](#1148))
([f79c272](f79c272))
* **skills:** add Atheris fuzz harness with CI workflow integration
([#1102](#1102))
([d337e1d](d337e1d))
* **skills:** add PowerPoint automation skill with YAML-driven deck
generation ([#868](#868))
([00465cd](00465cd))
* **skills:** convert hve-core-installer agent to self-contained skill
([#846](#846))
([1d821fb](1d821fb))
* **skills:** enhance pr-reference skill with flexible filtering and
base branch detection
([#1095](#1095))
([26a32ea](26a32ea))
* **workflows:** add devcontainer infrastructure change log workflow
([#899](#899))
([8aca446](8aca446))
* **workflows:** add milestone auto-close on stable and pre-release
publishes ([#834](#834))
([79362b1](79362b1))
* **workflows:** add ms.date documentation freshness checking
([#969](#969))
([3ed441c](3ed441c))
* **workflows:** add Python linting CI workflow with Ruff
([#951](#951))
([f89f0eb](f89f0eb))
* **workflows:** add Python testing CI workflow with pytest and Codecov
([#934](#934))
([5e8306f](5e8306f))
* **workflows:** add uv and Python package sync to copilot-setup-steps
([#921](#921))
([45d517d](45d517d))


### 🐛 Bug Fixes

* **build:** override Linguist vendored flag for Python skill files
([#1155](#1155))
([0eee5b6](0eee5b6))
* **build:** override serialize-javascript to &gt;=7.0.3 for RCE fix
([#876](#876))
([e49039a](e49039a))
* **build:** resolve Pinned-Dependencies alerts for vsce npm commands in
extension workflows
([#782](#782))
([89dad9d](89dad9d))
* **build:** update undici and yauzl overrides for security audit
([#1030](#1030))
([2c2f92f](2c2f92f))
* **docs:** add CLI Plugins to install.md navigation surfaces
([#902](#902))
([79d6595](79d6595))
* **docs:** add sidebar ordering for Design Thinking documentation
([#832](#832))
([551fddc](551fddc)),
closes [#830](#830)
* **docs:** graduate design-thinking to preview and correct stale
collection references
([#831](#831))
([5110e35](5110e35))
* **docs:** include project-planning in UX Designer install guidance
([#908](#908))
([e7aa9bc](e7aa9bc))
* **docs:** remediate writing-style convention violations
([#865](#865))
([68b04bc](68b04bc))
* **docs:** remove draft content announcement banner
([#825](#825))
([b45de80](b45de80))
* **docs:** remove unbounded path-to-regexp override breaking SSG
([#1153](#1153))
([d810018](d810018))
* **docs:** use actual clone paths instead of folder display names in
multi-root workspace settings
([#984](#984))
([5dbab82](5dbab82))
* **instructions:** replace black with ruff in uv-projects
([#898](#898))
([b0c06d9](b0c06d9))
* **scripts:** cover .github/ skill files in copyright header validation
([#1055](#1055))
([#1098](#1098))
([27fbd33](27fbd33))
* **scripts:** eliminate phantom git changes from plugin generation
([#1035](#1035))
([e49a1b5](e49a1b5))
* **scripts:** enable JSON log output for lint:version-consistency
([#1033](#1033))
([52b0885](52b0885))
* **security:** calculate compliance score from total scanned
dependencies ([#930](#930))
([c112c3d](c112c3d))
* **skills:** add AST validation and namespace restriction for
content-extra.py
([#1027](#1027))
([c50c7a3](c50c7a3))
* **skills:** add depth limits to recursive PowerPoint processing
functions ([#1028](#1028))
([bf08994](bf08994))
* **skills:** harden XML parsing and blob writes in powerpoint extract
([#1053](#1053))
([89d24b1](89d24b1))
* **skills:** resolve ruff lint and format violations in powerpoint
skill ([#1048](#1048))
([17bbe7a](17bbe7a))
* **workflows:** add uv.lock dependencies submission have fork-skip
condition ([#1109](#1109))
([dec56ac](dec56ac))
* **workflows:** automate weekly SHA staleness check with issue creation
([#975](#975))
([1ea4caa](1ea4caa))
* **workflows:** close Codecov integration gaps for Pester and pytest
flags ([#1106](#1106))
([cca29b7](cca29b7))
* **workflows:** propagate uv sync errors in copilot-setup-steps
([#961](#961))
([df88d7c](df88d7c))
* **workflows:** resolve release-please skip cascade and Python project
discovery ([#1043](#1043))
([79993e2](79993e2))
* **workflows:** scan only commit subjects for breaking change detection
([#1157](#1157))
([a38a657](a38a657))


### 📚 Documentation

* clarify HVE Core Extension vs Installer messaging across documentation
([#965](#965))
([0fceb8f](0fceb8f))
* **docs:** add ADO integration user documentation
([#935](#935))
([ec89302](ec89302))
* **docs:** add Project Planning agent documentation
([#936](#936))
([3a3a0fd](3a3a0fd))
* **onboarding:** overhaul marketplace onboarding and documentation site
([#982](#982))
([4309e10](4309e10))


### ♻️ Refactoring

* **build:** merge code-review collection into coding-standards
([#863](#863))
([8027e7b](8027e7b))
* **workflows:** rename release pipeline workflows and add marketplace
automation triggers
([#829](#829))
([b6397f4](b6397f4))


### 🔧 Maintenance

* **build:** add clean:logs npm script
([#1122](#1122))
([f85fe02](f85fe02)),
closes [#988](#988)
* **build:** add JSON reporter for cspell
([#1123](#1123))
([6d59f67](6d59f67))
* **ci:** add multi-arch support to copilot-setup-steps binary downloads
([#955](#955))
([8d0c706](8d0c706))
* **deps-dev:** bump cspell from 9.6.4 to 9.7.0 in the npm-dependencies
group ([#839](#839))
([3fa16ff](3fa16ff))
* **deps:** bump actions/dependency-review-action from 4.8.3 to 4.9.0 in
the github-actions group across 1 directory
([#942](#942))
([1a9b858](1a9b858))
* **deps:** bump cairosvg from 2.8.2 to 2.9.0 in
/.github/skills/experimental/powerpoint
([#1025](#1025))
([f4deda7](f4deda7))
* **deps:** bump dompurify from 3.3.1 to 3.3.2 in /docs/docusaurus
([#924](#924))
([d2060d6](d2060d6))
* **deps:** bump svgo from 3.3.2 to 3.3.3 in /docs/docusaurus
([#880](#880))
([6dc2406](6dc2406))
* **deps:** bump the github-actions group across 1 directory with 4
updates ([#1100](#1100))
([2290dc0](2290dc0))
* **deps:** bump the github-actions group with 6 updates
([#840](#840))
([f57bc01](f57bc01))
* **docs:** correct New-MsDateReport table rendering and refresh stale
docs ([#1114](#1114))
([c2b806f](c2b806f))
* **settings:** remove orphaned Checkov config and stale gitignore
entries ([#870](#870))
([98fcd74](98fcd74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
Co-authored-by: Bill Berry <wberry@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(prompts): add security review prompts (security-review, security-review-web, security-review-llm)

5 participants