Skip to content

add longPathAware to shim manifest#2303

Merged
anmaxvl merged 1 commit intomicrosoft:mainfrom
anmaxvl:manifest-long-path-support
Oct 31, 2024
Merged

add longPathAware to shim manifest#2303
anmaxvl merged 1 commit intomicrosoft:mainfrom
anmaxvl:manifest-long-path-support

Conversation

@anmaxvl
Copy link
Copy Markdown
Contributor

@anmaxvl anmaxvl commented Oct 31, 2024

Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

@anmaxvl anmaxvl requested a review from a team as a code owner October 31, 2024 04:53
@anmaxvl anmaxvl force-pushed the manifest-long-path-support branch 2 times, most recently from 615f0af to edf9033 Compare October 31, 2024 09:17
Depending on the version of Go used to build the shim binaries
the process may or may not be long path aware, for example MS Go
removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the manifest-long-path-support branch from edf9033 to 01194d5 Compare October 31, 2024 16:22
@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 31, 2024

repushed, since license/cla was stuck.

@anmaxvl anmaxvl merged commit 1c29e9d into microsoft:main Oct 31, 2024
@anmaxvl anmaxvl deleted the manifest-long-path-support branch October 31, 2024 23:47
anmaxvl added a commit that referenced this pull request Oct 29, 2025
Depending on the version of Go used to build the shim binaries
the process may or may not be long path aware, for example MS Go
removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 1c29e9d)
anmaxvl added a commit that referenced this pull request Oct 29, 2025
…shim manifest

add `longPathAware` to shim manifest (#2303)

Depending on the version of Go used to build the shim binaries
the process may or may not be long path aware, for example MS Go
removed it microsoft/go@af3d04e.

Microsoft recommends adding long path support through manifest
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later

Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 1c29e9d)

----
#### AI description  (iteration 1)
#### PR Classification
New feature

#### PR Summary
This pull request adds long path support to the shim manifest and updates version information.
- `cmd/containerd-shim-runhcs-v1/versioninfo.json`: Updated company name, original filename, and product name.
- `cmd/containerd-shim-runhcs-v1/containerd-shim-runhcs-v1.exe.manifest`: Added `longPathAware` setting to enable long path support.
jiechen0826 pushed a commit to jiechen0826/hcsshim that referenced this pull request Mar 16, 2026
This PR updates the ADO main mirror to c65b789 in line with upstream main

This includes the following changes:
- Fix issue with mask length of gateway addresses microsoft#2305
- Fixing endpoint type microsoft#2289
- Update dmverity tool to take a directory as input to create a VHD microsoft#2274
- Update containerd to v1.7.23 microsoft#2293
- Update go version to 1.22 microsoft#2300
- add `longPathAware` to shim manifest  microsoft#2303

----
#### AI description  (iteration 1)
#### PR Classification
Code cleanup and enhancement.

#### PR Summary
Refactored error definitions to improve error handling and mapping to grpc errors.
- `vendor/github.com/containerd/errdefs/errors.go`: Replaced simple error variables with structured error types, added detailed error interfaces and helper functions for better error identification and handling.

Related work items: microsoft#2274, microsoft#2279, microsoft#2287, microsoft#2293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants