Update go version + Switch to using containerd/errdefs/pkg/errgrpc for grpc translation#2300
Merged
kiashok merged 2 commits intomicrosoft:mainfrom Oct 29, 2024
Merged
Conversation
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Contributor
Author
|
cc @dmcgowan |
anmaxvl
approved these changes
Oct 28, 2024
helsaawy
approved these changes
Oct 28, 2024
dmcgowan
approved these changes
Oct 28, 2024
jiechen0826
pushed a commit
to jiechen0826/hcsshim
that referenced
this pull request
Mar 16, 2026
This PR updates the ADO main mirror to c65b789 in line with upstream main This includes the following changes: - Fix issue with mask length of gateway addresses microsoft#2305 - Fixing endpoint type microsoft#2289 - Update dmverity tool to take a directory as input to create a VHD microsoft#2274 - Update containerd to v1.7.23 microsoft#2293 - Update go version to 1.22 microsoft#2300 - add `longPathAware` to shim manifest microsoft#2303 ---- #### AI description (iteration 1) #### PR Classification Code cleanup and enhancement. #### PR Summary Refactored error definitions to improve error handling and mapping to grpc errors. - `vendor/github.com/containerd/errdefs/errors.go`: Replaced simple error variables with structured error types, added detailed error interfaces and helper functions for better error identification and handling. Related work items: microsoft#2274, microsoft#2279, microsoft#2287, microsoft#2293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using containerd/errdefs/pkg/errgrpc for grpc translation. This helps to remove the containerd cyclic dependency in containerd/containerd main branch.
This PR also updated the go version in go.mod