Update the generated files header#137
Closed
dlsniper wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
This updates the generated files header to be compliant with the Go standard for machine generated files: https://golang.org/issues/13560 It also tags the file as Windows only build so that static analysis tools such as Gogland can better infer the context. Signed-off-by: Florin Patan <florinpatan@gmail.com>
Contributor
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Fixes potential delete on unmounts failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the generated files header to be compliant with the Go
standard for machine generated files: https://golang.org/issues/13560
It also tags the file as Windows only build so that static analysis
tools such as Gogland can better infer the context.
It supersedes #133 and it also just flags the relevant Go files as
Windows only. I can make the change to tag all files as Windows
only but I think that's a bit excessive. Please let me know about your
decision.
Thank you.