Tag all files as being for Windows only.#133
Closed
friism wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
This prevents e.g. go guru when running on a different platform tripping over these files even when the build tags are correctly set. In my case this was the case on the github.com/containerd/containerd code base due to hcsshim being vendored there. I must confess to a small naughtiness which is that since I was unable to run mksyscall_windows on my Linux machine I have hand edited both the generator and the generated file.
|
Any chance of making progress on this? |
Contributor
|
Closing as too far diverged from master. |
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Add a retry when connecting stdin/stdout/stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a carry of #132 so @ijc doesn't have to sign the CLA.
Original description below
This prevents e.g. go guru when running on a different platform tripping over
these files even when the build tags are correctly set. In my case this was the
case on the github.com/containerd/containerd code base due to hcsshim being
vendored there.
I must confess to a small naughtiness which is that since I was unable to run
mksyscall_windows on my Linux machine I have hand edited both the generator and
the generated file.