Revert "Fix working_dir negative test error expectation (#1348)"#1368
Merged
anmaxvl merged 1 commit intomicrosoft:masterfrom Apr 22, 2022
Merged
Conversation
ccf0a6f to
ac2931e
Compare
helsaawy
approved these changes
Apr 22, 2022
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
What was the context for removing and re-adding the quotes?
Contributor
Author
dcantah
approved these changes
Apr 22, 2022
Contributor
dcantah
left a comment
There was a problem hiding this comment.
LGTM. Would be good to have the reason for the revert in the commit description before you check in
…)" This reverts commit 2028de8. During local testing a gcs with an older version of security policy was used when doing the fix: microsoft#1322. As we can see, the quotations weren't there. However, later a PR was merged, which added them: microsoft#1311 Signed-off-by: Maksim An <maksiman@microsoft.com>
ac2931e to
77b0ccc
Compare
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2028de8.