Removed shim publisher dependence on global flag/setting #1343
Merged
helsaawy merged 1 commit intomicrosoft:masterfrom Apr 15, 2022
Merged
Removed shim publisher dependence on global flag/setting #1343helsaawy merged 1 commit intomicrosoft:masterfrom
helsaawy merged 1 commit intomicrosoft:masterfrom
Conversation
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
dcantah
approved these changes
Apr 15, 2022
Contributor
|
Why did CRI not hit this before since its all in custom namespaces? I'm surprised the events ever worked globally. Were they just matching any global event by type id? |
Contributor
Author
This (should?) have worked properly originally, its just that we were reading a global flag every time we published, which seemed bad. |
Contributor
|
Oh lol. Misread the code. Yes I see that now, good fix |
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shim
eventPublishernow uses an internal setting for the namespace instead of relying on a global flag.Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com