Add GetCachedSupportedFeatures method to hcn package by dcantah · Pull Request #1123 · microsoft/hcsshim

dcantah · 2021-08-19T03:15:18Z

To avoid a breaking change on GetSupportedFeatures introduce a new
GetCachedSupportedFeatures method. This method does the feature check
and version parsing once and then assigns a global with the information.

This can be used to optimize for situations where many uses of the
hcn.IsXSupported methods are going to be used (kube-proxy for example).
Previously they would call GetSupportedFeatures and end up re-querying and
revalidating the feature ranges every time.

Signed-off-by: Daniel Canter dcanter@microsoft.com

To avoid a breaking change on GetSupportedFeatures introduce a new GetCachedSupportedFeatures method. This method does the feature check and version parsing once and then assigns a global with the information. This can be used to optimize for situations where many uses of the hcn.IsXSupported methods are going to be used (kube-proxy for example). Signed-off-by: Daniel Canter <dcanter@microsoft.com>

hcn/hcnsupport.go

dcantah · 2021-08-19T10:56:12Z

@kevpar @msscotb Feedback addressed, ptal when you get another chance. Thanks!

- Change versionErr -> featuresErr - Move work inside of the sync.Once out to its own function so we can use standard return err error handling and simply assign the output in GetCachedSupportedFeatures - Mark GetSupportedFeatures as deprecated. Signed-off-by: Daniel Canter <dcanter@microsoft.com>

hcn/hcnsupport.go

Signed-off-by: Daniel Canter <dcanter@microsoft.com>

kevpar · 2021-08-19T19:57:36Z

hcn/hcnsupport.go

+	return supportedFeatures, featuresErr
+}
+
+// Deprecated: Use GetCachedSupportedFeatures instead.


I think the main comment needs to be first or it will be flagged as not following function comment guidelines.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>

kevpar

LGTM

Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126

dcantah requested a review from a team as a code owner August 19, 2021 03:15

msscotb reviewed Aug 19, 2021

View reviewed changes

hcn/hcnsupport.go Show resolved Hide resolved