Updating HNS v1 policy schemas with correct omitEmpty fields#1078
Merged
dcantah merged 1 commit intomicrosoft:masterfrom Jul 23, 2021
Merged
Updating HNS v1 policy schemas with correct omitEmpty fields#1078dcantah merged 1 commit intomicrosoft:masterfrom
dcantah merged 1 commit intomicrosoft:masterfrom
Conversation
Signed-off-by: elweb9858 <elweb@microsoft.com>
Contributor
Author
Contributor
|
lgtm |
Contributor
|
@elweb9858 Are we ok to check this in? Any others we're waiting to take a look? |
Contributor
Author
|
@dcantah this is ok to check in |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elweb9858 elweb@microsoft.com
Several fields in the NatPolicy and AclPolicy v1 schema structs do not reflect the omitEmpty json field. This can be problematic in cases of integer fields because if the user does not specify a value for this field, it will be assigned a 0 during marshalling. In cases like protocol, a value of 0 is not something HNS recognizes so policy application will fail. This PR reflects all the omitEmpty fields properly in the hcsshim v1 policy schema structs (all v2 structs are currently up to date).