use requested stdio in call to exec in shim host#1044
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Jun 9, 2021
Merged
use requested stdio in call to exec in shim host#1044katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere merged 1 commit intomicrosoft:masterfrom
Conversation
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
dcantah
reviewed
Jun 8, 2021
| } | ||
| np, err := NewNpipeIO(ctx, req.Stdin, req.Stdout, req.Stderr, req.Terminal) | ||
| if err != nil { | ||
| return 0, err |
Contributor
There was a problem hiding this comment.
Ehh we don't for ExecInUvm in this case either or for there being no args, I usually return the error case if err != nil but this is just a nit anyways.
dcantah
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses broken tests for process isolated container update by making use of the requested stdio pipes specified in the call to
ExecInShimHostSigned-off-by: Kathryn Baldauf kabaldau@microsoft.com