Remove internal GCS connection functionality#1038
Merged
dcantah merged 1 commit intomicrosoft:masterfrom May 29, 2021
Merged
Conversation
HCS maintains an internal guest connection to the GCS normally if you request it. However, there are certain features that require us to maintain an external connection (external in this sense meaning not in HCS) instead like late cloning. We had swapped to always managing the connection to the GCS ourselves some time ago and afaik there's been no fallout from it, so I propose let's get rid of the internal branches altogether. This greatly simplifies the work for going through a different virtstack for hypervisor isolated containers as well. Ran go mod vendor in /test to bring in the changes as well. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
8264aa4 to
cd895b4
Compare
|
did you run the cri-containerd tests for this change? |
Contributor
Author
|
@katiewasnothere Yea, there's basically no change as it's the default already, I removed the one test (that I could find) that resorted to internal |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HCS maintains an internal guest connection to the GCS normally if you request it.
However, there are certain features that require us to maintain an external connection
(external in this sense meaning not in HCS) instead like late cloning.
We had swapped to always managing the connection to the GCS ourselves some time ago and
afaik there's been no fallout from it, so I propose let's get rid of the internal branches
altogether. This greatly simplifies the work for going through a different virtstack for
hypervisor isolated containers as well.
Ran go mod vendor in /test to bring in the changes as well.
Signed-off-by: Daniel Canter dcanter@microsoft.com