Fix bug with VSMB & SCSI mounts on the same host path#1021
Merged
ambarve merged 1 commit intomicrosoft:masterfrom May 18, 2021
Merged
Fix bug with VSMB & SCSI mounts on the same host path#1021ambarve merged 1 commit intomicrosoft:masterfrom
ambarve merged 1 commit intomicrosoft:masterfrom
Conversation
When mounting a VHD at host path `C:\data\test.vhdx` into the container over SCSI and also sharing the same VHD inside the container over VSMB the current code just shares the VHD inside the container for both mounts instead of actually SCSI mounting the VHD for one of the mounts. This change fixes that. Signed-off-by: Amit Barve <ambarve@microsoft.com>
dcantah
reviewed
May 8, 2021
anmaxvl
approved these changes
May 18, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Fix bug with VSMB & SCSI mounts on the same host path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mounting a VHD at host path
C:\data\test.vhdxinto the container over SCSI and also sharing the same VHD inside the container over VSMB the current code just shares the VHD inside the container for both mounts instead of actually SCSI mounting the VHD for one of the mounts. This change fixes that.