Add new flags to integration tests to specify virtstack#1019
Merged
dcantah merged 1 commit intomicrosoft:masterfrom May 19, 2021
Merged
Add new flags to integration tests to specify virtstack#1019dcantah merged 1 commit intomicrosoft:masterfrom
dcantah merged 1 commit intomicrosoft:masterfrom
Conversation
Add some new flags to the integration test suite that enables choosing what virtstack to use for hypervisor isolated containers. This makes it so we can re-use our existing tests and just pass in new flags to run them with a new stack. To have this play nice with the test suite I changed `getRunPodSandboxRequest` to take in whatever annotations we'd want to set on the pod config directly instead of us having to set them on the returned object itself. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
May 7, 2021
Contributor
anmaxvl
left a comment
There was a problem hiding this comment.
another option, I guess, would be to have a config for the service and pass path to it? but this version also LGTM
Contributor
Author
|
@anmaxvl Config for the service just for these tests or have the service use this config you mean? If the latter, as the service we're talking to is unknown (just anything that implements the ttrpc service) I guess we'd have to control what the config would look like and the server would have to play nice and conform. For the most part we're going to be launching the server ourselves so we still need to know the path to the binary however to invoke it. |
Contributor
|
I meant a config for the tests, which is more of a nit. |
Contributor
|
is this good to go? |
Contributor
Author
|
@anmaxvl Oop, yea should be. I wanted to try out something last week but never got around to it but I'll do that today |
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
May 19, 2021
In this PR (microsoft#1019) I changed how we pass annotations to the cri-containerd suite, but this PR (microsoft#1030) got in before which added a new test. This caused the CI to fail on checkin of the first PR. Always rebase kids Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some new flags to the integration test suite that enables choosing what virtstack
to use for hypervisor isolated containers. This makes it so we can re-use our existing tests
and just pass in new flags to run them with a new stack.
To have this play nice with the test suite I changed
getRunPodSandboxRequestto take in whateverannotations we'd want to set on the pod config directly instead of us having to set them on the
returned object itself.
Signed-off-by: Daniel Canter dcanter@microsoft.com