Skip to content

[iOS][macOS] Move PlatformProviding code to FluentUI_common#2198

Merged
mischreiber merged 3 commits intomainfrom
testPlatformProviding
Aug 20, 2025
Merged

[iOS][macOS] Move PlatformProviding code to FluentUI_common#2198
mischreiber merged 3 commits intomainfrom
testPlatformProviding

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Aug 20, 2025 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Despite all the tricky attempts to handle multiple build systems, we're still seeing reports in the wild of our weird Platform[.+]Providing cross-module hooks breaking down. So in the name of cleaner, easier integration, let's just move those into FluentUI_common.

Verification

Verified that themeing works as expected in iOS, macOS, and visionOS.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner August 20, 2025 20:26
@mischreiber mischreiber enabled auto-merge (squash) August 20, 2025 20:35
@mischreiber mischreiber merged commit 07febe4 into main Aug 20, 2025
7 checks passed
@mischreiber mischreiber deleted the testPlatformProviding branch August 20, 2025 21:29
mischreiber added a commit to mischreiber/fluentui-apple that referenced this pull request Aug 21, 2025
@mischreiber
[iOS][macOS] Move PlatformProviding code to FluentUI_common (micros…
c7daa99 
…oft#2198)

* Move implementation of PlatformThemeProviding to common

* Same for FontInfo and GlobalTokens
@mischreiber mischreiber mentioned this pull request Aug 21, 2025
Merged
12 tasks
mischreiber added a commit that referenced this pull request Aug 22, 2025
@mischreiber
[iOS][macOS] Move PlatformProviding code to FluentUI_common (#2198) (…
84c2fc7 
…#2199)

* Move implementation of PlatformThemeProviding to common

* Same for FontInfo and GlobalTokens
@thomasjross thomasjross mentioned this pull request Sep 20, 2025
Merged
12 tasks
@joannaquu joannaquu mentioned this pull request Oct 23, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nodes11 nodes11 nodes11 approved these changes

@joannaquu joannaquu joannaquu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischreiber @nodes11 @joannaquu