Skip to content

[main_0.34][cherry-pick] Move PlatformProviding code to FluentUI_common#2199

Merged
mischreiber merged 1 commit intomicrosoft:main_0.34from
mischreiber:cherry-pick-PlatformProviding
Aug 22, 2025
Merged

[main_0.34][cherry-pick] Move PlatformProviding code to FluentUI_common#2199
mischreiber merged 1 commit intomicrosoft:main_0.34from
mischreiber:cherry-pick-PlatformProviding

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Aug 21, 2025 •
edited by microsoft-github-policy-service bot
Loading

Cherry-pick of #2198. Original notes below.

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Despite all the tricky attempts to handle multiple build systems, we're still seeing reports in the wild of our weird Platform[.+]Providing cross-module hooks breaking down. So in the name of cleaner, easier integration, let's just move those into FluentUI_common.

Verification

Verified that themeing works as expected in iOS, macOS, and visionOS.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@mischreiber
[iOS][macOS] Move PlatformProviding code to FluentUI_common (micros…
c7daa99 
…oft#2198)

* Move implementation of PlatformThemeProviding to common

* Same for FontInfo and GlobalTokens
@mischreiber mischreiber requested a review from a team as a code owner August 21, 2025 15:52
@mischreiber mischreiber enabled auto-merge (squash) August 21, 2025 15:54
@mischreiber mischreiber disabled auto-merge August 22, 2025 02:57
@mischreiber mischreiber enabled auto-merge (squash) August 22, 2025 02:57
@mischreiber mischreiber disabled auto-merge August 22, 2025 02:59
@mischreiber mischreiber merged commit 84c2fc7 into microsoft:main_0.34 Aug 22, 2025
11 of 13 checks passed
@mischreiber mischreiber deleted the cherry-pick-PlatformProviding branch August 22, 2025 02:59
@mischreiber mischreiber mentioned this pull request Aug 22, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu joannaquu joannaquu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mischreiber @joannaquu