Remove -warnings-as-errors in SPM package#2181
Merged
mischreiber merged 1 commit intomicrosoft:mainfrom Jun 16, 2025
Merged
Conversation
joannaquu
approved these changes
Jun 16, 2025
mischreiber
added a commit
to mischreiber/fluentui-apple
that referenced
this pull request
Jun 16, 2025
12 tasks
mischreiber
added a commit
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Per https://forums.swift.org/t/warnings-as-errors-in-sub-packages/70810: Having this flag enabled in a sub-package causes conflicts with the automatic "-suppress-warnings" flag added by Xcode.
Verification
Builds and runs still, including as sub-package
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow