Skip to content

[cherry-pick] Remove -warnings-as-errors in SPM package (#2181)#2182

Merged
mischreiber merged 1 commit intomicrosoft:main_0.34from
mischreiber:warnings-as-error-cherry-pick
Jun 16, 2025
Merged

[cherry-pick] Remove -warnings-as-errors in SPM package (#2181)#2182
mischreiber merged 1 commit intomicrosoft:main_0.34from
mischreiber:warnings-as-error-cherry-pick

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Jun 16, 2025

Cherry-pick of #2181. Notes below:

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Per https://forums.swift.org/t/warnings-as-errors-in-sub-packages/70810: Having this flag enabled in a sub-package causes conflicts with the automatic "-suppress-warnings" flag added by Xcode.

Verification

Builds and runs still, including as sub-package

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner June 16, 2025 19:59
@mischreiber mischreiber enabled auto-merge (squash) June 16, 2025 20:00
@mischreiber mischreiber merged commit adee9ea into microsoft:main_0.34 Jun 16, 2025
7 checks passed
@mischreiber mischreiber mentioned this pull request Jun 16, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants