Update d3 dependency versions to 3.x.x and 4.x.x#32463
Merged
AtishayMsft merged 8 commits intomasterfrom Sep 11, 2024
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 664 | 630 | 5000 | |
| Button | mount | 320 | 303 | 5000 | |
| Field | mount | 1150 | 1148 | 5000 | |
| FluentProvider | mount | 717 | 728 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 91 | 81 | 10 | |
| MakeStyles | mount | 843 | 866 | 50000 | |
| Persona | mount | 1773 | 1745 | 5000 | |
| SpinButton | mount | 1409 | 1419 | 5000 | |
| SwatchPicker | mount | 1666 | 1691 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 85 | 70 | 1.21:1 |
| AttachmentMinimalPerf.default | 87 | 80 | 1.09:1 |
| CarouselMinimalPerf.default | 278 | 257 | 1.08:1 |
| CardMinimalPerf.default | 319 | 299 | 1.07:1 |
| GridMinimalPerf.default | 203 | 190 | 1.07:1 |
| RefMinimalPerf.default | 114 | 107 | 1.07:1 |
| StatusMinimalPerf.default | 418 | 390 | 1.07:1 |
| TextMinimalPerf.default | 209 | 196 | 1.07:1 |
| TreeWith60ListItems.default | 90 | 84 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 154 | 145 | 1.06:1 |
| DividerMinimalPerf.default | 222 | 210 | 1.06:1 |
| LayoutMinimalPerf.default | 210 | 199 | 1.06:1 |
| PopupMinimalPerf.default | 363 | 344 | 1.06:1 |
| ProviderMinimalPerf.default | 208 | 197 | 1.06:1 |
| IconMinimalPerf.default | 394 | 372 | 1.06:1 |
| ButtonMinimalPerf.default | 89 | 85 | 1.05:1 |
| ListNestedPerf.default | 341 | 325 | 1.05:1 |
| SkeletonMinimalPerf.default | 208 | 198 | 1.05:1 |
| BoxMinimalPerf.default | 200 | 193 | 1.04:1 |
| DropdownManyItemsPerf.default | 399 | 385 | 1.04:1 |
| ImageMinimalPerf.default | 235 | 225 | 1.04:1 |
| MenuMinimalPerf.default | 522 | 503 | 1.04:1 |
| TreeMinimalPerf.default | 491 | 471 | 1.04:1 |
| ChatMinimalPerf.default | 443 | 430 | 1.03:1 |
| FormMinimalPerf.default | 231 | 225 | 1.03:1 |
| LabelMinimalPerf.default | 228 | 222 | 1.03:1 |
| AttachmentSlotsPerf.default | 646 | 634 | 1.02:1 |
| MenuButtonMinimalPerf.default | 960 | 941 | 1.02:1 |
| RadioGroupMinimalPerf.default | 269 | 264 | 1.02:1 |
| TableManyItemsPerf.default | 1118 | 1094 | 1.02:1 |
| AnimationMinimalPerf.default | 316 | 313 | 1.01:1 |
| DropdownMinimalPerf.default | 1455 | 1434 | 1.01:1 |
| HeaderSlotsPerf.default | 468 | 463 | 1.01:1 |
| InputMinimalPerf.default | 547 | 540 | 1.01:1 |
| ListMinimalPerf.default | 318 | 315 | 1.01:1 |
| SliderMinimalPerf.default | 738 | 728 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2225 | 2195 | 1.01:1 |
| CustomToolbarPrototype.default | 1492 | 1471 | 1.01:1 |
| TooltipMinimalPerf.default | 1277 | 1262 | 1.01:1 |
| ButtonOverridesMissPerf.default | 645 | 647 | 1:1 |
| ButtonSlotsPerf.default | 317 | 316 | 1:1 |
| CheckboxMinimalPerf.default | 1143 | 1144 | 1:1 |
| DialogMinimalPerf.default | 450 | 450 | 1:1 |
| ItemLayoutMinimalPerf.default | 707 | 708 | 1:1 |
| RosterPerf.default | 1563 | 1570 | 1:1 |
| TableMinimalPerf.default | 238 | 238 | 1:1 |
| ChatWithPopoverPerf.default | 204 | 206 | 0.99:1 |
| DatepickerMinimalPerf.default | 3599 | 3621 | 0.99:1 |
| FlexMinimalPerf.default | 159 | 160 | 0.99:1 |
| HeaderMinimalPerf.default | 212 | 214 | 0.99:1 |
| ListCommonPerf.default | 377 | 380 | 0.99:1 |
| LoaderMinimalPerf.default | 196 | 197 | 0.99:1 |
| ProviderMergeThemesPerf.default | 643 | 649 | 0.99:1 |
| ReactionMinimalPerf.default | 211 | 213 | 0.99:1 |
| TextAreaMinimalPerf.default | 286 | 289 | 0.99:1 |
| ToolbarMinimalPerf.default | 545 | 551 | 0.99:1 |
| AlertMinimalPerf.default | 154 | 157 | 0.98:1 |
| ListWith60ListItems.default | 369 | 376 | 0.98:1 |
| PortalMinimalPerf.default | 85 | 87 | 0.98:1 |
| SegmentMinimalPerf.default | 195 | 200 | 0.98:1 |
| VideoMinimalPerf.default | 442 | 452 | 0.98:1 |
| EmbedMinimalPerf.default | 1826 | 1889 | 0.97:1 |
| AvatarMinimalPerf.default | 108 | 113 | 0.96:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Sep 5, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 638 | 638 | 5000 | |
| Breadcrumb | mount | 1688 | 1709 | 1000 | |
| Checkbox | mount | 1706 | 1705 | 5000 | |
| CheckboxBase | mount | 1506 | 1495 | 5000 | |
| ChoiceGroup | mount | 2989 | 2923 | 5000 | |
| ComboBox | mount | 683 | 684 | 1000 | |
| CommandBar | mount | 6507 | 6525 | 1000 | |
| ContextualMenu | mount | 13916 | 13781 | 1000 | |
| DefaultButton | mount | 800 | 779 | 5000 | |
| DetailsRow | mount | 2202 | 2223 | 5000 | |
| DetailsRowFast | mount | 2241 | 2233 | 5000 | |
| DetailsRowNoStyles | mount | 2018 | 1990 | 5000 | |
| Dialog | mount | 2689 | 2717 | 1000 | |
| DocumentCardTitle | mount | 233 | 230 | 1000 | |
| Dropdown | mount | 1988 | 2011 | 5000 | |
| FocusTrapZone | mount | 1203 | 1133 | 5000 | |
| FocusZone | mount | 1075 | 1059 | 5000 | |
| GroupedList | mount | 42332 | 42528 | 2 | |
| GroupedList | virtual-rerender | 20236 | 20200 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51837 | 51484 | 2 | |
| GroupedListV2 | mount | 237 | 228 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 220 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 237 | 2 | |
| IconButton | mount | 1094 | 1135 | 5000 | |
| Label | mount | 335 | 342 | 5000 | |
| Layer | mount | 2722 | 2776 | 5000 | |
| Link | mount | 389 | 394 | 5000 | |
| MenuButton | mount | 994 | 987 | 5000 | |
| MessageBar | mount | 21412 | 21309 | 5000 | |
| Nav | mount | 2035 | 2016 | 1000 | |
| OverflowSet | mount | 793 | 792 | 5000 | |
| Panel | mount | 1887 | 1809 | 1000 | |
| Persona | mount | 724 | 743 | 1000 | |
| Pivot | mount | 887 | 913 | 1000 | |
| PrimaryButton | mount | 927 | 897 | 5000 | |
| Rating | mount | 4682 | 4662 | 5000 | |
| SearchBox | mount | 950 | 899 | 5000 | |
| Shimmer | mount | 1931 | 1879 | 5000 | |
| Slider | mount | 1317 | 1345 | 5000 | |
| SpinButton | mount | 2976 | 2940 | 5000 | |
| Spinner | mount | 398 | 390 | 5000 | |
| SplitButton | mount | 1850 | 1824 | 5000 | |
| Stack | mount | 429 | 421 | 5000 | |
| StackWithIntrinsicChildren | mount | 876 | 862 | 5000 | |
| StackWithTextChildren | mount | 2765 | 2758 | 5000 | |
| SwatchColorPicker | mount | 6283 | 6353 | 5000 | |
| TagPicker | mount | 1461 | 1487 | 5000 | |
| Text | mount | 390 | 394 | 5000 | |
| TextField | mount | 917 | 950 | 5000 | |
| ThemeProvider | mount | 869 | 859 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 588 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1289 | 1305 | 5000 | |
| Toggle | mount | 614 | 605 | 5000 | |
| buttonNative | mount | 198 | 196 | 5000 |
AtishayMsft
commented
Sep 9, 2024
change/@fluentui-react-charting-8ac4b02b-fec4-4dbe-a1d2-6e8163a73b4b.json
Show resolved
Hide resolved
krkshitij
reviewed
Sep 9, 2024
krkshitij
reviewed
Sep 9, 2024
packages/react-charting/src/components/AreaChart/__snapshots__/AreaChart.test.tsx.snap
Show resolved
Hide resolved
krkshitij
approved these changes
Sep 9, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
fabricteam
reviewed
Sep 9, 2024
change/@fluentui-react-charting-8ac4b02b-fec4-4dbe-a1d2-6e8163a73b4b.json
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Hotell
reviewed
Sep 10, 2024
khmakoto
approved these changes
Sep 10, 2024
…monorepo in order to mitigate dupes (#32809)
Hotell
approved these changes
Sep 10, 2024
ling1726
approved these changes
Sep 10, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 12, 2024
* master: (77 commits) fix(react-drawer): update scroll state when children changes (microsoft#32818) feat(react-storybook-addon): improve addon to more readable names (microsoft#32815) chore: cleanup react-carousel-preview (microsoft#32475) feat(storybook): add rtl/ltr toggle storybook addon (microsoft#32814) Carousel: Storybook updates and fixing exports/focus (microsoft#32457) release: applying package updates - react v8 release: applying package updates - web-components Update d3 dependency versions to 3.x.x and 4.x.x (microsoft#32463) RFC: Extended Design Tokens for Fluent UI React (microsoft#32058) update doc to reflect setTheme function change (microsoft#32490) fix (react-dialog): Use consistent rounding for clientHeight and innerHeight (microsoft#32480) fix(public-doscite-v9): global styles should not be applied to story elements (microsoft#32472) feat(workspace-plugin): implement verify-packaging executor (microsoft#32403) release: applying package updates - react-components Add strokeDasharray property when optimizeLargeData is true (microsoft#32494) fix(TreeItemLayout): Actions should not unmount between successive mouse events (microsoft#32477) release: applying package updates - react v8 bugfix(react-tree): recover from tabIndex=-1 when TreeItem is removed (microsoft#32442) Fix onResolveSuggestions not being called after component is remounted in react 18 strict mode (microsoft#28227) fix(codeowners): update most packages owned by cxe-red with cxe-prg (microsoft#32445) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
react-charting package is using very old versions of d3.
This has caused multiple issues:
New Behavior
Upgraded the d3 dependencies to their latest versions by pinning the major version in the charting package.
The latest versions published by d3 are 3.x.x and 4.x.x generally called as d3 v7.
More details about d3 v7 and breaking changes can be found here.
https://github.com/d3/d3/releases/tag/v7.0.0
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
With this, individual consumers can choose a wider range of d3 packages without needing duplicate version dependencies.
Validations
All automations - component tests, UTs and VRs are passing.
Performed a manual test pass on the docsite.
Consumed the upgraded package in a standalone test app to verify no transitive issues in dependent packages at the consumer end.
Related Issue(s)