bugfix(react-tree): recover from tabIndex=-1 when TreeItem is removed#32442
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Sep 9, 2024
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 35 | 35 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 656 | 629 | 5000 | |
| Button | mount | 300 | 312 | 5000 | |
| Field | mount | 1153 | 1173 | 5000 | |
| FluentProvider | mount | 688 | 683 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 93 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 35 | 35 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 75 | 10 | |
| MakeStyles | mount | 848 | 852 | 50000 | |
| Persona | mount | 1741 | 1747 | 5000 | |
| SpinButton | mount | 1400 | 1365 | 5000 | |
| SwatchPicker | mount | 1659 | 1684 | 5000 |
fabricteam
reviewed
Sep 3, 2024
ling1726
approved these changes
Sep 9, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 12, 2024
* master: (77 commits) fix(react-drawer): update scroll state when children changes (microsoft#32818) feat(react-storybook-addon): improve addon to more readable names (microsoft#32815) chore: cleanup react-carousel-preview (microsoft#32475) feat(storybook): add rtl/ltr toggle storybook addon (microsoft#32814) Carousel: Storybook updates and fixing exports/focus (microsoft#32457) release: applying package updates - react v8 release: applying package updates - web-components Update d3 dependency versions to 3.x.x and 4.x.x (microsoft#32463) RFC: Extended Design Tokens for Fluent UI React (microsoft#32058) update doc to reflect setTheme function change (microsoft#32490) fix (react-dialog): Use consistent rounding for clientHeight and innerHeight (microsoft#32480) fix(public-doscite-v9): global styles should not be applied to story elements (microsoft#32472) feat(workspace-plugin): implement verify-packaging executor (microsoft#32403) release: applying package updates - react-components Add strokeDasharray property when optimizeLargeData is true (microsoft#32494) fix(TreeItemLayout): Actions should not unmount between successive mouse events (microsoft#32477) release: applying package updates - react v8 bugfix(react-tree): recover from tabIndex=-1 when TreeItem is removed (microsoft#32442) Fix onResolveSuggestions not being called after component is remounted in react 18 strict mode (microsoft#28227) fix(codeowners): update most packages owned by cxe-red with cxe-prg (microsoft#32445) ...
|
@bsunderhus It seems this PR causes a regression in #31583 |
Contributor
Author
Well, seems like our test batteries should be improved for this case. Thanks for the catch @helgardferreira, would you mind opening an issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
forceUpdateRovingTabIndextoTreeContextValueTreeItemcleanup callsforceUpdateRovingTabIndexto ensureTreewill not facetabIndex=-1limbotabIndex=-1recover scenariosRelated Issue(s)