chore: replace lage with nx for task(targets) orchestration by Hotell · Pull Request #31949 · microsoft/fluentui

Hotell · 2024-07-09T08:27:55Z

Previous Behavior

lage is used for task orchestration
custom runPublished script is used to run targets within release pipelines

New Behavior

nx is used for any kind of task orchestration including releases
runPublished has been removed
lage package has been removed from dependencies and any related logic has been refactored to use nx under the hood
added missing tags to project.json in order to be able to filter projects when running releases

DX changes

yarn buildto

-yarn lage <target> --to <project-name>
+yarn nx run <project-name>:<target>

running task on affected projects by your changes

-yarn lage <target> --since=master
+yarn nx affected -t <target> --base=master

running tasks on whole repo

-yarn lage <target>
+yarn nx run-many -t <target>

💡 Note: run-many provides powerful filtering capabilities https://nx.dev/nx-api/nx/documents/run-many#examples

CI logs

Before:

mismatch of task execution

hard to troubleshoot failures

After:

task execution output is aggregated per task ( while behind the scenes things run in parallel )

easy to troubleshoot

Pipeline perf

`build-test-lint`

Before	After
46m 20s	46m 7s / 𝚫 0.5% FASTER

`e2e-deploy`

Before	After
32m 31s	26m 50s / 𝚫 17% FASTER

Related Issue(s)

Implements partially [Feature]: migrate to nx #30267
closes [Bug]: lage ignore globs don't work on info command if untracked files are present #26147,
closes [Bug]: lage caching on CI doesn't work after bump to 1.10 #31920,
closes chore: Updating lage to v1.10.0 #31710,
closes create-react-app logs warnings for source maps with react-components #21686

NX issues

core:runCommands: explicit --parallel argument doesn't override env variable NX_PARALLEL nrwl/nx#26903 / has workaround
CLI: expose `NX_BAIL` as env variable in order to configure `--nxBail` nrwl/nx#26899 / needed for simplified commands definition on CI
`run-many` extend `--project`,`--exclude` filtering capabilities including filtering non publishable projects nrwl/nx#26901 / needed for faster CI execution as less projects will be invoked
show project: renders duplicate target when using inferred task from package.json#scripts nrwl/nx#27143 / DX improvement

fabricteam · 2024-07-09T08:32:58Z

📊 Bundle size report

✅ No changes found

fabricteam · 2024-07-09T08:34:04Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-07-10T15:43:02Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	38	31	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	629	626	5000
Button	mount	329	314	5000
Field	mount	1130	1128	5000
FluentProvider	mount	715	710	5000
FluentProviderWithTheme	mount	86	86	10
FluentProviderWithTheme	virtual-rerender	38	31	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	78	73	10
MakeStyles	mount	870	861	50000
Persona	mount	1758	1717	5000
SpinButton	mount	1405	1426	5000
SwatchPicker	mount	1639	1648	5000

fabricteam · 2024-07-10T15:46:43Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AccordionMinimalPerf.default	89	92	0.97:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
PortalMinimalPerf.default	102	85	1.2:1
ButtonMinimalPerf.default	102	89	1.15:1
AttachmentMinimalPerf.default	96	87	1.1:1
ProviderMinimalPerf.default	227	208	1.09:1
ListCommonPerf.default	405	376	1.08:1
SkeletonMinimalPerf.default	208	193	1.08:1
InputMinimalPerf.default	569	534	1.07:1
IconMinimalPerf.default	414	391	1.06:1
TreeWith60ListItems.default	93	88	1.06:1
ChatMinimalPerf.default	455	432	1.05:1
EmbedMinimalPerf.default	1966	1873	1.05:1
FormMinimalPerf.default	227	216	1.05:1
ItemLayoutMinimalPerf.default	732	700	1.05:1
AnimationMinimalPerf.default	307	294	1.04:1
DropdownManyItemsPerf.default	419	404	1.04:1
LabelMinimalPerf.default	228	219	1.04:1
ListMinimalPerf.default	314	303	1.04:1
ListWith60ListItems.default	379	363	1.04:1
ToolbarMinimalPerf.default	555	533	1.04:1
CarouselMinimalPerf.default	271	263	1.03:1
ChatDuplicateMessagesPerf.default	160	155	1.03:1
DatepickerMinimalPerf.default	4022	3923	1.03:1
HeaderSlotsPerf.default	480	466	1.03:1
PopupMinimalPerf.default	356	346	1.03:1
ProviderMergeThemesPerf.default	655	639	1.03:1
RadioGroupMinimalPerf.default	268	259	1.03:1
TextAreaMinimalPerf.default	294	285	1.03:1
TooltipMinimalPerf.default	1304	1267	1.03:1
VideoMinimalPerf.default	444	430	1.03:1
AttachmentSlotsPerf.default	676	660	1.02:1
AvatarMinimalPerf.default	109	107	1.02:1
ButtonOverridesMissPerf.default	670	656	1.02:1
CardMinimalPerf.default	325	319	1.02:1
MenuMinimalPerf.default	522	512	1.02:1
ReactionMinimalPerf.default	216	211	1.02:1
SliderMinimalPerf.default	759	744	1.02:1
BoxMinimalPerf.default	195	193	1.01:1
ButtonSlotsPerf.default	320	318	1.01:1
ChatWithPopoverPerf.default	202	200	1.01:1
RefMinimalPerf.default	112	111	1.01:1
TableMinimalPerf.default	236	234	1.01:1
DividerMinimalPerf.default	207	208	1:1
FlexMinimalPerf.default	157	157	1:1
HeaderMinimalPerf.default	211	211	1:1
MenuButtonMinimalPerf.default	961	963	1:1
CheckboxMinimalPerf.default	1154	1162	0.99:1
DialogMinimalPerf.default	449	454	0.99:1
SplitButtonMinimalPerf.default	2273	2288	0.99:1
StatusMinimalPerf.default	400	404	0.99:1
TextMinimalPerf.default	199	201	0.99:1
CustomToolbarPrototype.default	1477	1496	0.99:1
TreeMinimalPerf.default	489	496	0.99:1
GridMinimalPerf.default	194	197	0.98:1
LoaderMinimalPerf.default	186	190	0.98:1
SegmentMinimalPerf.default	190	193	0.98:1
TableManyItemsPerf.default	1096	1114	0.98:1
DropdownMinimalPerf.default	1403	1439	0.97:1
LayoutMinimalPerf.default	196	203	0.97:1
ListNestedPerf.default	319	328	0.97:1
RosterPerf.default	1569	1619	0.97:1
ImageMinimalPerf.default	224	235	0.95:1
AlertMinimalPerf.default	151	168	0.9:1

fabricteam · 2024-07-10T15:54:26Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	634	608	5000
Breadcrumb	mount	1672	1692	1000
Checkbox	mount	1699	1681	5000
CheckboxBase	mount	1472	1467	5000
ChoiceGroup	mount	2953	2957	5000
ComboBox	mount	685	678	1000
CommandBar	mount	6593	6532	1000
ContextualMenu	mount	11977	12289	1000
DefaultButton	mount	792	781	5000
DetailsRow	mount	2279	2206	5000
DetailsRowFast	mount	2202	2256	5000
DetailsRowNoStyles	mount	2058	2033	5000
Dialog	mount	2872	2846	1000
DocumentCardTitle	mount	222	226	1000
Dropdown	mount	2001	2018	5000
FocusTrapZone	mount	1164	1142	5000
FocusZone	mount	1100	1084	5000
GroupedList	mount	41978	42411	2
GroupedList	virtual-rerender	18215	20395	2
GroupedList	virtual-rerender-with-unmount	51716	51576	2
GroupedListV2	mount	224	244	2
GroupedListV2	virtual-rerender	220	201	2
GroupedListV2	virtual-rerender-with-unmount	227	233	2
IconButton	mount	1121	1139	5000
Label	mount	345	344	5000
Layer	mount	2822	2793	5000
Link	mount	394	402	5000
MenuButton	mount	987	994	5000
MessageBar	mount	21426	21347	5000
Nav	mount	1987	2023	1000
OverflowSet	mount	791	801	5000
Panel	mount	1835	1817	1000
Persona	mount	751	752	1000
Pivot	mount	927	899	1000
PrimaryButton	mount	939	930	5000
Rating	mount	4667	4750	5000
SearchBox	mount	935	955	5000
Shimmer	mount	1907	1876	5000
Slider	mount	1328	1364	5000
SpinButton	mount	3033	2983	5000
Spinner	mount	380	400	5000
SplitButton	mount	1850	1845	5000
Stack	mount	420	427	5000
StackWithIntrinsicChildren	mount	866	878	5000
StackWithTextChildren	mount	2755	2772	5000
SwatchColorPicker	mount	6360	6432	5000
TagPicker	mount	1464	1491	5000
Text	mount	390	397	5000
TextField	mount	947	945	5000
ThemeProvider	mount	868	866	5000
ThemeProvider	virtual-rerender	573	588	5000
ThemeProvider	virtual-rerender-with-unmount	1324	1294	5000
Toggle	mount	602	625	5000
buttonNative	mount	186	194	5000

.devops/templates/tools.yml

fabricteam · 2024-07-17T08:19:47Z

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

fabricteam · 2024-07-17T08:23:40Z

🕵 fluentuiv8 No visual regressions between this PR and main

packages/fluentui/perf-test-northstar/project.json

scripts/executors/src/checkIfPackagesAffected.js

tools/workspace-plugin/package.json

tools/workspace-plugin/project.json

azure-pipelines.release-fluentui.yml

azure-pipelines.release-vnext-nightly.yml

azure-pipelines.vrt-baseline.yml

TristanWatanabe

It's finally here! 🥳

docs/react-wiki-archive/Build-Commands.md

…e pipelines

…make lint work and be aligned with current state of repo setup

…able to do that

…est work

…mand

…ry leaks

Hotell · 2024-07-31T13:11:18Z

got approval from majority of v-build team -> pipeline is green -> admin merging

…t#31949)

github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 9, 2024

Hotell changed the title ~~Nx/migrate to orchestrator~~ chore: replace lage with nx for task(targets) orchestration Jul 9, 2024

Hotell added NX: core Area: Build System CI labels Jul 9, 2024

This was referenced Jul 9, 2024

chore: normalize target names and target dependency graph to properly utilize cache hits #31926

Merged

[Feature]: migrate to nx #30267

Closed

Hotell force-pushed the nx/migrate-to-orchestrator branch from ba2206b to 0baf55f Compare July 10, 2024 15:57

Hotell mentioned this pull request Jul 11, 2024

core:runCommands: explicit --parallel argument doesn't override env variable NX_PARALLEL nrwl/nx#26903

Closed

4 tasks

Hotell force-pushed the nx/migrate-to-orchestrator branch from 7e077d9 to be3a99b Compare July 11, 2024 15:07

Hotell commented Jul 16, 2024

View reviewed changes

.devops/templates/tools.yml Outdated Show resolved Hide resolved

Hotell force-pushed the nx/migrate-to-orchestrator branch from 3524ddd to 0e8972e Compare July 17, 2024 08:08

Hotell force-pushed the nx/migrate-to-orchestrator branch 3 times, most recently from 4b11509 to d53176a Compare July 22, 2024 13:21

Hotell mentioned this pull request Jul 23, 2024

[Bug]: lage caching on CI doesn't work after bump to 1.10 #31920

Closed

2 tasks

Hotell force-pushed the nx/migrate-to-orchestrator branch from aee74a4 to f0aeb77 Compare July 24, 2024 15:12

Hotell commented Jul 24, 2024

View reviewed changes

Hotell force-pushed the nx/migrate-to-orchestrator branch from f0aeb77 to 1eb21ee Compare July 24, 2024 19:08

Hotell marked this pull request as ready for review July 25, 2024 12:40

Hotell requested review from a team as code owners July 25, 2024 12:40

TristanWatanabe approved these changes Jul 30, 2024

View reviewed changes

docs/react-wiki-archive/Build-Commands.md Outdated Show resolved Hide resolved

Hotell added 21 commits July 31, 2024 12:14

chore: replace lage with nx for task(targets) orchestration

fbe2049

feat(scripts-monorepo): replace lage with nx for affected packages API

dbe7276

ci: replace custom runPublished script with nx run-many within releas…

0a6b2d1

…e pipelines

chore: remove lage config

0e10609

fix: update target depends on definitions

48ddbe9

chore(workspace-plugin): migrate to package json scripts in order to …

845b50f

…make lint work and be aligned with current state of repo setup

chore: make bundle target run build on dependencies

8d82ea0

ci: set nx --verbose via env variable

2380820

ci: run cypress with in series as parallel execution is not supported

ab3c532

ci(e2e): override NX_PARALLEL locally as --parallel argument are not …

d23ce1b

…able to do that

ci(e2e): override NX_PARALLEL inline as env doesnt work

f931151

ci: remove nx --parallel overrides that don't work

6403ef6

chore(nx): add self build target dependency to bundle-size target

7120b26

chore(perf-test-*): uptade nx target dependency definitions to make t…

0dba8bd

…est work

fix(workspace-plugin): use projectName when invoking generate-api com…

7ba2166

…mand

change files

658d953

chore(scripts-tasks): tweak logs to use projectName instead npmName

058fe54

chore: dedupe deps

14dc273

test: add setupFiles jest config to turn of NX DAEMON to prevent memo…

545b2fc

…ry leaks

test: increase testTimeout for tests that run real createAsyncGraph

de923df

docs: undo old wiki changes

c92b457

Hotell force-pushed the nx/migrate-to-orchestrator branch from 82c4e21 to c92b457 Compare July 31, 2024 10:22

Hotell merged commit 3da4204 into microsoft:master Jul 31, 2024

Hotell deleted the nx/migrate-to-orchestrator branch July 31, 2024 13:11

Hotell mentioned this pull request Jul 31, 2024

ci: update pipelines to run properly after move to nx #32172

Merged

pixel-perfectionist pushed a commit to pixel-perfectionist/fluentui that referenced this pull request Jul 31, 2024

chore: replace lage with nx for task(targets) orchestration (microsof…

5bf4af0

…t#31949)

Hotell mentioned this pull request Aug 1, 2024

fix(nx): update target dependencies so all targets work as expected #32186

Merged

Hotell mentioned this pull request Aug 23, 2024

chore(tools/*,scripts/*): enable nx plugins with project crystal for non production projects #32337

Merged

Conversation

Hotell commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

DX changes

Pipeline perf

build-test-lint

e2e-deploy

Related Issue(s)

NX issues

Uh oh!

fabricteam commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

fabricteam commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TristanWatanabe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hotell commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hotell commented Jul 9, 2024 •

edited

Loading

`build-test-lint`

`e2e-deploy`

fabricteam commented Jul 9, 2024 •

edited

Loading

fabricteam commented Jul 9, 2024 •

edited

Loading

fabricteam commented Jul 10, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 10, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 10, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Jul 17, 2024 •

edited

Loading

fabricteam commented Jul 17, 2024 •

edited

Loading