Skip to content

chore: Updating lage to v1.10.0#31710

Merged
khmakoto merged 2 commits intomicrosoft:masterfrom
khmakoto:updatingLageTo1.10.0
Jun 18, 2024
Merged

chore: Updating lage to v1.10.0#31710
khmakoto merged 2 commits intomicrosoft:masterfrom
khmakoto:updatingLageTo1.10.0

Conversation

@khmakoto
Copy link
Member

@khmakoto khmakoto commented Jun 13, 2024 •
edited
Loading

Previous Behavior

yarn build was failing in at least PowerShell in Windows computers with the following error:

PS D:\repos\fluentui-g> yarn build
yarn run v1.23.34
$ lage build --verbose
info Lage task runner - let's make it
verb filterPackages running with dependents
info @fluentui/digest build ▶️ start 
verb @fluentui/digest build |  hash: fb570c10d91771fa150838d18b0e9f32c123ef89, cache hit? false
verb @fluentui/digest build |  Running C:\Program Files\nodejs\npm.CMD run build
info @fluentui/digest build ❌ fail
info 🏗 Summary
info
verb @fluentui/digest build failed, took 0.01s
verb @fluentui/react-northstar build:info pending, took 0.00s
verb @fluentui/a11y-testing build pending, took 0.00s
verb @fluentui/api-docs build pending, took 0.00s
verb @fluentui/codemods build pending, took 0.00s
verb @fluentui/example-data build pending, took 0.00s
verb @fluentui/keyboard-key build pending, took 0.00s
verb @fluentui/monaco-editor build pending, took 0.00s
verb @fluentui/public-docsite-setup build pending, took 0.00s
verb @fluentui/react-conformance build pending, took 0.00s
verb @fluentui/set-version build pending, took 0.00s
verb @fluentui/test-utilities build pending, took 0.00s
verb @fluentui/tokens build pending, took 0.00s
verb @fluentui/webpack-utilities build pending, took 0.00s
verb @fluentui/babel-preset-global-context build pending, took 0.00s
verb @fluentui/babel-preset-storybook-full-source build pending, took 0.00s
verb @fluentui/keyboard-keys build pending, took 0.00s
verb @fluentui/priority-overflow build pending, took 0.00s
verb @fluentui/react-portal-compat-context build pending, took 0.00s
info [Tasks Count] success: 0, skipped: 0, incomplete: 19
info ----------------------------------------------
ERR! [@fluentui/digest build] ERROR DETECTED
ERR! started
ERR! hash: fb570c10d91771fa150838d18b0e9f32c123ef89, cache hit? false
ERR! Running C:\Program Files\nodejs\npm.CMD run build
ERR! failed
info ----------------------------------------------
info Took a total of 0.64s to complete
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This seems this was caused by a faulty version of lage.

New Behavior

Updating lage to the latest minor version (1.10.0) seems to fix these issues.

@khmakoto khmakoto self-assigned this Jun 13, 2024
@khmakoto khmakoto requested a review from a team as a code owner June 13, 2024 22:11
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 13, 2024
fabricteam
fabricteam reviewed Jun 13, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 647 622 5000
Button mount 305 300 5000
Field mount 1122 1132 5000
FluentProvider mount 718 714 5000
FluentProviderWithTheme mount 79 85 10
FluentProviderWithTheme virtual-rerender 32 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 69 10
MakeStyles mount 862 854 50000
Persona mount 1726 1711 5000
SpinButton mount 1406 1395 5000
SwatchPicker mount 1677 1667 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 83 78 1.06:1 analysis
InputMinimalPerf.default 534 542 0.99:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 96 82 1.17:1
TreeWith60ListItems.default 90 80 1.13:1
RefMinimalPerf.default 119 108 1.1:1
ChatDuplicateMessagesPerf.default 155 144 1.08:1
TextMinimalPerf.default 202 189 1.07:1
AttachmentMinimalPerf.default 85 80 1.06:1
ImageMinimalPerf.default 218 206 1.06:1
SegmentMinimalPerf.default 206 194 1.06:1
TextAreaMinimalPerf.default 300 282 1.06:1
CardMinimalPerf.default 308 294 1.05:1
GridMinimalPerf.default 191 182 1.05:1
LabelMinimalPerf.default 219 209 1.05:1
LayoutMinimalPerf.default 197 188 1.05:1
DropdownManyItemsPerf.default 397 380 1.04:1
BoxMinimalPerf.default 195 190 1.03:1
ButtonMinimalPerf.default 89 86 1.03:1
CarouselMinimalPerf.default 267 258 1.03:1
ListMinimalPerf.default 307 299 1.03:1
ListNestedPerf.default 322 314 1.03:1
LoaderMinimalPerf.default 192 186 1.03:1
VideoMinimalPerf.default 450 436 1.03:1
AttachmentSlotsPerf.default 642 630 1.02:1
CheckboxMinimalPerf.default 1148 1123 1.02:1
DialogMinimalPerf.default 433 424 1.02:1
ItemLayoutMinimalPerf.default 716 700 1.02:1
PopupMinimalPerf.default 353 347 1.02:1
SplitButtonMinimalPerf.default 2278 2237 1.02:1
ButtonOverridesMissPerf.default 644 636 1.01:1
ListCommonPerf.default 387 384 1.01:1
MenuButtonMinimalPerf.default 945 932 1.01:1
ProviderMinimalPerf.default 206 203 1.01:1
RadioGroupMinimalPerf.default 260 258 1.01:1
TableManyItemsPerf.default 1098 1092 1.01:1
AnimationMinimalPerf.default 301 301 1:1
ButtonSlotsPerf.default 314 315 1:1
FlexMinimalPerf.default 159 159 1:1
ListWith60ListItems.default 366 367 1:1
MenuMinimalPerf.default 496 498 1:1
ProviderMergeThemesPerf.default 649 651 1:1
StatusMinimalPerf.default 396 396 1:1
CustomToolbarPrototype.default 1442 1443 1:1
TreeMinimalPerf.default 470 471 1:1
ChatWithPopoverPerf.default 192 193 0.99:1
DatepickerMinimalPerf.default 3531 3574 0.99:1
DividerMinimalPerf.default 198 201 0.99:1
EmbedMinimalPerf.default 1852 1871 0.99:1
HeaderSlotsPerf.default 460 463 0.99:1
SkeletonMinimalPerf.default 199 202 0.99:1
ToolbarMinimalPerf.default 526 531 0.99:1
TooltipMinimalPerf.default 1248 1255 0.99:1
AvatarMinimalPerf.default 114 116 0.98:1
SliderMinimalPerf.default 720 735 0.98:1
TableMinimalPerf.default 225 230 0.98:1
ChatMinimalPerf.default 435 448 0.97:1
FormMinimalPerf.default 217 223 0.97:1
HeaderMinimalPerf.default 203 209 0.97:1
RosterPerf.default 1536 1585 0.97:1
ReactionMinimalPerf.default 201 208 0.97:1
DropdownMinimalPerf.default 1380 1444 0.96:1
IconMinimalPerf.default 376 393 0.96:1
AlertMinimalPerf.default 148 166 0.89:1

fabricteam
fabricteam reviewed Jun 13, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 626 5000
Breadcrumb mount 1688 1707 1000
Checkbox mount 1753 1693 5000
CheckboxBase mount 1521 1501 5000
ChoiceGroup mount 2925 2965 5000
ComboBox mount 666 672 1000
CommandBar mount 6465 6420 1000
ContextualMenu mount 11851 13198 1000
DefaultButton mount 790 782 5000
DetailsRow mount 2202 2176 5000
DetailsRowFast mount 2179 2169 5000
DetailsRowNoStyles mount 2034 2032 5000
Dialog mount 2672 2684 1000
DocumentCardTitle mount 222 225 1000
Dropdown mount 2001 1984 5000
FocusTrapZone mount 1155 1149 5000
FocusZone mount 1099 1062 5000
GroupedList mount 42033 42107 2
GroupedList virtual-rerender 17831 20172 2
GroupedList virtual-rerender-with-unmount 50844 50915 2
GroupedListV2 mount 224 222 2
GroupedListV2 virtual-rerender 212 211 2
GroupedListV2 virtual-rerender-with-unmount 228 230 2
IconButton mount 1096 1123 5000
Label mount 337 337 5000
Layer mount 2717 2748 5000
Link mount 393 393 5000
MenuButton mount 1014 972 5000
MessageBar mount 21120 21059 5000
Nav mount 1996 1971 1000
OverflowSet mount 785 779 5000
Panel mount 2055 1769 1000
Persona mount 754 754 1000
Pivot mount 874 881 1000
PrimaryButton mount 914 903 5000
Rating mount 4557 4616 5000
SearchBox mount 922 911 5000
Shimmer mount 1858 1841 5000
Slider mount 1350 1339 5000
SpinButton mount 2941 2969 5000
Spinner mount 386 391 5000
SplitButton mount 1836 1864 5000
Stack mount 405 422 5000
StackWithIntrinsicChildren mount 842 847 5000
StackWithTextChildren mount 2647 2669 5000
SwatchColorPicker mount 6367 6373 5000
TagPicker mount 1407 1424 5000
Text mount 375 378 5000
TextField mount 947 932 5000
ThemeProvider mount 839 839 5000
ThemeProvider virtual-rerender 591 582 5000
ThemeProvider virtual-rerender-with-unmount 1292 1274 5000
Toggle mount 614 624 5000
buttonNative mount 187 194 5000

fabricteam
fabricteam reviewed Jun 13, 2024
View reviewed changes
@Hotell
Copy link
Contributor

Hotell commented Jun 14, 2024

unfortunately there is no changelog for this version so we can only guess what fixes your issue https://github.com/microsoft/lage/blob/master/packages/lage/v1-changelogs/CHANGELOG.md

Hotell
Hotell reviewed Jun 14, 2024
View reviewed changes
Hotell
Hotell approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address my comments and the feel free to merge - approving, ty

@Hotell
Copy link
Contributor

Hotell commented Jun 14, 2024

yarn build was failing in at least Windows computers,

can you be more specific ?

in what Shell ? DOS/PowerShell/WSL ?

@behowell
Copy link
Contributor

behowell commented Jun 14, 2024

yarn build was failing in at least Windows computers,

can you be more specific ?

in what Shell ? DOS/PowerShell/WSL ?

It fails in PowerShell.

PS D:\repos\fluentui-g> yarn build
yarn run v1.23.34
$ lage build --verbose
info Lage task runner - let's make it
verb filterPackages running with dependents
info @fluentui/digest build ▶️ start 
verb @fluentui/digest build |  hash: fb570c10d91771fa150838d18b0e9f32c123ef89, cache hit? false
verb @fluentui/digest build |  Running C:\Program Files\nodejs\npm.CMD run build
info @fluentui/digest build ❌ fail
info 🏗 Summary
info
verb @fluentui/digest build failed, took 0.01s
verb @fluentui/react-northstar build:info pending, took 0.00s
verb @fluentui/a11y-testing build pending, took 0.00s
verb @fluentui/api-docs build pending, took 0.00s
verb @fluentui/codemods build pending, took 0.00s
verb @fluentui/example-data build pending, took 0.00s
verb @fluentui/keyboard-key build pending, took 0.00s
verb @fluentui/monaco-editor build pending, took 0.00s
verb @fluentui/public-docsite-setup build pending, took 0.00s
verb @fluentui/react-conformance build pending, took 0.00s
verb @fluentui/set-version build pending, took 0.00s
verb @fluentui/test-utilities build pending, took 0.00s
verb @fluentui/tokens build pending, took 0.00s
verb @fluentui/webpack-utilities build pending, took 0.00s
verb @fluentui/babel-preset-global-context build pending, took 0.00s
verb @fluentui/babel-preset-storybook-full-source build pending, took 0.00s
verb @fluentui/keyboard-keys build pending, took 0.00s
verb @fluentui/priority-overflow build pending, took 0.00s
verb @fluentui/react-portal-compat-context build pending, took 0.00s
info [Tasks Count] success: 0, skipped: 0, incomplete: 19
info ----------------------------------------------
ERR! [@fluentui/digest build] ERROR DETECTED
ERR! started
ERR! hash: fb570c10d91771fa150838d18b0e9f32c123ef89, cache hit? false
ERR! Running C:\Program Files\nodejs\npm.CMD run build
ERR! failed
info ----------------------------------------------
info Took a total of 0.64s to complete
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@khmakoto khmakoto merged commit 9955994 into microsoft:master Jun 18, 2024
@Hotell Hotell mentioned this pull request Jun 24, 2024
Merged
This was referenced Jul 4, 2024
Closed
Closed
@Hotell Hotell mentioned this pull request Jul 25, 2024
Merged
4 tasks
@khmakoto khmakoto deleted the updatingLageTo1.10.0 branch January 7, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

@fabricteam fabricteam fabricteam left review comments

@spmonahan spmonahan spmonahan approved these changes

Assignees

@khmakoto khmakoto

Labels

Area: Build System

Projects

None yet

Milestone

April Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

5 participants

@khmakoto @fabricteam @Hotell @behowell @spmonahan