fix(react-tabs): ignore ref for tab reserved space content slot#31775
Merged
dmytrokirpa merged 23 commits intomicrosoft:masterfrom Aug 6, 2024
Merged
fix(react-tabs): ignore ref for tab reserved space content slot#31775dmytrokirpa merged 23 commits intomicrosoft:masterfrom
dmytrokirpa merged 23 commits intomicrosoft:masterfrom
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 84 | 85 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 613 | 5000 | |
| Button | mount | 293 | 306 | 5000 | |
| Field | mount | 1123 | 1144 | 5000 | |
| FluentProvider | mount | 717 | 723 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 85 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 67 | 10 | |
| MakeStyles | mount | 873 | 883 | 50000 | |
| Persona | mount | 1772 | 1753 | 5000 | |
| SpinButton | mount | 1369 | 1390 | 5000 | |
| SwatchPicker | mount | 1659 | 1620 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
marcosmoura
approved these changes
Jun 24, 2024
Member
|
@dmytrokirpa FYI |
layershifter
reviewed
Jul 4, 2024
packages/react-components/react-tabs/library/src/components/Tab/useTab.ts
Show resolved
Hide resolved
layershifter
approved these changes
Jul 4, 2024
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
GeoffCoxMSFT
approved these changes
Aug 6, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 7, 2024
* master: (48 commits) chore: migrate to storybook v7 (microsoft#32018) release: applying package updates - react-components ci: make public-docsite-v9 deploy pipeline work and make it faster (microsoft#32248) fix(Toolbar): hardcode size of `ToolbarButton` (microsoft#32185) chore: deprecate @fluentui/react-motion-preview (microsoft#32190) release: applying package updates - web-components docs: add wrapping menu item example to ContextualMenu docs (microsoft#31289) docs: update title of v8 keyboard-accessible drag & drop example, add docs (microsoft#32216) release: applying package updates - react-components fix: Card does not override specified focusMode based on event listeners (microsoft#32200) Fix undefined reference in older browsers in useMessageBarReflow (microsoft#32238) feat: Add transparent appearance to ToolbarButton (microsoft#32205) fix(react-tabs): ignore ref for tab reserved space content slot (microsoft#31775) fix(Dialog): do not require ref forwarding (microsoft#32095) feat: add verify-packaging to react v8 release pipeline (microsoft#32212) chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds (microsoft#32208) chore(react-tree): improve ImmutableSet and ImmutableMap internal implementation (microsoft#32167) release: applying package updates - web-components feat(web-components): add tablist (microsoft#32098) release: applying package updates - react-components ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Tab content slot calls ref with both content and reserved space content elements
New Behavior
Tab content slot calls ref only with the content element and ignores ref for the reserved space content elements
Related Issue(s)