fix: show default title action in dialog body for modal dialogs#31648
Merged
chrisdholt merged 1 commit intomicrosoft:masterfrom Jun 10, 2024
Conversation
packages/web-components/src/dialog-body/dialog-body.template.ts
Outdated
Show resolved
Hide resolved
radium-v
requested changes
Jun 10, 2024
Contributor
radium-v
left a comment
There was a problem hiding this comment.
I think this breaks the test: Dialog Body > should add default close button for non-modal dialogs
Collaborator
📊 Bundle size report✅ No changes found |
Member
Author
It should've been |
6c19a7b to
fa16fe8
Compare
radium-v
approved these changes
Jun 10, 2024
fabricteam
reviewed
Jun 10, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Size - RTL.normal.chromium.png | 2 | Changed |
| Accordion.Size - Dark Mode.normal.chromium.png | 2 | Changed |
| Accordion.Size.normal.chromium.png | 2 | Changed |
Avatar 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Active Appearance - Dark Mode.normal.chromium.png | 2 | Changed |
| Avatar.Active.normal.chromium.png | 5 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 10 | Changed |
| Avatar.Color - RTL.normal.chromium.png | 1 | Changed |
| Avatar.Color.normal.chromium.png | 1 | Changed |
Badge 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Default.normal.chromium.png | 1 | Changed |
| Badge.Shape.normal.chromium.png | 1 | Changed |
| Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
| Badge.Color.normal.chromium.png | 1 | Changed |
| Badge.Appearance.normal.chromium.png | 1 | Changed |
| Badge.Size.normal.chromium.png | 6 | Changed |
Button 57 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large Icon Only.default.chromium.png | 5 | Changed |
| Button.Large Icon Only.hover.chromium.png | 4 | Changed |
| Button.Large Icon Only.pressed.chromium.png | 3 | Changed |
| Button.Large Icon Only - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - RTL.hover.chromium.png | 4 | Changed |
| Button.Large With Icon.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon - RTL.default.chromium.png | 5 | Changed |
| Button.Large Icon Only - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large Icon Only - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon.hover.chromium.png | 4 | Changed |
| Button.Large With Icon - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Outline Disabled - Dark Mode.hover.chromium.png | 159 | Changed |
| Button.Large With Icon.default.chromium.png | 5 | Changed |
| Button.Outline Disabled - Dark Mode.default.chromium.png | 159 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.hover.chromium.png | 159 | Changed |
| Button.Primary Disabled - Dark Mode.hover.chromium.png | 44 | Changed |
| Button.Primary Disabled - Dark Mode.default.chromium.png | 44 | Changed |
| Button.Primary Disabled Focusable.hover.chromium.png | 15 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.pressed.chromium.png | 44 | Changed |
| Button.Outline Disabled - Dark Mode.pressed.chromium.png | 159 | Changed |
| Button.Primary Disabled Focusable.pressed.chromium.png | 15 | Changed |
| Button.Primary Disabled - Dark Mode.pressed.chromium.png | 44 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.default.chromium.png | 159 | Changed |
| Button.Large With Icon - RTL.pressed.chromium.png | 3 | Changed |
| Button.Primary Disabled.pressed.chromium.png | 15 | Changed |
| Button.Primary Disabled.default.chromium.png | 15 | Changed |
| Button.Primary Disabled Focusable.default.chromium.png | 15 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.default.chromium.png | 44 | Changed |
| Button.Primary Disabled Focusable - Dark Mode.hover.chromium.png | 44 | Changed |
| Button.Primary Disabled.hover.chromium.png | 15 | Changed |
| Button.Outline Disabled Focusable - Dark Mode.pressed.chromium.png | 159 | Changed |
| Button.Subtle Disabled Focusable.hover.chromium.png | 25 | Changed |
| Button.Subtle Disabled Focusable.default.chromium.png | 25 | Changed |
| Button.Subtle Disabled Focusable.pressed.chromium.png | 25 | Changed |
| Button.Transparent Disabled - Dark Mode.default.chromium.png | 199 | Changed |
| Button.Transparent Disabled - Dark Mode.pressed.chromium.png | 199 | Changed |
| Button.Transparent Disabled - Dark Mode.hover.chromium.png | 199 | Changed |
| Button.Subtle Disabled - Dark Mode.default.chromium.png | 187 | Changed |
| Button.Subtle Disabled.default.chromium.png | 25 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.default.chromium.png | 199 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.hover.chromium.png | 187 | Changed |
| Button.Subtle Disabled - Dark Mode.pressed.chromium.png | 187 | Changed |
| Button.Subtle Disabled.hover.chromium.png | 25 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.pressed.chromium.png | 187 | Changed |
| Button.Subtle Disabled.pressed.chromium.png | 25 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.hover.chromium.png | 199 | Changed |
| Button.Subtle Disabled Focusable - Dark Mode.default.chromium.png | 187 | Changed |
| Button.Transparent Disabled.default.chromium.png | 27 | Changed |
| Button.Transparent Disabled Focusable.default.chromium.png | 27 | Changed |
| Button.Transparent Disabled Focusable.pressed.chromium.png | 27 | Changed |
| Button.Transparent Disabled Focusable.hover.chromium.png | 27 | Changed |
| Button.Subtle Disabled - Dark Mode.hover.chromium.png | 187 | Changed |
| Button.Transparent Disabled Focusable - Dark Mode.pressed.chromium.png | 199 | Changed |
| Button.Transparent Disabled.hover.chromium.png | 27 | Changed |
| Button.Transparent Disabled.pressed.chromium.png | 27 | Changed |
Checkbox 26 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox.Circular - RTL.normal.chromium.png | 4733 | Changed |
| Checkbox.Circular Indeterminate - Dark Mode.normal.chromium.png | 936 | Changed |
| Checkbox.Circular Indeterminate - Dark Mode.indeterminate.chromium.png | 1102 | Changed |
| Checkbox.Circular Indeterminate.normal.chromium.png | 4786 | Changed |
| Checkbox.Default - Dark Mode.normal.chromium.png | 814 | Changed |
| Checkbox.Default - RTL.normal.chromium.png | 4751 | Changed |
| Checkbox.Checked - Dark Mode.normal.chromium.png | 982 | Changed |
| Checkbox.Circular Checked.normal.chromium.png | 4883 | Changed |
| Checkbox.Circular - Dark Mode.normal.chromium.png | 792 | Changed |
| Checkbox.Circular Checked - Dark Mode.normal.chromium.png | 1080 | Changed |
| Checkbox.Disabled - Dark Mode.normal.chromium.png | 739 | Changed |
| Checkbox.Default.normal.chromium.png | 4751 | Changed |
| Checkbox.Indeterminate.normal.chromium.png | 4776 | Changed |
| Checkbox.Disabled Checked - Dark Mode.normal.chromium.png | 777 | Changed |
| Checkbox.Circular Indeterminate.indeterminate.chromium.png | 4869 | Changed |
| Checkbox.Disabled Checked.normal.chromium.png | 4721 | Changed |
| Checkbox.Checked.normal.chromium.png | 4855 | Changed |
| Checkbox.Indeterminate - Dark Mode.normal.chromium.png | 877 | Changed |
| Checkbox.Disabled.normal.chromium.png | 4705 | Changed |
| Checkbox.Circular Disabled - Dark Mode.normal.chromium.png | 760 | Changed |
| Checkbox.Circular Disabled.normal.chromium.png | 4711 | Changed |
| Checkbox.Indeterminate - Dark Mode.indeterminate.chromium.png | 993 | Changed |
| Checkbox.Circular Disabled Checked - Dark Mode.normal.chromium.png | 799 | Changed |
| Checkbox.Circular Disabled Checked.normal.chromium.png | 4728 | Changed |
| Checkbox.Circular.normal.chromium.png | 4734 | Changed |
| Checkbox.Indeterminate.indeterminate.chromium.png | 4847 | Changed |
Divider 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.With Svg - RTL.normal.chromium.png | 3 | Changed |
| Divider.With Svg.normal.chromium.png | 3 | Changed |
| Divider.Vertical With Svg.normal.chromium.png | 4 | Changed |
Label 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Label.Required - RTL.normal.chromium.png | 11 | Changed |
| Label.Size Small.normal.chromium.png | 661 | Changed |
MenuList 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 5 | Changed |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.2nd selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.With Icons.hover menuitem.chromium.png | 3 | Changed |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.1st selected.chromium.png | 4 | Changed |
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Size Small.rightArrow.chromium.png | 1 | Changed |
| Slider.Size Small.normal.chromium.png | 1 | Changed |
Switch 34 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked - Dark Mode.hover.chromium.png | 1169 | Changed |
| Switch.Checked - RTL.hover.chromium.png | 5150 | Changed |
| Switch.Checked - RTL.normal.chromium.png | 5132 | Changed |
| Switch.Default - Dark Mode.hover.chromium.png | 1071 | Changed |
| Switch.Checked.hover.chromium.png | 5150 | Changed |
| Switch.Default.normal.chromium.png | 5009 | Changed |
| Switch.Disabled - Dark Mode.normal.chromium.png | 909 | Changed |
| Switch.Default - RTL.normal.chromium.png | 5009 | Changed |
| Switch.Disabled - RTL.hover.chromium.png | 4914 | Changed |
| Switch.Default - RTL.hover.chromium.png | 5044 | Changed |
| Switch.Disabled Checked.normal.chromium.png | 5047 | Changed |
| Switch.Disabled Checked - Dark Mode.hover.chromium.png | 1074 | Changed |
| Switch.Disabled Checked - Dark Mode.normal.chromium.png | 1074 | Changed |
| Switch.Disabled.normal.chromium.png | 4914 | Changed |
| Switch.Disabled.hover.chromium.png | 4914 | Changed |
| Switch.Default - Dark Mode.normal.chromium.png | 1019 | Changed |
| Switch.Disabled - RTL.normal.chromium.png | 4914 | Changed |
| Switch.Disabled Checked.hover.chromium.png | 5047 | Changed |
| Switch.Checked.normal.chromium.png | 5132 | Changed |
| Switch.Checked - Dark Mode.normal.chromium.png | 1130 | Changed |
| Switch.Default.hover.chromium.png | 5044 | Changed |
| Switch.Disabled - Dark Mode.hover.chromium.png | 909 | Changed |
| Switch.Label Above - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label Above - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label Above.hover.chromium.png | 0 | Removed |
| Switch.Label Above.normal.chromium.png | 0 | Removed |
| Switch.Label After - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label After - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label After.hover.chromium.png | 0 | Removed |
| Switch.Label After.normal.chromium.png | 0 | Removed |
| Switch.Label Before - RTL.hover.chromium.png | 0 | Removed |
| Switch.Label Before - RTL.normal.chromium.png | 0 | Removed |
| Switch.Label Before.hover.chromium.png | 0 | Removed |
| Switch.Label Before.normal.chromium.png | 0 | Removed |
Text 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Strikethrough.normal.chromium.png | 236 | Changed |
| Text.Block.normal.chromium.png | 995 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Size Large.normal.chromium.png | 3 | Changed |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Title action would only show by default for non-modal dialogs.
New Behavior
Title action will show by default for both non-modal and modal dialogs. It is hidden by default for alert dialogs.
Related Issue(s)