docs(react-skeleton): extend Skeleton story with SkeletonItem examples#31608
Merged
mainframev merged 1 commit intomicrosoft:masterfrom Jun 11, 2024
Merged
Conversation
a50dc14 to
2b989ac
Compare
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 39 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 617 | 618 | 5000 | |
| Button | mount | 302 | 320 | 5000 | |
| Field | mount | 1145 | 1141 | 5000 | |
| FluentProvider | mount | 711 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 76 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 39 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 76 | 10 | |
| MakeStyles | mount | 868 | 858 | 50000 | |
| Persona | mount | 1715 | 1747 | 5000 | |
| SpinButton | mount | 1354 | 1404 | 5000 | |
| SwatchPicker | mount | 1500 | 1515 | 5000 |
fabricteam
reviewed
Jun 6, 2024
packages/react-components/react-skeleton/stories/Skeleton/SkeletonItemShape.stories.tsx
Show resolved
Hide resolved
c28c05c to
37ff9e1
Compare
marcosmoura
approved these changes
Jun 10, 2024
Contributor
|
I see that in many examples SkeletonItem gets |
Contributor
Author
Yeah, makes sense to me. Current API is that they share two same props, SkeletonItem has |
Contributor
Make a feature issue please! |
smhigley
approved these changes
Jun 10, 2024
Contributor
smhigley
left a comment
There was a problem hiding this comment.
Small naming nit/suggestion, otherwise looks good!
smhigley
reviewed
Jun 10, 2024
packages/react-components/react-skeleton/stories/Skeleton/SkeletonItemShape.stories.tsx
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Jun 10, 2024
43b0f3f to
43e9138
Compare
docs(react-skeleton): extend Skeleton story with SkeletonItem examples docs(react-skeleton): extend Skeleton story with SkeletonItem examples docs(react-skeleton): extend Skeleton story with SkeletonItem examples
43e9138 to
5b7a176
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
1 task
Contributor
done #31664 :) |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #31222. Extended
Skeletonstory to haveSkeletonItemexamples forsizeandshapeprops. Tbh, not sure if it deserves completely separated tab, asSkeletonItemisn't standalone and supposed to be used as a child component ofSkeleton.Related Issue(s)
#31222