fix: make type-check task run with --noEmit and return only void Promise on success and update recipes app tsconfig#31456
Merged
Hotell merged 2 commits intomicrosoft:masterfrom May 22, 2024
Conversation
…ude node_module types
…id Promise on success
sopranopillow
approved these changes
May 22, 2024
fabricteam
reviewed
May 22, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 78 | 87 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 628 | 651 | 5000 | |
| Button | mount | 309 | 302 | 5000 | |
| Field | mount | 1123 | 1127 | 5000 | |
| FluentProvider | mount | 702 | 705 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 87 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 36 | 39 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 80 | 10 | |
| MakeStyles | mount | 858 | 873 | 50000 | |
| Persona | mount | 1749 | 1701 | 5000 | |
| SpinButton | mount | 1367 | 1384 | 5000 | |
| SwatchPicker | mount | 1564 | 1540 | 5000 |
fabricteam
reviewed
May 22, 2024
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AttachmentMinimalPerf.default | 80 | 80 | 1:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 98 | 91 | 1.08:1 |
| ChatDuplicateMessagesPerf.default | 159 | 149 | 1.07:1 |
| StatusMinimalPerf.default | 405 | 380 | 1.07:1 |
| TableMinimalPerf.default | 237 | 221 | 1.07:1 |
| SliderMinimalPerf.default | 778 | 733 | 1.06:1 |
| TreeMinimalPerf.default | 489 | 463 | 1.06:1 |
| ChatWithPopoverPerf.default | 201 | 192 | 1.05:1 |
| ReactionMinimalPerf.default | 221 | 211 | 1.05:1 |
| ToolbarMinimalPerf.default | 550 | 526 | 1.05:1 |
| ButtonSlotsPerf.default | 340 | 326 | 1.04:1 |
| CardMinimalPerf.default | 324 | 312 | 1.04:1 |
| CheckboxMinimalPerf.default | 1153 | 1114 | 1.04:1 |
| FormMinimalPerf.default | 234 | 224 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 718 | 689 | 1.04:1 |
| ListWith60ListItems.default | 367 | 354 | 1.04:1 |
| RefMinimalPerf.default | 113 | 109 | 1.04:1 |
| ChatMinimalPerf.default | 446 | 435 | 1.03:1 |
| DropdownManyItemsPerf.default | 396 | 385 | 1.03:1 |
| FlexMinimalPerf.default | 160 | 155 | 1.03:1 |
| ListNestedPerf.default | 328 | 318 | 1.03:1 |
| ProviderMergeThemesPerf.default | 653 | 633 | 1.03:1 |
| ButtonMinimalPerf.default | 87 | 85 | 1.02:1 |
| CarouselMinimalPerf.default | 258 | 254 | 1.02:1 |
| DividerMinimalPerf.default | 207 | 202 | 1.02:1 |
| DropdownMinimalPerf.default | 1441 | 1407 | 1.02:1 |
| PortalMinimalPerf.default | 82 | 80 | 1.02:1 |
| IconMinimalPerf.default | 401 | 393 | 1.02:1 |
| AccordionMinimalPerf.default | 87 | 86 | 1.01:1 |
| BoxMinimalPerf.default | 196 | 194 | 1.01:1 |
| ButtonOverridesMissPerf.default | 661 | 652 | 1.01:1 |
| DatepickerMinimalPerf.default | 3630 | 3583 | 1.01:1 |
| EmbedMinimalPerf.default | 1859 | 1847 | 1.01:1 |
| ListMinimalPerf.default | 305 | 301 | 1.01:1 |
| PopupMinimalPerf.default | 346 | 343 | 1.01:1 |
| TextMinimalPerf.default | 190 | 189 | 1.01:1 |
| CustomToolbarPrototype.default | 1485 | 1465 | 1.01:1 |
| TooltipMinimalPerf.default | 1280 | 1273 | 1.01:1 |
| AnimationMinimalPerf.default | 310 | 309 | 1:1 |
| GridMinimalPerf.default | 179 | 179 | 1:1 |
| LabelMinimalPerf.default | 219 | 220 | 1:1 |
| RosterPerf.default | 1566 | 1561 | 1:1 |
| SplitButtonMinimalPerf.default | 2279 | 2273 | 1:1 |
| HeaderMinimalPerf.default | 207 | 210 | 0.99:1 |
| ListCommonPerf.default | 382 | 385 | 0.99:1 |
| RadioGroupMinimalPerf.default | 259 | 262 | 0.99:1 |
| AttachmentSlotsPerf.default | 639 | 653 | 0.98:1 |
| DialogMinimalPerf.default | 434 | 444 | 0.98:1 |
| InputMinimalPerf.default | 531 | 541 | 0.98:1 |
| MenuButtonMinimalPerf.default | 941 | 965 | 0.98:1 |
| SkeletonMinimalPerf.default | 187 | 191 | 0.98:1 |
| ImageMinimalPerf.default | 212 | 219 | 0.97:1 |
| LayoutMinimalPerf.default | 188 | 194 | 0.97:1 |
| MenuMinimalPerf.default | 496 | 510 | 0.97:1 |
| ProviderMinimalPerf.default | 205 | 211 | 0.97:1 |
| TextAreaMinimalPerf.default | 279 | 287 | 0.97:1 |
| AlertMinimalPerf.default | 160 | 166 | 0.96:1 |
| LoaderMinimalPerf.default | 191 | 199 | 0.96:1 |
| SegmentMinimalPerf.default | 186 | 194 | 0.96:1 |
| VideoMinimalPerf.default | 427 | 447 | 0.96:1 |
| TableManyItemsPerf.default | 1089 | 1145 | 0.95:1 |
| AvatarMinimalPerf.default | 105 | 113 | 0.93:1 |
| HeaderSlotsPerf.default | 462 | 544 | 0.85:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 639 | 624 | 5000 | |
| Breadcrumb | mount | 1703 | 1700 | 1000 | |
| Checkbox | mount | 1707 | 1707 | 5000 | |
| CheckboxBase | mount | 1484 | 1461 | 5000 | |
| ChoiceGroup | mount | 2994 | 2991 | 5000 | |
| ComboBox | mount | 680 | 676 | 1000 | |
| CommandBar | mount | 6545 | 6488 | 1000 | |
| ContextualMenu | mount | 12750 | 12638 | 1000 | |
| DefaultButton | mount | 792 | 793 | 5000 | |
| DetailsRow | mount | 2270 | 2267 | 5000 | |
| DetailsRowFast | mount | 2224 | 2271 | 5000 | |
| DetailsRowNoStyles | mount | 2032 | 2033 | 5000 | |
| Dialog | mount | 2791 | 2693 | 1000 | |
| DocumentCardTitle | mount | 223 | 226 | 1000 | |
| Dropdown | mount | 1994 | 2047 | 5000 | |
| FocusTrapZone | mount | 1139 | 1165 | 5000 | |
| FocusZone | mount | 1148 | 1075 | 5000 | |
| GroupedList | mount | 42259 | 42361 | 2 | |
| GroupedList | virtual-rerender | 20296 | 20271 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51119 | 50906 | 2 | |
| GroupedListV2 | mount | 232 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 215 | 211 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 219 | 228 | 2 | |
| IconButton | mount | 1145 | 1140 | 5000 | |
| Label | mount | 339 | 332 | 5000 | |
| Layer | mount | 2735 | 2798 | 5000 | |
| Link | mount | 401 | 405 | 5000 | |
| MenuButton | mount | 986 | 1001 | 5000 | |
| MessageBar | mount | 21516 | 21447 | 5000 | |
| Nav | mount | 2050 | 2067 | 1000 | |
| OverflowSet | mount | 800 | 779 | 5000 | |
| Panel | mount | 1848 | 1798 | 1000 | |
| Persona | mount | 784 | 773 | 1000 | |
| Pivot | mount | 902 | 920 | 1000 | |
| PrimaryButton | mount | 935 | 926 | 5000 | |
| Rating | mount | 4782 | 4652 | 5000 | |
| SearchBox | mount | 906 | 917 | 5000 | |
| Shimmer | mount | 1892 | 1914 | 5000 | |
| Slider | mount | 1365 | 1388 | 5000 | |
| SpinButton | mount | 3005 | 2984 | 5000 | |
| Spinner | mount | 394 | 402 | 5000 | |
| SplitButton | mount | 1893 | 1872 | 5000 | |
| Stack | mount | 414 | 404 | 5000 | |
| StackWithIntrinsicChildren | mount | 881 | 855 | 5000 | |
| StackWithTextChildren | mount | 2637 | 2669 | 5000 | |
| SwatchColorPicker | mount | 6420 | 6323 | 5000 | |
| TagPicker | mount | 1484 | 1457 | 5000 | |
| Text | mount | 381 | 383 | 5000 | |
| TextField | mount | 956 | 961 | 5000 | |
| ThemeProvider | mount | 840 | 854 | 5000 | |
| ThemeProvider | virtual-rerender | 580 | 588 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1310 | 1294 | 5000 | |
| Toggle | mount | 628 | 634 | 5000 | |
| buttonNative | mount | 190 | 189 | 5000 |
fabricteam
reviewed
May 22, 2024
Collaborator
Author
|
admin merged to unblock master. |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…ise on success and update recipes app tsconfig (microsoft#31456)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
master is failing on type-check error
New Behavior
type-checkuses noEmit and returns onlyPromise<void>on success in order to follow just-scripts patternsexcludefrom tsconfig within recipes app which is probably main issue with failuresRelated Issue(s)