fix(vr-tests-web-component): explicitly add @types/web and specify those within types globals in order to pass tsc#31451
Merged
Hotell merged 1 commit intomicrosoft:masterfrom May 22, 2024
Conversation
…ose within types globals in order to pass tsc
Collaborator
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 22, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tudorpopams
approved these changes
May 22, 2024
Contributor
Author
|
admin merged with v-build approval in order to unblock master |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…ose within types globals in order to pass tsc (microsoft#31451)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Master pipeline fails because type issues with
vr-tests-web-componentsNew Behavior
Because web-components use https://www.npmjs.com/package/@types/web package in order to override DOM lib types every app and library within monorepo that uses wc as dependency needs to specify
webwithin tsconfig types globalRelated Issue(s)