feat(workspace-plugin): make all react library generators work with both split project and old project setup#31142
Merged
Hotell merged 14 commits intomicrosoft:masterfrom May 22, 2024
Conversation
17 tasks
Collaborator
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
0817545 to
e3ba234
Compare
e3ba234 to
8c83190
Compare
Hotell
commented
May 3, 2024
tools/workspace-plugin/src/generators/cypress-component-configuration/lib/add-files.ts
Show resolved
Hide resolved
Hotell
commented
May 3, 2024
tools/workspace-plugin/src/generators/prepare-initial-release/index.spec.ts
Show resolved
Hide resolved
marcosmoura
approved these changes
May 9, 2024
5492b9b to
4347358
Compare
…ith new split /library /stories react projects
… with new split /library /stories react projects
…r work with new split /library /stories react projects
…ss-component-configuration
…split /library /stories react projects
…lit /library /stories react projects
…pat and preview packages
… in other related generators
…ed on compat kind of project
…y to avoid unhandled promises runtime issues
…ate proper dependency tree
4347358 to
9bc7084
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…oth split project and old project setup (microsoft#31142)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requirements:
packageNameconfigurale withincompare-reportscommand monosize#62Previous Behavior
New Behavior
makes following generators work in both v9 package configuration ( old/current and new split library
root-folder/library root-folder/stories:NOTE: once we migrate all packages those conditional (old) behaviours implemented will be removed from all changed generators in this PR ( except
split-library-in-twogenerator )Additional features:
react-librarycypress-component-configurationsplit-library-in-twotest-ssrtask will be moved to/storiesproject instead staying within/libraryas it's the right thing to do from domain and dependency graph POV.Related Issue(s)