-
Notifications
You must be signed in to change notification settings - Fork 11
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
ATM packageName for local report is being inferred from package folder basename https://github.com/microsoft/monosize/blob/main/packages/monosize/src/utils/collectLocalReport.mts#L23
While this might work for simple use-cases once it should be configurable by the user.
Example
when directory structure is (see within PR)
|-react-alert/
|- library/
|- /bundle-size
|- stories/
|- e2e/
Current:
Expected:
Proposed Implementations:
- change the behaviours to obtain the name from
package.json#nameand fallback to folder basename if not present
This would be a BREAKING CHANGE
- enable set this behaviour via configuration
- via cli
monosize compare-reports --packageName='folder'|'package.json'- via config
export type MonoSizeConfig = {
repository: string;
storage: StorageAdapter;
bundler: BundlerAdapter;
+ commands: {
+ 'compare-report': {
+ packageName: 'directory' | 'packageJSON' | ( packageRoot:string ) => string
+ }
}
};Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request