bugfix(react-combobox): remove freeform from Dropdown component after #30947#30963
Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom Apr 8, 2024
Conversation
Dropdown component after 30947Dropdown component after #30947
7df2768 to
dba4529
Compare
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 38 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 652 | 680 | 5000 | |
| Button | mount | 306 | 322 | 5000 | |
| Field | mount | 1109 | 1129 | 5000 | |
| FluentProvider | mount | 705 | 717 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 38 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 79 | 10 | |
| MakeStyles | mount | 845 | 843 | 50000 | |
| Persona | mount | 1750 | 1738 | 5000 | |
| SpinButton | mount | 1396 | 1382 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Dropdown component after #30947Dropdown component after #30947
smhigley
reviewed
Apr 4, 2024
Contributor
smhigley
left a comment
There was a problem hiding this comment.
Just the one comment on where to put freeform, otherwise it looks good!
packages/react-components/react-combobox/etc/react-combobox.api.md
Outdated
Show resolved
Hide resolved
smhigley
approved these changes
Apr 5, 2024
f8e641a to
e0e72e3
Compare
YuanboXue-Amber
approved these changes
Apr 8, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Dropdownchanges introduced by chore(react-combobox): movefreeformanddisabledto ComboboxBase types #30947Related Issue(s)