chore(react-combobox): move freeform and disabled to ComboboxBase types#30947
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Apr 4, 2024
Conversation
freeform and disabled to ComboboxBase types
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 638 | 670 | 5000 | |
| Button | mount | 314 | 303 | 5000 | |
| Field | mount | 1170 | 1152 | 5000 | |
| FluentProvider | mount | 724 | 720 | 5000 | |
| FluentProviderWithTheme | mount | 100 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 82 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 95 | 10 | |
| MakeStyles | mount | 844 | 849 | 50000 | |
| Persona | mount | 1754 | 1703 | 5000 | |
| SpinButton | mount | 1426 | 1367 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
aea4eb8 to
5fa3819
Compare
5fa3819 to
412fd3e
Compare
YuanboXue-Amber
approved these changes
Apr 3, 2024
bsunderhus
added a commit
that referenced
this pull request
Apr 8, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
freeformanddisabledfromComboboxPropsandComboboxStatetoComboboxBasePropsandComboboxBaseStateselectionlogic fromuseComboboxtouseComboboxStatefreeformsupport forTagPicker@fluentui/react-comboboxare followed on@fluentui/react-tag-picker-previewRelated Issue(s)