A11y: Fix aria attribute for page number and add correct role#29349
Merged
behowell merged 18 commits intomicrosoft:masterfrom Oct 2, 2023
Merged
A11y: Fix aria attribute for page number and add correct role#29349behowell merged 18 commits intomicrosoft:masterfrom
behowell merged 18 commits intomicrosoft:masterfrom
Conversation
aria-selected is a wrong attribute for button. The correct attribute is aria-checked. Also, added role radio to reflect the correct role of this pagination.
Update PageNumber.tsx
add role="radiogroup" to parent of PageNumber
…56.json Update change description
behowell
approved these changes
Sep 29, 2023
…56.json Fix typo and wording in change file
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e6b734:
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
📊 Bundle size report🤖 This report was generated against 20ce41b1804af616985f527761602d49a9d58dd2 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 20ce41b1804af616985f527761602d49a9d58dd2 (build) |
auto-merge was automatically disabled
September 30, 2023 15:52
Head branch was pushed to by a user without write access
Contributor
Author
|
/azp |
Supported commands
See additional documentation. |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29349 in repo microsoft/fluentui |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (146 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (49 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run FastPass on Paginating control.
It will report an error that aria-selected is a wrong attribute for page number button. The correct attribute is aria-checked. Also, added role radio to reflect the correct role of this pagination.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked
Previous Behavior
The pagination buttons have the wrong aria attribute and fail a11y test tool by Microsoft.
New Behavior
The buttons have the correct aria-checked and correct role
Related Issue(s)