feat: Implement motion for MessageBar#29339
Merged
ling1726 merged 7 commits intomicrosoft:masterfrom Oct 2, 2023
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against f61033d77d6852838c580bfa7379d026128c2dbb |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7884909:
|
f6826fb to
56ae41c
Compare
bcce648 to
18b81d2
Compare
layershifter
reviewed
Oct 2, 2023
...components/react-message-bar-preview/src/components/MessageBar/useMessageBarStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-message-bar-preview/package.json
Outdated
Show resolved
Hide resolved
...components/react-message-bar-preview/src/components/MessageBarGroup/MessageBarTransition.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-message-bar-preview/stories/MessageBar/Animation.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-message-bar-preview/stories/MessageBar/Animation.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-message-bar-preview/stories/MessageBar/Dismiss.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-message-bar-preview/stories/MessageBar/Dismiss.stories.tsx
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f61033d77d6852838c580bfa7379d026128c2dbb (build) |
layershifter
approved these changes
Oct 2, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (146 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (49 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implenents animations for the MessageBar. There are two possible cases:
Animation is handled for collections of MessageBar components through the
MessageBarGroupcomponent. The group component owns the animation styles and wraps MessageBar components with transitions so that the MessageBar can still be used stand alone without transitionsAddresses: #22579