chore(react-tree): stable release by bsunderhus · Pull Request #28845 · microsoft/fluentui

bsunderhus · 2023-08-14T12:35:35Z

Previous Behavior

New Behavior

moves all code from react-tree-preview to react-tree
manually updates react-tree-preview everywhere to react-tree for the release
adds react-tree to react-components exports

Related Issue(s)

Fixes Tree #25266

fabricteam · 2023-08-14T12:42:42Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.162 kB` `1.735 kB`
`react-accordion` Accordion (including children components)	`88.592 kB` `26.885 kB`
`react-alert` Alert	`81.836 kB` `22.031 kB`
`react-avatar` Avatar	`47.01 kB` `14.502 kB`
`react-avatar` AvatarGroup	`16.116 kB` `6.431 kB`
`react-avatar` AvatarGroupItem	`61.789 kB` `18.912 kB`
`react-badge` Badge	`23.183 kB` `7.254 kB`
`react-badge` CounterBadge	`24.084 kB` `7.553 kB`
`react-badge` PresenceBadge	`22.14 kB` `7.867 kB`
`react-button` Button	`37.078 kB` `9.751 kB`
`react-button` CompoundButton	`44.427 kB` `11.234 kB`
`react-button` MenuButton	`41.464 kB` `11.001 kB`
`react-button` SplitButton	`49.499 kB` `12.555 kB`
`react-button` ToggleButton	`54.124 kB` `11.65 kB`
`react-card` Card - All	`88.335 kB` `25.271 kB`
`react-card` Card	`83.177 kB` `23.742 kB`
`react-card` CardFooter	`9.338 kB` `3.932 kB`
`react-card` CardHeader	`11.59 kB` `4.716 kB`
`react-card` CardPreview	`10.297 kB` `4.317 kB`
`react-checkbox` Checkbox	`32.872 kB` `10.652 kB`
`react-combobox` Combobox (including child components)	`87.075 kB` `28.263 kB`
`react-combobox` Dropdown (including child components)	`85.435 kB` `27.903 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`66.614 kB` `18.512 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.017 kB` `57.615 kB`
`react-components` react-components: FluentProvider & webLightTheme	`37.787 kB` `12.387 kB`
`react-datepicker-compat` DatePicker Compat	`207.101 kB` `57.398 kB`
`react-dialog` Dialog (including children components)	`86.738 kB` `26.341 kB`
`react-divider` Divider	`17.098 kB` `6.303 kB`
`react-field` Field	`18.295 kB` `6.978 kB`
`react-image` Image	`12.029 kB` `4.783 kB`
`react-infobutton` InfoButton	`125.224 kB` `39.235 kB`
`react-infobutton` InfoLabel	`128.894 kB` `40.413 kB`
`react-input` Input	`23.237 kB` `7.688 kB`
`react-label` Label	`10.423 kB` `4.31 kB`
`react-link` Link	`13.254 kB` `5.397 kB`
`react-menu` Menu (including children components)	`135.069 kB` `41.401 kB`
`react-menu` Menu (including selectable components)	`137.755 kB` `41.898 kB`
`react-overflow` hooks only	`12.419 kB` `4.687 kB`
`react-persona` Persona	`53.905 kB` `16.371 kB`
`react-popover` Popover	`114.577 kB` `35.925 kB`
`react-portal` Portal	`12.255 kB` `4.504 kB`
`react-portal-compat` PortalCompatProvider	`6.48 kB` `2.203 kB`
`react-positioning` usePositioning	`25.111 kB` `9.1 kB`
`react-progress` ProgressBar	`13.718 kB` `5.476 kB`
`react-provider` FluentProvider	`18.332 kB` `6.817 kB`
`react-radio` Radio	`26.617 kB` `8.601 kB`
`react-radio` RadioGroup	`11.622 kB` `4.833 kB`
`react-select` Select	`24.599 kB` `8.651 kB`
`react-slider` Slider	`34.134 kB` `11.039 kB`
`react-spinbutton` SpinButton	`32.681 kB` `10.209 kB`
`react-spinner` Spinner	`19.577 kB` `7.008 kB`
`react-switch` Switch	`29.092 kB` `9.217 kB`
`react-table` DataGrid	`152.77 kB` `42.242 kB`
`react-table` Table (Primitives only)	`39.638 kB` `12.129 kB`
`react-table` Table as DataGrid	`126.224 kB` `33.612 kB`
`react-table` Table (Selection only)	`71.594 kB` `18.91 kB`
`react-table` Table (Sort only)	`70.213 kB` `18.511 kB`
`react-tags-preview` InteractionTag	`11.031 kB` `4.528 kB`
`react-tags-preview` Tag	`25.407 kB` `8.398 kB`
`react-tags-preview` TagGroup	`69.607 kB` `20.482 kB`
`react-text` Text - Default	`13.043 kB` `5.129 kB`
`react-text` Text - Wrappers	`16.215 kB` `5.447 kB`
`react-textarea` Textarea	`27.302 kB` `9.047 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`87.69 kB` `26.037 kB`
`react-tooltip` Tooltip	`47.916 kB` `16.838 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against de73662bd4db7d730a3c256d7c900959100f3971}

fabricteam · 2023-08-14T12:44:48Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	622	612	5000
Button	mount	308	317	5000
Field	mount	1095	1138	5000
FluentProvider	mount	696	704	5000
FluentProviderWithTheme	mount	78	82	10
FluentProviderWithTheme	virtual-rerender	77	72	10
FluentProviderWithTheme	virtual-rerender-with-unmount	74	72	10
InfoButton	mount	10	13	5000
MakeStyles	mount	871	870	50000
Persona	mount	1711	1700	5000
SpinButton	mount	1373	1326	5000

fabricteam · 2023-08-14T12:48:03Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	98	79	1.24:1
ButtonSlotsPerf.default	333	303	1.1:1
RadioGroupMinimalPerf.default	274	252	1.09:1
TextMinimalPerf.default	196	181	1.08:1
FormMinimalPerf.default	230	215	1.07:1
AlertMinimalPerf.default	160	151	1.06:1
GridMinimalPerf.default	199	187	1.06:1
LoaderMinimalPerf.default	189	180	1.05:1
SegmentMinimalPerf.default	208	199	1.05:1
TableMinimalPerf.default	238	226	1.05:1
AttachmentMinimalPerf.default	87	84	1.04:1
AttachmentSlotsPerf.default	660	633	1.04:1
ListMinimalPerf.default	309	298	1.04:1
ListNestedPerf.default	328	316	1.04:1
ToolbarMinimalPerf.default	537	517	1.04:1
MenuMinimalPerf.default	492	479	1.03:1
ReactionMinimalPerf.default	214	207	1.03:1
StatusMinimalPerf.default	405	395	1.03:1
CustomToolbarPrototype.default	1476	1434	1.03:1
CheckboxMinimalPerf.default	1127	1100	1.02:1
RosterPerf.default	1586	1557	1.02:1
ProviderMinimalPerf.default	203	199	1.02:1
RefMinimalPerf.default	109	107	1.02:1
SliderMinimalPerf.default	738	720	1.02:1
IconMinimalPerf.default	385	378	1.02:1
ButtonOverridesMissPerf.default	648	643	1.01:1
CarouselMinimalPerf.default	265	262	1.01:1
EmbedMinimalPerf.default	1855	1833	1.01:1
InputMinimalPerf.default	537	530	1.01:1
ItemLayoutMinimalPerf.default	713	703	1.01:1
MenuButtonMinimalPerf.default	962	951	1.01:1
PopupMinimalPerf.default	349	347	1.01:1
ProviderMergeThemesPerf.default	670	662	1.01:1
SplitButtonMinimalPerf.default	2272	2244	1.01:1
TreeWith60ListItems.default	79	78	1.01:1
ChatMinimalPerf.default	421	423	1:1
DialogMinimalPerf.default	438	438	1:1
HeaderMinimalPerf.default	212	212	1:1
ListCommonPerf.default	385	385	1:1
PortalMinimalPerf.default	85	85	1:1
TableManyItemsPerf.default	1115	1110	1:1
TooltipMinimalPerf.default	1267	1264	1:1
VideoMinimalPerf.default	418	419	1:1
AvatarMinimalPerf.default	106	107	0.99:1
CardMinimalPerf.default	302	306	0.99:1
DatepickerMinimalPerf.default	3652	3675	0.99:1
DropdownMinimalPerf.default	1395	1414	0.99:1
TreeMinimalPerf.default	479	484	0.99:1
BoxMinimalPerf.default	189	192	0.98:1
ChatWithPopoverPerf.default	192	196	0.98:1
DropdownManyItemsPerf.default	374	381	0.98:1
LabelMinimalPerf.default	219	223	0.98:1
ChatDuplicateMessagesPerf.default	149	154	0.97:1
FlexMinimalPerf.default	155	159	0.97:1
TextAreaMinimalPerf.default	278	286	0.97:1
AnimationMinimalPerf.default	286	299	0.96:1
HeaderSlotsPerf.default	455	475	0.96:1
LayoutMinimalPerf.default	194	202	0.96:1
ListWith60ListItems.default	357	370	0.96:1
AccordionMinimalPerf.default	77	81	0.95:1
DividerMinimalPerf.default	195	205	0.95:1
ImageMinimalPerf.default	215	228	0.94:1
SkeletonMinimalPerf.default	186	198	0.94:1

codesandbox-ci · 2023-08-14T12:54:23Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 573e8c7:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-08-14T12:59:53Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	647	648	5000
Breadcrumb	mount	1663	1662	1000
Checkbox	mount	1716	1680	5000
CheckboxBase	mount	1487	1492	5000
ChoiceGroup	mount	3017	2956	5000
ComboBox	mount	661	654	1000
CommandBar	mount	6205	6232	1000
ContextualMenu	mount	12331	12003	1000
DefaultButton	mount	764	753	5000
DetailsRow	mount	2164	2178	5000
DetailsRowFast	mount	2152	2144	5000
DetailsRowNoStyles	mount	1951	2019	5000
Dialog	mount	2683	2621	1000
DocumentCardTitle	mount	233	227	1000
Dropdown	mount	1982	1995	5000
FocusTrapZone	mount	1107	1125	5000
FocusZone	mount	1056	1079	5000
GroupedList	mount	41417	41566	2
GroupedList	virtual-rerender	19823	19754	2
GroupedList	virtual-rerender-with-unmount	50338	50688	2
GroupedListV2	mount	222	226	2
GroupedListV2	virtual-rerender	214	212	2
GroupedListV2	virtual-rerender-with-unmount	222	225	2
IconButton	mount	1094	1073	5000
Label	mount	338	324	5000
Layer	mount	2784	2768	5000
Link	mount	383	387	5000
MenuButton	mount	949	942	5000
MessageBar	mount	21364	21377	5000
Nav	mount	1969	1902	1000
OverflowSet	mount	806	771	5000
Panel	mount	2034	1789	1000
Persona	mount	752	757	1000
Pivot	mount	889	873	1000
PrimaryButton	mount	862	838	5000
Rating	mount	4624	4609	5000
SearchBox	mount	932	890	5000
Shimmer	mount	1848	1864	5000
Slider	mount	1306	1331	5000
SpinButton	mount	2882	2877	5000
Spinner	mount	399	392	5000
SplitButton	mount	1839	1821	5000
Stack	mount	402	404	5000
StackWithIntrinsicChildren	mount	852	874	5000
StackWithTextChildren	mount	2557	2598	5000
SwatchColorPicker	mount	6202	6148	5000
TagPicker	mount	1458	1484	5000
Text	mount	374	372	5000
TextField	mount	971	947	5000
ThemeProvider	mount	827	837	5000
ThemeProvider	virtual-rerender	582	584	5000
ThemeProvider	virtual-rerender-with-unmount	1293	1293	5000
Toggle	mount	621	607	5000
buttonNative	mount	202	189	5000

fabricteam · 2023-08-14T13:00:23Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-08-14T13:03:42Z

🕵 fluentuiv9 No visual regressions between this PR and main

bsunderhus · 2023-08-14T14:27:09Z

Blocked by #28848

size-auditor · 2023-08-15T13:05:53Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: de73662bd4db7d730a3c256d7c900959100f3971 (build)

miroslavstastny

179 files changed to just release a package as stable is really hard to review. I understand this is caused by a change in the unstable release process in the middle of the component development, hopefully this will not be the case going forward (cc @Hotell, @levithomason)

change/@fluentui-react-components-0688cca2-da81-4fc4-b6a4-5eb65191cf56.json

packages/react-components/react-tree/package.json

bsunderhus · 2023-08-16T08:11:29Z

179 files changed to just release a package as stable is really hard to review. I understand this is caused by a change in the unstable release process in the middle of the component development, hopefully this will not be the case going forward (cc @Hotell, @levithomason)

As the development was ongoing in the middle of the new release process for v9 packages I ended up kind of ignoring it for the sake of the development 🙈, now I'm paying the price with an overly complicated release 😅.

I believe for new packages this won't be this dramatic @miroslavstastny

fabricteam · 2023-08-16T12:24:20Z

🕵 fluentuiv8 No visual regressions between this PR and main

* master: (66 commits) fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893) chore(react-tags-preview): add docs (microsoft#28899) applying package updates fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896) bugfix: headless flat tree itemType manual definition (microsoft#28898) doc(react-tree): adds a11y edge cases to the docs (microsoft#28897) Update DatePickerDescription.md with note about compat components (microsoft#28882) chore(react-tree): removes preview warning from the docs (microsoft#28886) applying package updates fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885) feat(react-tree): stable release (microsoft#28845) Virtualizer: Merge scrollref prop with container ref (microsoft#28829) chore(react-jsx-runtime): release stable version (microsoft#28880) applying package updates fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791) applying package updates feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870) feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804) docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856) Added more CY and VR tests to the Breadcrumb (microsoft#28790) ...

bsunderhus self-assigned this Aug 14, 2023

github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 14, 2023

bsunderhus force-pushed the react-tree/chore--stable-release branch from fca994a to dfa0c14 Compare August 14, 2023 12:42

bsunderhus added the Status: Blocked Resolution blocked by another issue label Aug 14, 2023

bsunderhus mentioned this pull request Aug 14, 2023

Docs(react-tree): Add drag and drop example #28821

Merged

bsunderhus force-pushed the react-tree/chore--stable-release branch from dfa0c14 to d54d303 Compare August 15, 2023 12:28

bsunderhus removed the Status: Blocked Resolution blocked by another issue label Aug 15, 2023

bsunderhus marked this pull request as ready for review August 15, 2023 13:19

bsunderhus requested review from a team, JustSlone, jurokapsiar and tudorpopams as code owners August 15, 2023 13:19

JustSlone approved these changes Aug 15, 2023

View reviewed changes

bsunderhus force-pushed the react-tree/chore--stable-release branch from bb455e6 to bfaa093 Compare August 15, 2023 17:15

miroslavstastny approved these changes Aug 15, 2023

View reviewed changes

change/@fluentui-react-components-0688cca2-da81-4fc4-b6a4-5eb65191cf56.json Outdated Show resolved Hide resolved

packages/react-components/react-tree/package.json Outdated Show resolved Hide resolved

packages/react-components/react-tree/package.json Outdated Show resolved Hide resolved

bsunderhus force-pushed the react-tree/chore--stable-release branch from bfaa093 to 06fdb80 Compare August 16, 2023 08:08

bsunderhus force-pushed the react-tree/chore--stable-release branch 2 times, most recently from 31c3788 to 11fdc28 Compare August 16, 2023 12:10

bsunderhus force-pushed the react-tree/chore--stable-release branch 3 times, most recently from e300272 to ae05033 Compare August 16, 2023 13:15

feat(react-tree): stable release

573e8c7

bsunderhus force-pushed the react-tree/chore--stable-release branch from ae05033 to 573e8c7 Compare August 16, 2023 13:24

tudorpopams approved these changes Aug 16, 2023

View reviewed changes

bsunderhus merged commit 566f224 into microsoft:master Aug 16, 2023

bsunderhus deleted the react-tree/chore--stable-release branch August 16, 2023 16:57

bsunderhus mentioned this pull request Aug 16, 2023

Tree #25266

Closed

22 tasks

Conversation

bsunderhus commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

codesandbox-ci bot commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

bsunderhus commented Aug 14, 2023

Uh oh!

size-auditor bot commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

miroslavstastny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bsunderhus commented Aug 16, 2023

Uh oh!

fabricteam commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bsunderhus commented Aug 14, 2023 •

edited

Loading

fabricteam commented Aug 14, 2023 •

edited

Loading

fabricteam commented Aug 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Aug 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

codesandbox-ci bot commented Aug 14, 2023 •

edited

Loading

fabricteam commented Aug 14, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Aug 14, 2023 •

edited

Loading

fabricteam commented Aug 14, 2023 •

edited

Loading

size-auditor bot commented Aug 15, 2023 •

edited

Loading

fabricteam commented Aug 16, 2023 •

edited

Loading