Virtualizer: Merge scrollref prop with container ref#28829
Merged
Mitch-At-Work merged 3 commits intomicrosoft:masterfrom Aug 16, 2023
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 647 | 629 | 5000 | |
| Button | mount | 304 | 320 | 5000 | |
| Field | mount | 1107 | 1091 | 5000 | |
| FluentProvider | mount | 690 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 64 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 78 | 10 | |
| InfoButton | mount | 13 | 19 | 5000 | |
| MakeStyles | mount | 854 | 870 | 50000 | |
| Persona | mount | 1663 | 1643 | 5000 | |
| SpinButton | mount | 1349 | 1369 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a1ab4d0:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 80a90fb61ed1e1a08cf6e897503a198dda97ed6c (build) |
brandonthomas
approved these changes
Aug 14, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 17, 2023
* master: (66 commits) fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893) chore(react-tags-preview): add docs (microsoft#28899) applying package updates fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896) bugfix: headless flat tree itemType manual definition (microsoft#28898) doc(react-tree): adds a11y edge cases to the docs (microsoft#28897) Update DatePickerDescription.md with note about compat components (microsoft#28882) chore(react-tree): removes preview warning from the docs (microsoft#28886) applying package updates fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885) feat(react-tree): stable release (microsoft#28845) Virtualizer: Merge scrollref prop with container ref (microsoft#28829) chore(react-jsx-runtime): release stable version (microsoft#28880) applying package updates fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791) applying package updates feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870) feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804) docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856) Added more CY and VR tests to the Breadcrumb (microsoft#28790) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 17, 2023
* master: (66 commits) fix(react-infobutton): Cursor should be pointer when hovering the button to show it's a button (microsoft#28893) chore(react-tags-preview): add docs (microsoft#28899) applying package updates fix(react-tree): stablilize `handleActionsRef` created by TreeItem (microsoft#28896) bugfix: headless flat tree itemType manual definition (microsoft#28898) doc(react-tree): adds a11y edge cases to the docs (microsoft#28897) Update DatePickerDescription.md with note about compat components (microsoft#28882) chore(react-tree): removes preview warning from the docs (microsoft#28886) applying package updates fix(public-docsite): Remove image clipping and move top banner under top nav to avoid header issues (microsoft#28885) feat(react-tree): stable release (microsoft#28845) Virtualizer: Merge scrollref prop with container ref (microsoft#28829) chore(react-jsx-runtime): release stable version (microsoft#28880) applying package updates fix(react-tags-preview): style update - tag hover style should only be on dismiss icon (microsoft#28791) applying package updates feat(public-docsite): Add topbanner component and use it in the public docsite (microsoft#28870) feat: Add VivaEngageIcon to @fluentui/react-icons-mdl2 package (microsoft#28804) docs: Remove InfoButton stories in favor of having only InfoLabel stories. (microsoft#28856) Added more CY and VR tests to the Breadcrumb (microsoft#28790) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We were not passing through scrollViewRef into the merged refs
New Behavior
ScrollViewRef prop should now be merged with container prop in scrollview virtualizers.
Related Issue(s)
N/A