fix: MenuList props should win over context props#26252
Merged
ling1726 merged 2 commits intomicrosoft:masterfrom Jan 9, 2023
Merged
fix: MenuList props should win over context props#26252ling1726 merged 2 commits intomicrosoft:masterfrom
ling1726 merged 2 commits intomicrosoft:masterfrom
Conversation
Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes #
bsunderhus
approved these changes
Jan 9, 2023
Contributor
bsunderhus
left a comment
There was a problem hiding this comment.
nit: are those new stories related to the fix? Shouldn't those be introduced in another PR?!
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 96c5a1cbb36d728bebfbf05203d372a82b1968d8 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1282 | 1284 | 5000 | |
| Button | mount | 922 | 925 | 5000 | |
| FluentProvider | mount | 1495 | 1492 | 5000 | |
| FluentProviderWithTheme | mount | 582 | 573 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 541 | 544 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 567 | 584 | 10 | |
| MakeStyles | mount | 1953 | 1936 | 50000 | |
| Persona | mount | 2832 | 2766 | 5000 | |
| SpinButton | mount | 2323 | 2320 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d05db1:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jan 10, 2023
* master: (29 commits) applying package updates fix: web component menu layering bug (microsoft#26260) Azure Theme: reduced spin button height to match TextField / DropDowns at 24px height (microsoft#26265) Update styling for contentBefore and contentAfter input slots (microsoft#26115) chore: Update Switch to use griffel reset styles (microsoft#26007) Fix: Allow root slot refs to merge with focus refs in Slider (microsoft#26243) applying package updates revert: MenuItem root slot only supports div (microsoft#26261) perf: Don't render Checkbox icon when unchecked (microsoft#26248) fix: Select disabled state hover style, Combobox disabled state open on chevron click (microsoft#26068) applying package updates chore: add more temporary codeowner rools for tooling config files (microsoft#26255) fix: stops using ARIAButton types for MenuItem root (microsoft#26257) refactor: Cleanup unused code (microsoft#26219) fix: MenuList props should win over context props (microsoft#26252) feat(react-tree): Actions positioning and behaviour (microsoft#26113) BREAKING(TableCellLayout): `wrapper` slot renamed to `content` (microsoft#26220) fix(scripts): make lint errors reporting propagate to STDOUT during pre-commit (lint-staged exec) (microsoft#26212) fix: Minimum visible overflow items should be respected (microsoft#26194) docs: Fix typos in react-table docs (microsoft#26213) ...
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
* fix: MenuList props should win over context props Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes # * changefile
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* fix: MenuList props should win over context props Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes # * changefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression introduced in #25672 so that prop values win over context props with the same name.
Also removes deprecation notice on
defaultCheckedValuesandonCheckedValueChangeforMenuListwhich are completely reasonable to use in scenarios whereMenuListis used standalone.Also updates documentation so that
Menuexamples will use the selection props on the rootMenucomponents. Adds selection examples forMenuListto be more clear about the differences between the two.Fixes #26253