Skip to content

BREAKING(TableCellLayout): wrapper slot renamed to content#26220

Merged
ling1726 merged 3 commits intomicrosoft:masterfrom
ling1726:breaking/table-layout-cell-wrapper
Jan 9, 2023
Merged

BREAKING(TableCellLayout): wrapper slot renamed to content#26220
ling1726 merged 3 commits intomicrosoft:masterfrom
ling1726:breaking/table-layout-cell-wrapper

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Jan 6, 2023 •
edited
Loading

⚠️ BREAKING CHANGE

Before

<TableCellLayout wrapper={{ className: 'wrapperSlot' }}>
  <Component />
</TableCellLayout>

After

<TableCellLayout content={{ className: 'contentSlot' }}>
  <Component />
</TableCellLayout>

Fixes #26203

@ling1726 ling1726 requested a review from a team as a code owner January 6, 2023 16:37
@ling1726 ling1726 changed the title BREAKING(TableCellLayout): wrwapper slot renamed to content BREAKING(TableCellLayout): wrapper slot renamed to content Jan 6, 2023
@github-actions github-actions bot added this to the January Project Cycle Q1 2023 milestone Jan 6, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 6, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 59.888 kB
16.652 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 188.928 kB
53.088 kB
react-components
react-components: FluentProvider & webLightTheme		 34.379 kB
11.322 kB
react-portal-compat
PortalCompatProvider		 6.069 kB
2.053 kB
🤖 This report was generated against 2611ae5441e4bc702c4ce6404c7186f6c2de7cc3

@size-auditor
Copy link

size-auditor bot commented Jan 6, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2611ae5441e4bc702c4ce6404c7186f6c2de7cc3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 6, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1256 1270 5000
Button mount 910 909 5000
FluentProvider mount 1490 1492 5000
FluentProviderWithTheme mount 570 571 10
FluentProviderWithTheme virtual-rerender 559 548 10
FluentProviderWithTheme virtual-rerender-with-unmount 582 584 10
MakeStyles mount 1944 1946 50000
Persona mount 2859 2808 5000
SpinButton mount 2335 2373 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1acb59e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 6, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@ling1726 ling1726 merged commit 87fcaf1 into microsoft:master Jan 9, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jan 10, 2023
@marcosmoura
Merge branch 'master' into marcosmoura/docs/v0-migration-guide
9fc16e0 
* master: (29 commits)
  applying package updates
  fix: web component menu layering bug (microsoft#26260)
  Azure Theme: reduced spin button height to match TextField / DropDowns at 24px height (microsoft#26265)
  Update styling for contentBefore and contentAfter input slots (microsoft#26115)
  chore: Update Switch to use griffel reset styles (microsoft#26007)
  Fix: Allow root slot refs to merge with focus refs in Slider (microsoft#26243)
  applying package updates
  revert: MenuItem root slot only supports div (microsoft#26261)
  perf: Don't render Checkbox icon when unchecked (microsoft#26248)
  fix: Select disabled state hover style, Combobox disabled state open on chevron click (microsoft#26068)
  applying package updates
  chore: add more temporary codeowner rools for tooling config files (microsoft#26255)
  fix: stops using ARIAButton types for MenuItem root (microsoft#26257)
  refactor: Cleanup unused code (microsoft#26219)
  fix: MenuList props should win over context props (microsoft#26252)
  feat(react-tree):  Actions positioning and behaviour (microsoft#26113)
  BREAKING(TableCellLayout): `wrapper` slot renamed to `content` (microsoft#26220)
  fix(scripts): make lint errors reporting propagate to STDOUT during pre-commit (lint-staged exec) (microsoft#26212)
  fix: Minimum visible overflow items should be respected (microsoft#26194)
  docs: Fix typos in react-table docs (microsoft#26213)
  ...
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@ling1726 @q1b
BREAKING(TableCellLayout): wrapper slot renamed to content (micro…
4c6fa7d 
…soft#26220)

* BREAKING(TableCellLayout): `wrwapper` slot renamed to `content`

See title

Fixes microsoft#26203

* changefile

* update snapshot
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@ling1726 @Hotell
BREAKING(TableCellLayout): wrapper slot renamed to content (micro…
34a87fb 
…soft#26220)

* BREAKING(TableCellLayout): `wrwapper` slot renamed to `content`

See title

Fixes microsoft#26203

* changefile

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees

@spmonahan spmonahan

Labels

Component: Table

Projects

None yet

Milestone

January Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

react-table: TableCellLayout has wrapper, it is a confusing name for slot

5 participants

@ling1726 @fabricteam @bsunderhus @msft-fluent-ui-bot @spmonahan