chore: move temporary codeowner rules to the bottom to give them highest specificity by Hotell · Pull Request #26128 · microsoft/fluentui

Hotell · 2022-12-29T12:13:44Z

follow-up/fix of #26123 - the order does matter 🙃

Related Issue(s)

…est specificity

size-auditor · 2022-12-29T12:25:30Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2daafb9c99ce0482b696029f6a92df5c12250d65 (build)

fabricteam · 2022-12-29T12:29:03Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1582	1604	5000
Button	mount	1120	1142	5000
FluentProvider	mount	1941	1954	5000
FluentProviderWithTheme	mount	757	742	10
FluentProviderWithTheme	virtual-rerender	741	707	10
FluentProviderWithTheme	virtual-rerender-with-unmount	786	761	10
MakeStyles	mount	2337	2361	50000
Persona	mount	3596	3641	5000
SpinButton	mount	3007	2934	5000

codesandbox-ci · 2022-12-29T12:29:41Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dfaee15:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-29T12:31:20Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png	0	Added
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png	0	Added

fabricteam · 2022-12-29T12:33:32Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.673 kB` `24.57 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.54 kB` `22.326 kB`
`react-card` Card	`72.484 kB` `20.915 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.713 kB` `25.211 kB`
`react-combobox` ComboboxField	`75.916 kB` `25.158 kB`
`react-combobox` Dropdown (including child components)	`77.961 kB` `25.154 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.536 kB` `52.644 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.035 kB` `24.76 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.381 kB` `35.495 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`118.257 kB` `36.535 kB`
`react-menu` Menu (including selectable components)	`121.326 kB` `37.065 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.125 kB` `32.068 kB`
`react-portal` Portal	`10.697 kB` `3.938 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.883 kB` `7.439 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.158 kB` `14.796 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 2daafb9c99ce0482b696029f6a92df5c12250d65}

fabricteam · 2022-12-29T12:33:57Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-29T12:38:22Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-29T12:43:03Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1354	1372	5000
Breadcrumb	mount	3390	3354	1000
Checkbox	mount	2978	2994	5000
CheckboxBase	mount	2691	2710	5000
ChoiceGroup	mount	5080	5056	5000
ComboBox	mount	1400	1408	1000
CommandBar	mount	10977	10879	1000
ContextualMenu	mount	12265	12180	1000
DefaultButton	mount	1554	1558	5000
DetailsRow	mount	4081	4191	5000
DetailsRowFast	mount	4163	4064	5000
DetailsRowNoStyles	mount	3930	3979	5000
Dialog	mount	3540	3533	1000
DocumentCardTitle	mount	647	672	1000
Dropdown	mount	3617	3629	5000
FocusTrapZone	mount	2299	2254	5000
FocusZone	mount	2230	2281	5000
GroupedList	mount	2199	2418	2
GroupedList	virtual-rerender	1300	1305	2
GroupedList	virtual-rerender-with-unmount	1898	1916	2
GroupedListV2	mount	650	665	2
GroupedListV2	virtual-rerender	632	628	2
GroupedListV2	virtual-rerender-with-unmount	657	647	2
IconButton	mount	2309	2167	5000
Label	mount	826	840	5000
Layer	mount	5022	4902	5000
Link	mount	962	967	5000
MenuButton	mount	1912	1949	5000
MessageBar	mount	2682	2726	5000
Nav	mount	3783	3755	1000
OverflowSet	mount	1545	1573	5000
Panel	mount	2873	2907	1000
Persona	mount	1489	1486	1000
Pivot	mount	1859	1845	1000
PrimaryButton	mount	1720	1738	5000
Rating	mount	7998	7994	5000
SearchBox	mount	1687	1710	5000
Shimmer	mount	3208	3242	5000
Slider	mount	2388	2359	5000
SpinButton	mount	5331	5330	5000
Spinner	mount	924	915	5000
SplitButton	mount	3517	3463	5000
Stack	mount	943	955	5000
StackWithIntrinsicChildren	mount	2653	2684	5000
StackWithTextChildren	mount	5437	5436	5000
SwatchColorPicker	mount	11750	11805	5000
TagPicker	mount	2967	2979	5000
TeachingBubble	mount	94151	94571	5000
Text	mount	895	911	5000
TextField	mount	1792	1814	5000
ThemeProvider	mount	1718	1733	5000
ThemeProvider	virtual-rerender	1216	1221	5000
ThemeProvider	virtual-rerender-with-unmount	2444	2451	5000
Toggle	mount	1266	1268	5000
buttonNative	mount	627	619	5000

fabricteam · 2022-12-29T12:54:30Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…est specificity (microsoft#26128)

chore: move temporary codeowner rules to the bottom to give them high…

dfaee15

…est specificity

msft-fluent-ui-bot assigned smhigley Dec 29, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 29, 2022

Hotell changed the title ~~chore: move temporary codeowner rules to the bottom to give them high…~~ chore: move temporary codeowner rules to the bottom to give them highest specificity Dec 29, 2022

Hotell unassigned smhigley Dec 29, 2022

Hotell marked this pull request as ready for review December 29, 2022 12:24

Hotell requested review from a team, JustSlone, jurokapsiar and tudorpopams as code owners December 29, 2022 12:24

tudorpopams approved these changes Dec 29, 2022

View reviewed changes

Hotell enabled auto-merge (squash) December 29, 2022 12:30

Hotell merged commit 3051062 into microsoft:master Dec 29, 2022

Hotell deleted the hotell/build/scripts/temporary-codeowners-change-3 branch December 29, 2022 13:39

This was referenced Jan 3, 2023

chore: add more temporary rules for v-build to co-own #26146

Merged

chore: add more temporary codeowner rules for tooling config files #26255

Merged

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore: move temporary codeowner rules to the bottom to give them high…

403bc43

…est specificity (microsoft#26128)

Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore: move temporary codeowner rules to the bottom to give them high…

fbad46e

…est specificity (microsoft#26128)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move temporary codeowner rules to the bottom to give them highest specificity#26128

chore: move temporary codeowner rules to the bottom to give them highest specificity#26128
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/temporary-codeowners-change-3

Hotell commented Dec 29, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

codesandbox-ci bot commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Hotell commented Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue(s)

Uh oh!

size-auditor bot commented Dec 29, 2022

Asset size changes

Uh oh!

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Dec 29, 2022

Uh oh!

fabricteam commented Dec 29, 2022

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

Uh oh!

fabricteam commented Dec 29, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 29, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 29, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hotell commented Dec 29, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)