chore: make temporary owner rules work with globs#26123
Merged
Hotell merged 1 commit intomicrosoft:masterfrom Dec 28, 2022
Merged
chore: make temporary owner rules work with globs#26123Hotell merged 1 commit intomicrosoft:masterfrom
Hotell merged 1 commit intomicrosoft:masterfrom
Conversation
0418c3e to
08c2b23
Compare
tudorpopams
approved these changes
Dec 28, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ef2b5dd278b6f72631282cf6a49161a006d30850 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 08c2b23:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1291 | 1339 | 5000 | |
| Button | mount | 938 | 938 | 5000 | |
| FluentProvider | mount | 1595 | 1631 | 5000 | |
| FluentProviderWithTheme | mount | 634 | 628 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 598 | 590 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 629 | 10 | |
| MakeStyles | mount | 1910 | 1905 | 50000 | |
| Persona | mount | 2984 | 2971 | 5000 | |
| SpinButton | mount | 2536 | 2567 | 5000 |
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 1045 screenshots✅ There was 1045 screenshots added, 0 screenshots removed, 0 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. OverflowSet.Root - RTL.default.chromium 1 screenshots
OverflowSet.Root.default.chromium 1 screenshots
SearchBox.Full - RTL.default.chromium 1 screenshots
SearchBox.Full.default.chromium 1 screenshots
SearchBox.Root - RTL.default.chromium 1 screenshots
SearchBox.Root.default.chromium 1 screenshots
SearchBox.ShowIcon - RTL.default.chromium 1 screenshots
SearchBox.ShowIcon.default.chromium 1 screenshots
unknown 1037 screenshots
|
Collaborator
Perf Analysis (
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1193 | 1208 | 5000 | |
| Breadcrumb | mount | 3042 | 3028 | 1000 | |
| Checkbox | mount | 2651 | 2668 | 5000 | |
| CheckboxBase | mount | 2339 | 2391 | 5000 | |
| ChoiceGroup | mount | 4425 | 4461 | 5000 | |
| ComboBox | mount | 1266 | 1255 | 1000 | |
| CommandBar | mount | 9709 | 9786 | 1000 | |
| ContextualMenu | mount | 11365 | 11300 | 1000 | |
| DefaultButton | mount | 1359 | 1379 | 5000 | |
| DetailsRow | mount | 3589 | 3646 | 5000 | |
| DetailsRowFast | mount | 3693 | 3723 | 5000 | |
| DetailsRowNoStyles | mount | 3470 | 3530 | 5000 | |
| Dialog | mount | 3079 | 3105 | 1000 | |
| DocumentCardTitle | mount | 577 | 593 | 1000 | |
| Dropdown | mount | 3173 | 3202 | 5000 | |
| FocusTrapZone | mount | 1991 | 1992 | 5000 | |
| FocusZone | mount | 1984 | 1994 | 5000 | |
| GroupedList | mount | 1938 | 2178 | 2 | |
| GroupedList | virtual-rerender | 1158 | 1103 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1687 | 1703 | 2 | |
| GroupedListV2 | mount | 564 | 574 | 2 | |
| GroupedListV2 | virtual-rerender | 549 | 581 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 559 | 573 | 2 | |
| IconButton | mount | 1887 | 1912 | 5000 | |
| Label | mount | 737 | 726 | 5000 | |
| Layer | mount | 4325 | 4341 | 5000 | |
| Link | mount | 838 | 840 | 5000 | |
| MenuButton | mount | 1663 | 1666 | 5000 | |
| MessageBar | mount | 2347 | 2314 | 5000 | |
| Nav | mount | 3324 | 3285 | 1000 | |
| OverflowSet | mount | 1340 | 1352 | 5000 | |
| Panel | mount | 2567 | 2550 | 1000 | |
| Persona | mount | 1292 | 1318 | 1000 | |
| Pivot | mount | 1680 | 1639 | 1000 | |
| PrimaryButton | mount | 1515 | 1526 | 5000 | |
| Rating | mount | 6963 | 6976 | 5000 | |
| SearchBox | mount | 1540 | 1507 | 5000 | |
| Shimmer | mount | 2882 | 2894 | 5000 | |
| Slider | mount | 2109 | 2133 | 5000 | |
| SpinButton | mount | 4715 | 4691 | 5000 | |
| Spinner | mount | 805 | 802 | 5000 | |
| SplitButton | mount | 3070 | 3069 | 5000 | |
| Stack | mount | 819 | 825 | 5000 | |
| StackWithIntrinsicChildren | mount | 2357 | 2345 | 5000 | |
| StackWithTextChildren | mount | 4848 | 4819 | 5000 | |
| SwatchColorPicker | mount | 10513 | 10318 | 5000 | |
| TagPicker | mount | 2622 | 2611 | 5000 | |
| TeachingBubble | mount | 95901 | 95669 | 5000 | |
| Text | mount | 807 | 784 | 5000 | |
| TextField | mount | 1610 | 1635 | 5000 | |
| ThemeProvider | mount | 1537 | 1540 | 5000 | |
| ThemeProvider | virtual-rerender | 1059 | 1097 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2146 | 2173 | 5000 | |
| Toggle | mount | 1109 | 1112 | 5000 | |
| buttonNative | mount | 549 | 542 | 5000 |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up/fix of #26121 - make rules work in whole repo
Related Issue(s)