chore: add new temporary rules for codeonwers by Hotell · Pull Request #26121 · microsoft/fluentui

Hotell · 2022-12-28T10:28:13Z

To enable better velocity (time to merge/count of people requested for review to unblock) this introduces temporary codeowner files change until #24349 is finished.

Example of huge list of review:

#26110

Related Issue(s)

feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

size-auditor · 2022-12-28T10:39:50Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f02e92f95e93a6417e64246f2057a1006b64ca90 (build)

fabricteam · 2022-12-28T10:42:17Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1312	1256	5000
Button	mount	943	947	5000
FluentProvider	mount	1575	1586	5000
FluentProviderWithTheme	mount	629	1862	10
FluentProviderWithTheme	virtual-rerender	598	589	10
FluentProviderWithTheme	virtual-rerender-with-unmount	633	626	10
MakeStyles	mount	1909	1871	50000
Persona	mount	3027	3038	5000
SpinButton	mount	2595	2551	5000

codesandbox-ci · 2022-12-28T10:43:55Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62577b2:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-28T10:45:18Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-12-28T10:47:52Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-28T10:48:04Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.673 kB` `24.57 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.54 kB` `22.326 kB`
`react-card` Card	`72.484 kB` `20.915 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.713 kB` `25.211 kB`
`react-combobox` ComboboxField	`75.916 kB` `25.158 kB`
`react-combobox` Dropdown (including child components)	`77.961 kB` `25.154 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.536 kB` `52.644 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.035 kB` `24.76 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.381 kB` `35.495 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`118.257 kB` `36.535 kB`
`react-menu` Menu (including selectable components)	`121.326 kB` `37.065 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.125 kB` `32.068 kB`
`react-portal` Portal	`10.697 kB` `3.938 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.883 kB` `7.439 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.158 kB` `14.796 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against f02e92f95e93a6417e64246f2057a1006b64ca90}

fabricteam · 2022-12-28T10:51:38Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-28T10:54:52Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1183	1192	5000
Breadcrumb	mount	2818	2806	1000
Checkbox	mount	2642	2657	5000
CheckboxBase	mount	2376	2384	5000
ChoiceGroup	mount	4288	4246	5000
ComboBox	mount	1151	1174	1000
CommandBar	mount	9236	9287	1000
ContextualMenu	mount	10112	10095	1000
DefaultButton	mount	1348	1365	5000
DetailsRow	mount	3396	3366	5000
DetailsRowFast	mount	3359	3364	5000
DetailsRowNoStyles	mount	3215	3212	5000
Dialog	mount	2918	2939	1000
DocumentCardTitle	mount	583	575	1000
Dropdown	mount	3151	3151	5000
FocusTrapZone	mount	1936	1950	5000
FocusZone	mount	1965	1945	5000
GroupedList	mount	1840	2056	2
GroupedList	virtual-rerender	1067	1079	2
GroupedList	virtual-rerender-with-unmount	1596	1630	2
GroupedListV2	mount	556	571	2
GroupedListV2	virtual-rerender	545	544	2
GroupedListV2	virtual-rerender-with-unmount	555	557	2
IconButton	mount	1798	1795	5000
Label	mount	748	759	5000
Layer	mount	4173	4211	5000
Link	mount	834	848	5000
MenuButton	mount	1600	1595	5000
MessageBar	mount	2303	2351	5000
Nav	mount	3064	3035	1000
OverflowSet	mount	1408	1403	5000
Panel	mount	2501	2489	1000
Persona	mount	1273	1285	1000
Pivot	mount	1552	1491	1000
PrimaryButton	mount	1486	1489	5000
Rating	mount	6957	6943	5000
SearchBox	mount	1474	1488	5000
Shimmer	mount	2915	2956	5000
Slider	mount	2081	2103	5000
SpinButton	mount	4254	4210	5000
Spinner	mount	837	834	5000
SplitButton	mount	2819	2811	5000
Stack	mount	850	868	5000
StackWithIntrinsicChildren	mount	2311	2259	5000
StackWithTextChildren	mount	4983	4946	5000
SwatchColorPicker	mount	9417	9424	5000
TagPicker	mount	2342	2324	5000
TeachingBubble	mount	75003	75194	5000
Text	mount	813	812	5000
TextField	mount	1539	1539	5000
ThemeProvider	mount	1445	1444	5000
ThemeProvider	virtual-rerender	1135	1132	5000
ThemeProvider	virtual-rerender-with-unmount	1992	2009	5000
Toggle	mount	1143	1123	5000
buttonNative	mount	522	529	5000

fabricteam · 2022-12-28T11:01:19Z

🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1259 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference.

unknown 1 screenshots

Image Name	Diff(in Pixels)	Image Type
Reaction.Reaction Group Example.chromium.png	165	Changed

chore: add new temporary rules for codeonwers

62577b2

msft-fluent-ui-bot assigned smhigley Dec 28, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 28, 2022

Hotell unassigned smhigley Dec 28, 2022

Hotell marked this pull request as ready for review December 28, 2022 10:32

Hotell requested review from a team, JustSlone and jurokapsiar as code owners December 28, 2022 10:32

tudorpopams approved these changes Dec 28, 2022

View reviewed changes

Hotell merged commit ef2b5dd into microsoft:master Dec 28, 2022

Hotell deleted the hotell/build/scripts/temporary-codeowners-change branch December 28, 2022 12:09

Hotell mentioned this pull request Dec 28, 2022

chore: make temporary owner rules work with globs #26123

Merged

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore: add new temporary rules for codeonwers (microsoft#26121)

b7b0333

Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore: add new temporary rules for codeonwers (microsoft#26121)

be489bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add new temporary rules for codeonwers#26121

chore: add new temporary rules for codeonwers#26121
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/temporary-codeowners-change

Hotell commented Dec 28, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

codesandbox-ci bot commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Hotell commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue(s)

Uh oh!

size-auditor bot commented Dec 28, 2022

Asset size changes

Uh oh!

fabricteam commented Dec 28, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Dec 28, 2022

Uh oh!

fabricteam commented Dec 28, 2022

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 28, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 28, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Dec 28, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 28, 2022

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 28, 2022

🕵 FluentUI-v0 Open the Visual Regressions report to inspect the 1 screenshots

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hotell commented Dec 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)