Skip to content

chore(scripts): move index.ts to /tasks to follow sub-folder domain packaging#26110

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v14
Dec 30, 2022
Merged

chore(scripts): move index.ts to /tasks to follow sub-folder domain packaging#26110
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v14

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Dec 27, 2022 •
edited
Loading

Previous Behavior

@fluentui/scripts is being used as one package for everything (but in reality exposes only just-scripts tasks)

New Behavior

@fluentui/scripts doesn't provide any api. its index is moved to proper domain boundary which is /tasks.

NOTE: this is the last step for "packaging" scripts sub-folders which will enable us to introduce proper packages

Diff

-import { preset, task } from '@fluentui/scripts';
+import { preset, task } from '@fluentui/scripts/tasks';

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.673 kB
24.57 kB
react-alert
Alert		 84.15 kB
21.28 kB
react-avatar
Avatar		 51.083 kB
14.289 kB
react-avatar
AvatarGroup		 15.006 kB
6.009 kB
react-avatar
AvatarGroupItem		 67.313 kB
18.585 kB
react-badge
Badge		 23.357 kB
7.361 kB
react-badge
CounterBadge		 24.247 kB
7.643 kB
react-badge
PresenceBadge		 24.001 kB
7.049 kB
react-button
Button		 32.923 kB
8.61 kB
react-button
CompoundButton		 39.953 kB
9.933 kB
react-button
MenuButton		 37.611 kB
9.942 kB
react-button
SplitButton		 45.057 kB
11.323 kB
react-button
ToggleButton		 48.753 kB
10.715 kB
react-card
Card - All		 77.54 kB
22.326 kB
react-card
Card		 72.484 kB
20.915 kB
react-card
CardFooter		 8.617 kB
3.62 kB
react-card
CardHeader		 10.382 kB
4.258 kB
react-card
CardPreview		 9.424 kB
3.97 kB
react-checkbox
Checkbox		 28.65 kB
9.09 kB
react-checkbox
CheckboxField		 35.067 kB
10.89 kB
react-combobox
Combobox (including child components)		 78.713 kB
25.211 kB
react-combobox
ComboboxField		 75.916 kB
25.158 kB
react-combobox
Dropdown (including child components)		 77.961 kB
25.154 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.536 kB
52.644 kB
react-components
react-components: FluentProvider & webLightTheme		 33.843 kB
11.129 kB
react-dialog
Dialog (including children components)		 83.035 kB
24.76 kB
react-divider
Divider		 16.515 kB
5.921 kB
react-image
Image		 10.836 kB
4.283 kB
react-infobutton
InfoButton		 118.381 kB
35.495 kB
react-input
Input		 24.194 kB
7.89 kB
react-input
InputField		 33.408 kB
10.584 kB
react-label
Label		 9.394 kB
3.88 kB
react-link
Link		 11.862 kB
4.885 kB
react-menu
Menu (including children components)		 118.257 kB
36.535 kB
react-menu
Menu (including selectable components)		 121.326 kB
37.065 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 57.12 kB
15.945 kB
react-popover
Popover		 104.125 kB
32.068 kB
react-portal
Portal		 10.697 kB
3.938 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.883 kB
7.439 kB
react-progress
ProgressBar		 13.155 kB
5.048 kB
react-progress
ProgressField		 22.461 kB
7.919 kB
react-provider
FluentProvider		 15.91 kB
5.931 kB
react-radio
Radio		 31.827 kB
10.316 kB
react-radio
RadioGroup		 14.304 kB
5.72 kB
react-radio
RadioGroupField		 23.604 kB
8.65 kB
react-select
Select		 23.474 kB
8.017 kB
react-select
SelectField		 31.731 kB
10.256 kB
react-slider
Slider		 32.091 kB
10.183 kB
react-slider
SliderField		 41.113 kB
12.903 kB
react-spinbutton
SpinButton		 44.502 kB
12.812 kB
react-spinbutton
SpinButtonField		 52.784 kB
15.085 kB
react-spinner
Spinner		 20.013 kB
6.446 kB
react-switch
Switch		 33.427 kB
10.581 kB
react-switch
SwitchField		 39.745 kB
12.362 kB
react-text
Text - Default		 11.838 kB
4.625 kB
react-text
Text - Wrappers		 15.148 kB
5.06 kB
react-textarea
Textarea		 25.733 kB
8.328 kB
react-textarea
TextareaField		 34.949 kB
11.012 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.908 kB
6.714 kB
react-theme
Teams: Light theme		 17.776 kB
5.141 kB
react-tooltip
Tooltip		 42.158 kB
14.796 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 194b0cf0cc27c1c1233aa945f09b3ad29778d8ca

@size-auditor
Copy link

size-auditor bot commented Dec 27, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2daafb9c99ce0482b696029f6a92df5c12250d65 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1295 1263 5000
Button mount 911 910 5000
FluentProvider mount 1517 1483 5000
FluentProviderWithTheme mount 577 584 10
FluentProviderWithTheme virtual-rerender 547 540 10
FluentProviderWithTheme virtual-rerender-with-unmount 583 569 10
MakeStyles mount 1979 1972 50000
Persona mount 2822 2789 5000
SpinButton mount 2364 2321 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 27, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 417a38e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1203 1204 5000
Breadcrumb mount 2843 2801 1000
Checkbox mount 2636 2615 5000
CheckboxBase mount 2351 2363 5000
ChoiceGroup mount 4244 4243 5000
ComboBox mount 1166 1158 1000
CommandBar mount 9289 9219 1000
ContextualMenu mount 10164 10052 1000
DefaultButton mount 1352 1358 5000
DetailsRow mount 3356 3367 5000
DetailsRowFast mount 3377 3354 5000
DetailsRowNoStyles mount 3176 3177 5000
Dialog mount 2992 2943 1000
DocumentCardTitle mount 582 568 1000
Dropdown mount 3127 3135 5000
FocusTrapZone mount 1946 1963 5000
FocusZone mount 1872 1905 5000
GroupedList mount 1832 2007 2
GroupedList virtual-rerender 1079 1108 2
GroupedList virtual-rerender-with-unmount 1589 1597 2
GroupedListV2 mount 564 571 2
GroupedListV2 virtual-rerender 540 544 2
GroupedListV2 virtual-rerender-with-unmount 568 566 2
IconButton mount 1808 1768 5000
Label mount 743 753 5000
Layer mount 4159 4170 5000
Link mount 858 865 5000
MenuButton mount 1607 1615 5000
MessageBar mount 2330 2310 5000
Nav mount 3040 3070 1000
OverflowSet mount 1419 1382 5000
Panel mount 2504 2503 1000
Persona mount 1296 1277 1000
Pivot mount 1536 1528 1000
PrimaryButton mount 1494 1497 5000
Rating mount 6893 6949 5000
SearchBox mount 1493 1489 5000
Shimmer mount 2878 2902 5000
Slider mount 2064 2125 5000
SpinButton mount 4236 4279 5000
Spinner mount 817 818 5000
SplitButton mount 2813 2811 5000
Stack mount 851 853 5000
StackWithIntrinsicChildren mount 2266 2249 5000
StackWithTextChildren mount 4953 4969 5000
SwatchColorPicker mount 9428 9380 5000
TagPicker mount 2325 2335 5000
TeachingBubble mount 73709 74185 5000
Text mount 831 821 5000
TextField mount 1544 1548 5000
ThemeProvider mount 1441 1443 5000
ThemeProvider virtual-rerender 1147 1129 5000
ThemeProvider virtual-rerender-with-unmount 2005 2003 5000
Toggle mount 1140 1127 5000
buttonNative mount 533 531 5000

@Hotell Hotell changed the title chore(scripts): move index.ts to to follow sub-folder domain packaging chore(scripts): move index.ts to follow sub-folder domain packaging Dec 28, 2022
@Hotell Hotell changed the title chore(scripts): move index.ts to follow sub-folder domain packaging chore(scripts): move index.ts to /tasks to follow sub-folder domain packaging Dec 28, 2022
@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v14 branch from c961c70 to a9b73c1 Compare December 28, 2022 10:17
@Hotell Hotell mentioned this pull request Dec 28, 2022
Merged
@Hotell Hotell marked this pull request as ready for review December 28, 2022 17:05
@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v14 branch from dd011b5 to 417a38e Compare December 29, 2022 12:07
@Hotell Hotell merged commit 4ec2b99 into microsoft:master Dec 30, 2022
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v14 branch December 30, 2022 10:53
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@Hotell @q1b
chore(scripts): move index.ts to /tasks to follow sub-folder domain…
5267a2e 
… packaging (microsoft#26110)

* chore(scripts): move index.ts to  to follow sub-folder domain packaging

* generate change-file
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
chore(scripts): move index.ts to /tasks to follow sub-folder domain…
6b8dbcd 
… packaging (microsoft#26110)

* chore(scripts): move index.ts to  to follow sub-folder domain packaging

* generate change-file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sopranopillow sopranopillow sopranopillow approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@AtishayMsft AtishayMsft AtishayMsft approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@tomi-msft tomi-msft Awaiting requested review from tomi-msft

@chpalac chpalac Awaiting requested review from chpalac

@ling1726 ling1726 Awaiting requested review from ling1726

@behowell behowell Awaiting requested review from behowell

@khmakoto khmakoto Awaiting requested review from khmakoto

@spmonahan spmonahan Awaiting requested review from spmonahan

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@smhigley smhigley Awaiting requested review from smhigley

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers

@robtaft-ms robtaft-ms Awaiting requested review from robtaft-ms

@Jacqueline-ms Jacqueline-ms Awaiting requested review from Jacqueline-ms

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

6 participants

@Hotell @fabricteam @sopranopillow @TristanWatanabe @AtishayMsft @smhigley