feat: Bump tabster to 3.0.4 by ling1726 · Pull Request #25294 · microsoft/fluentui

ling1726 · 2022-10-19T13:34:07Z

Bumps tabster to 3.0.4 to pick up fix(Mover): Fixing Mover grid behaviour and adding tests for it. tabster#196 and improved grid keyboard navigation
Updates the guidance for Table keyboard navigation to use useArrowNavigationGroup

Bumps tabster to 3.0.4 and updates the guidance for `Table` keyboard navigation to use `useArrowNavigationGroup`

codesandbox-ci · 2022-10-19T13:46:20Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 748234e:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-10-19T13:47:09Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-accordion` Accordion (including children components)	`79.083 kB` `24.079 kB`	`79.243 kB` `24.436 kB`	`160 B` `357 B`
`react-card` Card - All	`67.216 kB` `19.304 kB`	`67.664 kB` `19.635 kB`	`448 B` `331 B`
`react-card` Card	`62.898 kB` `18.22 kB`	`63.346 kB` `18.539 kB`	`448 B` `319 B`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`189.44 kB` `52.569 kB`	`189.603 kB` `52.909 kB`	`163 B` `340 B`
`react-dialog` Dialog (including children components)	`82.626 kB` `24.504 kB`	`83.099 kB` `24.777 kB`	`473 B` `273 B`
`react-menu` Menu (including children components)	`116.62 kB` `35.774 kB`	`116.78 kB` `36.112 kB`	`160 B` `338 B`
`react-menu` Menu (including selectable components)	`119.689 kB` `36.296 kB`	`119.849 kB` `36.635 kB`	`160 B` `339 B`
`react-popover` Popover	`102.864 kB` `31.542 kB`	`103.342 kB` `31.82 kB`	`478 B` `278 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-alert` Alert	`84.688 kB` `21.233 kB`
`react-avatar` Avatar	`48.874 kB` `13.864 kB`
`react-avatar` AvatarGroup	`14.996 kB` `6.013 kB`
`react-avatar` AvatarGroupItem	`68.842 kB` `19.205 kB`
`react-badge` Badge	`22.646 kB` `7.228 kB`
`react-badge` CounterBadge	`23.536 kB` `7.512 kB`
`react-badge` PresenceBadge	`24.096 kB` `7.09 kB`
`react-button` Button	`36.849 kB` `9.907 kB`
`react-button` CompoundButton	`43.874 kB` `11.123 kB`
`react-button` MenuButton	`39.543 kB` `10.807 kB`
`react-button` SplitButton	`46.989 kB` `12.192 kB`
`react-button` ToggleButton	`52.716 kB` `11.381 kB`
`react-card` CardFooter	`8.607 kB` `3.622 kB`
`react-card` CardHeader	`9.65 kB` `3.962 kB`
`react-card` CardPreview	`8.708 kB` `3.678 kB`
`react-combobox` Combobox (including child components)	`75.85 kB` `24.632 kB`
`react-combobox` Dropdown (including child components)	`75.579 kB` `24.594 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.94 kB` `17.663 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.446 kB` `11.033 kB`
`react-divider` Divider	`16.505 kB` `5.925 kB`
`react-image` Image	`10.826 kB` `4.286 kB`
`react-infobutton` InfoButton	`7.742 kB` `3.265 kB`
`react-input` Input	`24.428 kB` `7.899 kB`
`react-label` Label	`9.384 kB` `3.883 kB`
`react-link` Link	`11.852 kB` `4.888 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`53.992 kB` `15.25 kB`
`react-portal` Portal	`10.628 kB` `3.899 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.724 kB` `7.415 kB`
`react-progress` Progress	`12.789 kB` `4.927 kB`
`react-provider` FluentProvider	`15.807 kB` `5.909 kB`
`react-radio` Radio	`36.436 kB` `12.126 kB`
`react-radio` RadioGroup	`14.294 kB` `5.723 kB`
`react-select` Select	`21.61 kB` `7.568 kB`
`react-slider` Slider	`31.805 kB` `10.085 kB`
`react-spinbutton` SpinButton	`45.541 kB` `12.758 kB`
`react-spinner` Spinner	`20.023 kB` `6.461 kB`
`react-switch` Switch	`33.388 kB` `10.578 kB`
`react-text` Text - Default	`11.828 kB` `4.627 kB`
`react-text` Text - Wrappers	`15.138 kB` `5.064 kB`
`react-textarea` Textarea	`25.687 kB` `8.331 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.718 kB` `14.687 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 1646df5bed79e92a516b605ec9cbc705b11b5940}

fabricteam · 2022-10-19T13:51:56Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1290	1265	5000
Button	mount	955	948	5000
FluentProvider	mount	1571	1548	5000
FluentProviderWithTheme	mount	623	625	10
FluentProviderWithTheme	virtual-rerender	585	600	10
FluentProviderWithTheme	virtual-rerender-with-unmount	628	623	10
MakeStyles	mount	1908	1891	50000
SpinButton	mount	2530	2516	5000

fabricteam · 2022-10-19T14:03:36Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
RefMinimalPerf.default	192	177	1.08:1
ButtonMinimalPerf.default	134	127	1.06:1
ChatDuplicateMessagesPerf.default	224	211	1.06:1
ButtonSlotsPerf.default	474	453	1.05:1
ChatWithPopoverPerf.default	307	294	1.04:1
PortalMinimalPerf.default	142	137	1.04:1
ChatMinimalPerf.default	604	589	1.03:1
FlexMinimalPerf.default	237	231	1.03:1
LayoutMinimalPerf.default	296	287	1.03:1
LoaderMinimalPerf.default	565	551	1.03:1
PopupMinimalPerf.default	532	516	1.03:1
ReactionMinimalPerf.default	307	298	1.03:1
AlertMinimalPerf.default	225	221	1.02:1
AnimationMinimalPerf.default	447	437	1.02:1
DividerMinimalPerf.default	297	291	1.02:1
ProviderMinimalPerf.default	336	330	1.02:1
RadioGroupMinimalPerf.default	372	365	1.02:1
TableMinimalPerf.default	330	324	1.02:1
AttachmentSlotsPerf.default	928	918	1.01:1
DialogMinimalPerf.default	645	637	1.01:1
DropdownManyItemsPerf.default	546	543	1.01:1
HeaderMinimalPerf.default	295	291	1.01:1
MenuMinimalPerf.default	698	689	1.01:1
SegmentMinimalPerf.default	279	277	1.01:1
CustomToolbarPrototype.default	2237	2221	1.01:1
ButtonOverridesMissPerf.default	1103	1100	1:1
CarouselMinimalPerf.default	372	372	1:1
CheckboxMinimalPerf.default	1723	1718	1:1
DropdownMinimalPerf.default	2249	2242	1:1
GridMinimalPerf.default	271	272	1:1
ItemLayoutMinimalPerf.default	963	965	1:1
LabelMinimalPerf.default	307	307	1:1
ListCommonPerf.default	507	508	1:1
ListMinimalPerf.default	415	415	1:1
ListNestedPerf.default	456	454	1:1
ListWith60ListItems.default	505	505	1:1
MenuButtonMinimalPerf.default	1415	1411	1:1
ProviderMergeThemesPerf.default	1059	1061	1:1
SplitButtonMinimalPerf.default	3625	3639	1:1
StatusMinimalPerf.default	564	562	1:1
TableManyItemsPerf.default	1541	1547	1:1
ToolbarMinimalPerf.default	749	750	1:1
VideoMinimalPerf.default	603	601	1:1
AvatarMinimalPerf.default	153	154	0.99:1
EmbedMinimalPerf.default	3021	3057	0.99:1
HeaderSlotsPerf.default	624	628	0.99:1
InputMinimalPerf.default	932	944	0.99:1
RosterPerf.default	1751	1764	0.99:1
SliderMinimalPerf.default	1332	1349	0.99:1
TreeMinimalPerf.default	655	661	0.99:1
TreeWith60ListItems.default	127	128	0.99:1
AttachmentMinimalPerf.default	119	121	0.98:1
BoxMinimalPerf.default	274	279	0.98:1
CardMinimalPerf.default	424	431	0.98:1
DatepickerMinimalPerf.default	4678	4756	0.98:1
TextMinimalPerf.default	276	283	0.98:1
TextAreaMinimalPerf.default	384	392	0.98:1
TooltipMinimalPerf.default	1920	1954	0.98:1
ImageMinimalPerf.default	312	322	0.97:1
FormMinimalPerf.default	299	312	0.96:1
SkeletonMinimalPerf.default	267	277	0.96:1
IconMinimalPerf.default	512	552	0.93:1
AccordionMinimalPerf.default	110	124	0.89:1

size-auditor · 2022-10-19T14:06:18Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1646df5bed79e92a516b605ec9cbc705b11b5940 (build)

fabricteam · 2022-10-19T14:16:52Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1182	1177	5000
Breadcrumb	mount	2951	2958	1000
Checkbox	mount	2658	2645	5000
CheckboxBase	mount	2355	2348	5000
ChoiceGroup	mount	4363	4399	5000
ComboBox	mount	1230	1222	1000
CommandBar	mount	9576	9636	1000
ContextualMenu	mount	11394	11254	1000
DefaultButton	mount	1379	1359	5000
DetailsRow	mount	3652	3648	5000
DetailsRowFast	mount	3563	3591	5000
DetailsRowNoStyles	mount	3425	3456	5000
Dialog	mount	3062	3083	1000
DocumentCardTitle	mount	575	573	1000
Dropdown	mount	3208	3213	5000
FocusTrapZone	mount	2036	1981	5000
FocusZone	mount	1989	1965	5000
GroupedList	mount	52718	59384	2
GroupedList	virtual-rerender	25210	25095	2
GroupedList	virtual-rerender-with-unmount	93350	94614	2
GroupedListV2	mount	562	571	2
GroupedListV2	virtual-rerender	528	524	2
GroupedListV2	virtual-rerender-with-unmount	559	564	2
IconButton	mount	1935	1882	5000
Label	mount	736	744	5000
Layer	mount	4244	4241	5000
Link	mount	837	835	5000
MenuButton	mount	1674	1668	5000
MessageBar	mount	2312	2343	5000
Nav	mount	3265	3242	1000
OverflowSet	mount	1362	1353	5000
Panel	mount	2490	2510	1000
Persona	mount	1251	1265	1000
Pivot	mount	1657	1627	1000
PrimaryButton	mount	1518	1512	5000
Rating	mount	7005	6948	5000
SearchBox	mount	1499	1517	5000
Shimmer	mount	2867	2879	5000
Slider	mount	2102	2071	5000
SpinButton	mount	4648	4642	5000
Spinner	mount	790	812	5000
SplitButton	mount	3088	3065	5000
Stack	mount	861	858	5000
StackWithIntrinsicChildren	mount	2356	2379	5000
StackWithTextChildren	mount	4778	4804	5000
SwatchColorPicker	mount	10438	10531	5000
TagPicker	mount	2612	2574	5000
TeachingBubble	mount	88330	88476	5000
Text	mount	778	783	5000
TextField	mount	1583	1602	5000
ThemeProvider	mount	1524	1501	5000
ThemeProvider	virtual-rerender	1074	1081	5000
ThemeProvider	virtual-rerender-with-unmount	2157	2148	5000
Toggle	mount	1119	1105	5000
buttonNative	mount	550	530	5000

* feat: Bump tabster to 3.0.4 Bumps tabster to 3.0.4 and updates the guidance for `Table` keyboard navigation to use `useArrowNavigationGroup` * update multiselect stories * changefile * update subtle selection stories * update subtle selection story

feat: Bump tabster to 3.0.4

3e3d9e7

Bumps tabster to 3.0.4 and updates the guidance for `Table` keyboard navigation to use `useArrowNavigationGroup`

ling1726 requested review from a team as code owners October 19, 2022 13:34

msft-fluent-ui-bot assigned GeoffCoxMSFT Oct 19, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 19, 2022

update multiselect stories

681b3df

changefile

aadc9f5

ling1726 closed this Oct 19, 2022

ling1726 reopened this Oct 19, 2022

Hotell approved these changes Oct 19, 2022

View reviewed changes

ling1726 added 3 commits October 19, 2022 20:28

merge master

fa94eff

update subtle selection stories

1756ed7

update subtle selection story

748234e

ling1726 closed this Oct 20, 2022

ling1726 reopened this Oct 20, 2022

bsunderhus approved these changes Oct 20, 2022

View reviewed changes

bsunderhus assigned ling1726 and unassigned GeoffCoxMSFT Oct 20, 2022

ling1726 merged commit 433209a into microsoft:master Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Bump tabster to 3.0.4#25294

feat: Bump tabster to 3.0.4#25294
ling1726 merged 6 commits intomicrosoft:masterfrom
ling1726:feat/bump-tabster-3.0.4

ling1726 commented Oct 19, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Oct 19, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 19, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 19, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 19, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Oct 19, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 19, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ling1726 commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

size-auditor bot commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ling1726 commented Oct 19, 2022 •

edited

Loading

codesandbox-ci bot commented Oct 19, 2022 •

edited

Loading

fabricteam commented Oct 19, 2022 •

edited

Loading

fabricteam commented Oct 19, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Oct 19, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

size-auditor bot commented Oct 19, 2022 •

edited

Loading

fabricteam commented Oct 19, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)