fix(Mover): Fixing Mover grid behaviour and adding tests for it.#196
Merged
fix(Mover): Fixing Mover grid behaviour and adding tests for it.#196
Conversation
…d the next element is not visually to the Left/Right from the current one.
ling1726
previously approved these changes
Oct 12, 2022
ling1726
reviewed
Oct 12, 2022
Comment on lines
+630
to
+639
| function getDistance( | ||
| ax1: number, | ||
| ay1: number, | ||
| ax2: number, | ||
| ay2: number, | ||
| bx1: number, | ||
| by1: number, | ||
| bx2: number, | ||
| by2: number | ||
| ): number { |
Contributor
There was a problem hiding this comment.
I would suggest a nicer form for this
getDistance({x1, y1, x2, y2}, {x1, y1, x2, y2})…ed on an item in last/first row.
ling1726
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm to calculate vertically next element in grid was insufficient. Replacing it with a better working one and adding tests.