docs: improve Toolbar docs examples#25269
Merged
chpalac merged 5 commits intomicrosoft:masterfrom Oct 25, 2022
Merged
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 636cca4:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9dd5a3b5f20bb1a1fe2c4961c262201a691f460d (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1271 | 1288 | 5000 | |
| Button | mount | 924 | 936 | 5000 | |
| FluentProvider | mount | 1485 | 1487 | 5000 | |
| FluentProviderWithTheme | mount | 581 | 586 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 538 | 547 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 558 | 584 | 10 | |
| MakeStyles | mount | 1960 | 1958 | 50000 | |
| SpinButton | mount | 2332 | 2371 | 5000 |
bsunderhus
approved these changes
Oct 19, 2022
Contributor
bsunderhus
left a comment
There was a problem hiding this comment.
Would be nice to also add some description to every one of those stories
Contributor
|
There is no ToolbarMenuItem 🙈
We plan to introduce radios, so this guidance doesn't really make sense since we don't want users to apply roles unless necessary
Does this happen with the v9 menu ? |
Contributor
Author
…ocs/improve-docs-toolbar
Contributor
Does it? you're not using any |
Contributor
Author
Contributor
Author
|
@ling1726 if no other comments, good to merge? |
ling1726
approved these changes
Oct 25, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 25, 2022
* master: (106 commits) fix: PopoverTriggerChildProps should be exported (microsoft#25159) feat: replace ToolbarRadio implementation by usage of toggle button as Radio (microsoft#25343) docs: improve Toolbar docs examples (microsoft#25269) feat(tools): add unstable API setup updates (microsoft#25355) applying package updates Fix wrong narration when legend selected (microsoft#24903) applying package updates chore(react-persona): Update beachball settings and change file's type (microsoft#25363) chore: Refactor Field VR tests to have individual tests per component (microsoft#25263) chore(react-persona, react-components, vr-tests-v9): Reverting react-persona's version to beta (microsoft#25357) Publishing migration package (microsoft#25354) fix: Detailslist is still tabbable when isHeaderVisible=false (microsoft#25342) fix: list even/odd off-by-one issue (microsoft#25358) feat: add Dropdown a11y spec (microsoft#24917) spinbutton: update internal padding for small size (microsoft#25286) chore(global-context): migrate to new package structure (microsoft#25341) feat: Add validationState to Progress, to make the bar red or green (microsoft#25253) feat: Add accessibility scenarios for Fluent UI v9 components #3 (microsoft#23334) feat(Dropdown): Freeform search should be case insensitive (microsoft#24879) feat(what-input): Limit keyboard detection in inputs (microsoft#25087) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* docs: improve Toolbar docs examples * chore: remove best practices * chore: changes * chore: remove docs about menu focus in toolbar practices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix: #25156
Improve current stories for
Toolbar, making more realistic examples.