Skip to content

fix(script): allow runPublished call from CLI#25127

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts-monorepo-fix-2
Oct 7, 2022
Merged

fix(script): allow runPublished call from CLI#25127
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts-monorepo-fix-2

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 7, 2022 •
edited
Loading

Current Behavior

  • release pipeline fails because bad logic of caller site

New Behavior

  • release pipeline works

Related Issue(s)

Follows #25095

@Hotell Hotell added the CI label Oct 7, 2022
@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 7, 2022
@Hotell Hotell marked this pull request as ready for review October 7, 2022 08:28
@Hotell Hotell requested a review from a team as a code owner October 7, 2022 08:28
@Hotell Hotell enabled auto-merge (squash) October 7, 2022 08:37
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9573bf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 7, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1313 1312 5000
Button mount 937 953 5000
FluentProvider mount 1606 1572 5000
FluentProviderWithTheme mount 631 635 10
FluentProviderWithTheme virtual-rerender 591 593 10
FluentProviderWithTheme virtual-rerender-with-unmount 626 621 10
MakeStyles mount 1883 1895 50000
SpinButton mount 2494 2479 5000

@size-auditor
Copy link

size-auditor bot commented Oct 7, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 41c30da2fdb58551d5ec3ce2450ccab5d2d49969 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 7, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 79.037 kB
24.059 kB
react-alert
Alert		 84.529 kB
21.171 kB
react-avatar
Avatar		 48.828 kB
13.842 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.796 kB
19.182 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.49 kB
7.489 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.69 kB
9.818 kB
react-button
CompoundButton		 43.715 kB
11.036 kB
react-button
MenuButton		 39.384 kB
10.72 kB
react-button
SplitButton		 46.83 kB
12.102 kB
react-button
ToggleButton		 52.557 kB
11.29 kB
react-card
Card - All		 67.17 kB
19.281 kB
react-card
Card		 62.852 kB
18.198 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 75.071 kB
24.394 kB
react-combobox
Dropdown (including child components)		 74.799 kB
24.352 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 62.781 kB
17.574 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.227 kB
52.474 kB
react-components
react-components: FluentProvider & webLightTheme		 33.4 kB
11.008 kB
react-dialog
Dialog (including children components)		 82.465 kB
24.447 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-infobutton
InfoButton		 7.696 kB
3.241 kB
react-input
Input		 23.762 kB
7.706 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.806 kB
4.868 kB
react-menu
Menu (including children components)		 116.558 kB
35.725 kB
react-menu
Menu (including selectable components)		 119.627 kB
36.246 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-persona
Persona		 53.946 kB
15.225 kB
react-popover
Popover		 102.756 kB
31.5 kB
react-portal
Portal		 10.582 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-progress
Progress		 11.302 kB
4.549 kB
react-provider
FluentProvider		 15.761 kB
5.885 kB
react-radio
Radio		 36.39 kB
12.103 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.759 kB
10.064 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 33.342 kB
10.557 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.018 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.566 kB
14.644 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 41c30da2fdb58551d5ec3ce2450ccab5d2d49969

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 7, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 125 107 1.17:1
RefMinimalPerf.default 185 173 1.07:1
AvatarMinimalPerf.default 157 148 1.06:1
FlexMinimalPerf.default 243 230 1.06:1
ListWith60ListItems.default 512 484 1.06:1
TextMinimalPerf.default 288 272 1.06:1
LabelMinimalPerf.default 324 308 1.05:1
AttachmentMinimalPerf.default 118 113 1.04:1
GridMinimalPerf.default 280 273 1.03:1
SegmentMinimalPerf.default 286 277 1.03:1
ToolbarMinimalPerf.default 775 752 1.03:1
AnimationMinimalPerf.default 442 435 1.02:1
CarouselMinimalPerf.default 382 375 1.02:1
ChatDuplicateMessagesPerf.default 224 220 1.02:1
ItemLayoutMinimalPerf.default 979 962 1.02:1
MenuButtonMinimalPerf.default 1417 1390 1.02:1
RosterPerf.default 1776 1743 1.02:1
StatusMinimalPerf.default 556 546 1.02:1
TreeWith60ListItems.default 132 130 1.02:1
VideoMinimalPerf.default 612 598 1.02:1
AttachmentSlotsPerf.default 930 922 1.01:1
ButtonOverridesMissPerf.default 1094 1085 1.01:1
DialogMinimalPerf.default 639 631 1.01:1
DropdownMinimalPerf.default 2255 2233 1.01:1
EmbedMinimalPerf.default 3064 3039 1.01:1
HeaderSlotsPerf.default 627 619 1.01:1
ImageMinimalPerf.default 320 318 1.01:1
LayoutMinimalPerf.default 286 282 1.01:1
LoaderMinimalPerf.default 561 555 1.01:1
PortalMinimalPerf.default 135 134 1.01:1
ProviderMinimalPerf.default 334 332 1.01:1
RadioGroupMinimalPerf.default 355 351 1.01:1
AlertMinimalPerf.default 214 214 1:1
BoxMinimalPerf.default 273 274 1:1
CardMinimalPerf.default 441 442 1:1
ChatMinimalPerf.default 594 596 1:1
CheckboxMinimalPerf.default 1721 1723 1:1
DatepickerMinimalPerf.default 4739 4756 1:1
InputMinimalPerf.default 948 947 1:1
ListMinimalPerf.default 419 417 1:1
PopupMinimalPerf.default 519 517 1:1
ProviderMergeThemesPerf.default 1058 1057 1:1
ReactionMinimalPerf.default 305 305 1:1
TableManyItemsPerf.default 1560 1555 1:1
TableMinimalPerf.default 321 322 1:1
TreeMinimalPerf.default 655 656 1:1
ButtonSlotsPerf.default 454 458 0.99:1
ChatWithPopoverPerf.default 311 314 0.99:1
DropdownManyItemsPerf.default 539 544 0.99:1
HeaderMinimalPerf.default 288 290 0.99:1
MenuMinimalPerf.default 687 692 0.99:1
SkeletonMinimalPerf.default 273 277 0.99:1
SplitButtonMinimalPerf.default 3631 3678 0.99:1
TextAreaMinimalPerf.default 383 386 0.99:1
CustomToolbarPrototype.default 2198 2214 0.99:1
TooltipMinimalPerf.default 1895 1906 0.99:1
DividerMinimalPerf.default 275 280 0.98:1
FormMinimalPerf.default 298 303 0.98:1
ListNestedPerf.default 442 449 0.98:1
SliderMinimalPerf.default 1316 1353 0.97:1
ListCommonPerf.default 497 516 0.96:1
IconMinimalPerf.default 535 555 0.96:1
ButtonMinimalPerf.default 120 127 0.94:1

@ling1726 ling1726 closed this Oct 7, 2022
auto-merge was automatically disabled October 7, 2022 08:59

Pull request was closed

@ling1726 ling1726 reopened this Oct 7, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 7, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1181 1203 5000
Breadcrumb mount 2910 2955 1000
Checkbox mount 2657 2696 5000
CheckboxBase mount 2375 2367 5000
ChoiceGroup mount 4396 4375 5000
ComboBox mount 1255 1242 1000
CommandBar mount 9650 9643 1000
ContextualMenu mount 11502 11484 1000
DefaultButton mount 1368 1383 5000
DetailsRow mount 3619 3599 5000
DetailsRowFast mount 3618 3617 5000
DetailsRowNoStyles mount 3466 3492 5000
Dialog mount 3098 3091 1000
DocumentCardTitle mount 577 578 1000
Dropdown mount 3205 3186 5000
FocusTrapZone mount 2024 1998 5000
FocusZone mount 1990 1985 5000
GroupedList mount 54124 60643 2
GroupedList virtual-rerender 25520 25316 2
GroupedList virtual-rerender-with-unmount 93783 94433 2
GroupedListV2 mount 561 573 2
GroupedListV2 virtual-rerender 524 527 2
GroupedListV2 virtual-rerender-with-unmount 555 556 2
IconButton mount 1929 1908 5000
Label mount 723 726 5000
Layer mount 4232 4319 5000
Link mount 837 832 5000
MenuButton mount 1697 1648 5000
MessageBar mount 2316 2346 5000
Nav mount 3275 3288 1000
OverflowSet mount 1345 1368 5000
Panel mount 2579 2532 1000
Persona mount 1270 1287 1000
Pivot mount 1639 1636 1000
PrimaryButton mount 1512 1530 5000
Rating mount 7018 7053 5000
SearchBox mount 1495 1504 5000
Shimmer mount 2877 2869 5000
Slider mount 2077 2102 5000
SpinButton mount 4714 4680 5000
Spinner mount 804 797 5000
SplitButton mount 3103 3098 5000
Stack mount 862 857 5000
StackWithIntrinsicChildren mount 2348 2361 5000
StackWithTextChildren mount 4824 4771 5000
SwatchColorPicker mount 10570 10518 5000
TagPicker mount 2654 2609 5000
TeachingBubble mount 90461 89786 5000
Text mount 801 786 5000
TextField mount 1592 1573 5000
ThemeProvider mount 1524 1530 5000
ThemeProvider virtual-rerender 1088 1079 5000
ThemeProvider virtual-rerender-with-unmount 2162 2159 5000
Toggle mount 1120 1101 5000
buttonNative mount 531 539 5000

@Hotell Hotell enabled auto-merge (squash) October 7, 2022 09:28
@Hotell Hotell merged commit c917857 into microsoft:master Oct 7, 2022
@Hotell Hotell deleted the hotell/build/scripts-monorepo-fix-2 branch October 10, 2022 11:29
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 10, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
f4485d2 
* master: (23 commits)
  Revert "chore: screener-run workflow should report to PR (microsoft#25144)" (microsoft#25145)
  chore: screener-run workflow should report to PR (microsoft#25144)
  applying package updates
  fix: The Tooltip should not hide if it gets keyboard focus (microsoft#25138)
  fix: Tooltip should not hide if an element inside it gets focused (microsoft#25140)
  Create react-migration-v8-v9 with shims and stories (microsoft#25121)
  fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor (microsoft#25079)
  feat: Overflow menu should be registered in overflowManager (microsoft#25091)
  fix: version-bump generator removes beachball disallowedChangeType config (microsoft#25130)
  fix: new overflow items should only be enqueued while observing (microsoft#25122)
  fix(script): allow runPublished call from CLI (microsoft#25127)
  feat: add vertical variation for toolbar (microsoft#24940)
  ProgressField implementation and stories (microsoft#25103)
  fix: Dropdown icon layout with no placeholder/value (microsoft#25049)
  chore: add a bundle size fixture (Button, Provider & theme) (microsoft#25113)
  feat: Adding subtle transition between states on Button components (microsoft#25106)
  Revert "chore: screener-run workflow should report to PR (microsoft#25096)" (microsoft#25115)
  chore: screener-run workflow should report to PR (microsoft#25096)
  fix(react-dialog): aria-* properties should be reassignable (microsoft#25092)
  fix(scripts): don't run publish if web-components are affected (microsoft#25095)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@Hotell @NotWoods
fix(script): allow runPublished call from CLI (microsoft#25127)
fc27c8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System CI

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

5 participants

@Hotell @fabricteam @ling1726 @miroslavstastny @msft-fluent-ui-bot