chore: screener-run workflow should report to PR by ling1726 · Pull Request #25096 · microsoft/fluentui

ling1726 · 2022-10-05T16:04:23Z

Adds the action-workflow_run action to automatically associate the screener-run workflow with the commit of the workflow that triggered it. This should result in the jobs showing up in PR status

Adds the [action-workflow_run action](https://github.com/marketplace/actions/workflow_run-status) to automatically associate the screener-run workflow with the commit of the workflow that triggered it. This should result in the jobs showing up in PR status

codesandbox-ci · 2022-10-05T16:28:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 094735f:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-10-05T16:29:23Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2484ba157b11028249ebd3b091ed4808ff7497e3 (build)

fabricteam · 2022-10-05T16:32:36Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1317	1326	5000
Button	mount	942	970	5000
FluentProvider	mount	1595	1566	5000
FluentProviderWithTheme	mount	630	639	10
FluentProviderWithTheme	virtual-rerender	591	590	10
FluentProviderWithTheme	virtual-rerender-with-unmount	626	634	10
MakeStyles	mount	1958	1933	50000
SpinButton	mount	2558	2532	5000

fabricteam · 2022-10-05T16:37:02Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`79.037 kB` `24.059 kB`
`react-alert` Alert	`84.117 kB` `21.07 kB`
`react-avatar` Avatar	`48.828 kB` `13.842 kB`
`react-avatar` AvatarGroup	`14.95 kB` `5.989 kB`
`react-avatar` AvatarGroupItem	`68.796 kB` `19.182 kB`
`react-badge` Badge	`22.6 kB` `7.205 kB`
`react-badge` CounterBadge	`23.49 kB` `7.489 kB`
`react-badge` PresenceBadge	`24.05 kB` `7.067 kB`
`react-button` Button	`36.278 kB` `9.636 kB`
`react-button` CompoundButton	`43.303 kB` `10.852 kB`
`react-button` MenuButton	`38.972 kB` `10.536 kB`
`react-button` SplitButton	`46.418 kB` `11.916 kB`
`react-button` ToggleButton	`52.145 kB` `11.108 kB`
`react-card` Card - All	`67.17 kB` `19.281 kB`
`react-card` Card	`62.852 kB` `18.198 kB`
`react-card` CardFooter	`8.561 kB` `3.601 kB`
`react-card` CardHeader	`9.604 kB` `3.94 kB`
`react-card` CardPreview	`8.662 kB` `3.656 kB`
`react-combobox` Combobox (including child components)	`75.071 kB` `24.394 kB`
`react-combobox` Dropdown (including child components)	`74.667 kB` `24.281 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`188.815 kB` `52.287 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.4 kB` `11.008 kB`
`react-dialog` Dialog (including children components)	`82.465 kB` `24.447 kB`
`react-divider` Divider	`16.459 kB` `5.902 kB`
`react-image` Image	`10.78 kB` `4.264 kB`
`react-infobutton` InfoButton	`7.696 kB` `3.241 kB`
`react-input` Input	`23.762 kB` `7.706 kB`
`react-label` Label	`9.338 kB` `3.86 kB`
`react-link` Link	`11.806 kB` `4.868 kB`
`react-menu` Menu (including children components)	`116.558 kB` `35.725 kB`
`react-menu` Menu (including selectable components)	`119.627 kB` `36.246 kB`
`react-overflow` hooks only	`10.685 kB` `4.104 kB`
`react-persona` Persona	`53.946 kB` `15.225 kB`
`react-popover` Popover	`102.756 kB` `31.5 kB`
`react-portal` Portal	`10.582 kB` `3.875 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.7 kB` `7.404 kB`
`react-progress` Progress	`11.25 kB` `4.514 kB`
`react-provider` FluentProvider	`15.761 kB` `5.885 kB`
`react-radio` Radio	`36.39 kB` `12.103 kB`
`react-radio` RadioGroup	`14.248 kB` `5.7 kB`
`react-select` Select	`20.846 kB` `7.346 kB`
`react-slider` Slider	`31.759 kB` `10.064 kB`
`react-spinbutton` SpinButton	`44.102 kB` `12.425 kB`
`react-spinner` Spinner	`19.977 kB` `6.438 kB`
`react-switch` Switch	`33.342 kB` `10.557 kB`
`react-text` Text - Default	`11.782 kB` `4.605 kB`
`react-text` Text - Wrappers	`15.092 kB` `5.044 kB`
`react-textarea` Textarea	`25.018 kB` `8.133 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.566 kB` `14.644 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 2484ba157b11028249ebd3b091ed4808ff7497e3}

fabricteam · 2022-10-05T16:37:28Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	176	157	1.12:1
ReactionMinimalPerf.default	412	368	1.12:1
BoxMinimalPerf.default	357	322	1.11:1
AttachmentSlotsPerf.default	1197	1103	1.09:1
TextAreaMinimalPerf.default	518	477	1.09:1
AvatarMinimalPerf.default	195	181	1.08:1
TooltipMinimalPerf.default	2491	2337	1.07:1
CardMinimalPerf.default	574	544	1.06:1
IconMinimalPerf.default	679	640	1.06:1
CarouselMinimalPerf.default	480	456	1.05:1
ChatDuplicateMessagesPerf.default	291	277	1.05:1
ListMinimalPerf.default	521	506	1.03:1
RadioGroupMinimalPerf.default	440	429	1.03:1
TableManyItemsPerf.default	1991	1934	1.03:1
DialogMinimalPerf.default	786	770	1.02:1
ListWith60ListItems.default	651	638	1.02:1
RosterPerf.default	2349	2300	1.02:1
ProviderMergeThemesPerf.default	1342	1313	1.02:1
ButtonSlotsPerf.default	576	570	1.01:1
HeaderSlotsPerf.default	783	775	1.01:1
SkeletonMinimalPerf.default	357	352	1.01:1
TableMinimalPerf.default	417	414	1.01:1
AlertMinimalPerf.default	268	268	1:1
ButtonOverridesMissPerf.default	1380	1376	1:1
ChatWithPopoverPerf.default	373	373	1:1
EmbedMinimalPerf.default	3836	3822	1:1
ImageMinimalPerf.default	407	407	1:1
InputMinimalPerf.default	1151	1151	1:1
MenuMinimalPerf.default	870	868	1:1
PortalMinimalPerf.default	173	173	1:1
TextMinimalPerf.default	340	340	1:1
AnimationMinimalPerf.default	538	546	0.99:1
DropdownMinimalPerf.default	2824	2866	0.99:1
LayoutMinimalPerf.default	375	377	0.99:1
LoaderMinimalPerf.default	688	695	0.99:1
MenuButtonMinimalPerf.default	1762	1783	0.99:1
PopupMinimalPerf.default	650	655	0.99:1
SliderMinimalPerf.default	1684	1704	0.99:1
SplitButtonMinimalPerf.default	4528	4571	0.99:1
StatusMinimalPerf.default	701	710	0.99:1
CustomToolbarPrototype.default	2752	2783	0.99:1
TreeWith60ListItems.default	164	166	0.99:1
AccordionMinimalPerf.default	146	149	0.98:1
AttachmentMinimalPerf.default	147	151	0.97:1
CheckboxMinimalPerf.default	2132	2190	0.97:1
DatepickerMinimalPerf.default	6122	6280	0.97:1
DropdownManyItemsPerf.default	666	685	0.97:1
LabelMinimalPerf.default	379	391	0.97:1
VideoMinimalPerf.default	725	744	0.97:1
ChatMinimalPerf.default	740	769	0.96:1
DividerMinimalPerf.default	389	406	0.96:1
FormMinimalPerf.default	404	420	0.96:1
HeaderMinimalPerf.default	355	368	0.96:1
ItemLayoutMinimalPerf.default	1210	1259	0.96:1
ListNestedPerf.default	588	612	0.96:1
SegmentMinimalPerf.default	349	365	0.96:1
GridMinimalPerf.default	333	351	0.95:1
ProviderMinimalPerf.default	414	435	0.95:1
RefMinimalPerf.default	217	229	0.95:1
FlexMinimalPerf.default	287	304	0.94:1
ToolbarMinimalPerf.default	930	985	0.94:1
ListCommonPerf.default	635	685	0.93:1
TreeMinimalPerf.default	816	874	0.93:1

fabricteam · 2022-10-06T10:19:17Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
ThemeProvider	virtual-rerender-with-unmount	2151	2170	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1176	1189	5000
Breadcrumb	mount	2914	2931	1000
Checkbox	mount	2654	2689	5000
CheckboxBase	mount	2390	2379	5000
ChoiceGroup	mount	4412	4383	5000
ComboBox	mount	1234	1259	1000
CommandBar	mount	9565	9572	1000
ContextualMenu	mount	10994	11293	1000
DefaultButton	mount	1383	1385	5000
DetailsRow	mount	3639	3608	5000
DetailsRowFast	mount	3648	3617	5000
DetailsRowNoStyles	mount	3465	3404	5000
Dialog	mount	3077	3075	1000
DocumentCardTitle	mount	579	585	1000
Dropdown	mount	3205	3228	5000
FocusTrapZone	mount	2014	2041	5000
FocusZone	mount	1955	1974	5000
GroupedList	mount	52793	58509	2
GroupedList	virtual-rerender	24553	24851	2
GroupedList	virtual-rerender-with-unmount	93663	94884	2
GroupedListV2	mount	559	565	2
GroupedListV2	virtual-rerender	530	528	2
GroupedListV2	virtual-rerender-with-unmount	555	553	2
IconButton	mount	1928	1939	5000
Label	mount	732	731	5000
Layer	mount	4285	4229	5000
Link	mount	828	824	5000
MenuButton	mount	1662	1685	5000
MessageBar	mount	2329	2289	5000
Nav	mount	3269	3270	1000
OverflowSet	mount	1347	1388	5000
Panel	mount	2515	2538	1000
Persona	mount	1295	1286	1000
Pivot	mount	1672	1646	1000
PrimaryButton	mount	1523	1512	5000
Rating	mount	6963	6996	5000
SearchBox	mount	1506	1541	5000
Shimmer	mount	2866	2853	5000
Slider	mount	2095	2078	5000
SpinButton	mount	4717	4672	5000
Spinner	mount	800	794	5000
SplitButton	mount	3114	3097	5000
Stack	mount	870	871	5000
StackWithIntrinsicChildren	mount	2368	2373	5000
StackWithTextChildren	mount	4838	4812	5000
SwatchColorPicker	mount	10496	10526	5000
TagPicker	mount	2628	2633	5000
TeachingBubble	mount	86444	86437	5000
Text	mount	804	795	5000
TextField	mount	1588	1581	5000
ThemeProvider	mount	1538	1520	5000
ThemeProvider	virtual-rerender	1087	1087	5000
ThemeProvider	virtual-rerender-with-unmount	2151	2170	5000	Possible regression
Toggle	mount	1112	1094	5000
buttonNative	mount	541	539	5000

This reverts commit 139a706.

…25115) This reverts commit 139a706.

* master: (23 commits) Revert "chore: screener-run workflow should report to PR (microsoft#25144)" (microsoft#25145) chore: screener-run workflow should report to PR (microsoft#25144) applying package updates fix: The Tooltip should not hide if it gets keyboard focus (microsoft#25138) fix: Tooltip should not hide if an element inside it gets focused (microsoft#25140) Create react-migration-v8-v9 with shims and stories (microsoft#25121) fix: CheckboxField to set a generated ID on the input, to match the label's htmlFor (microsoft#25079) feat: Overflow menu should be registered in overflowManager (microsoft#25091) fix: version-bump generator removes beachball disallowedChangeType config (microsoft#25130) fix: new overflow items should only be enqueued while observing (microsoft#25122) fix(script): allow runPublished call from CLI (microsoft#25127) feat: add vertical variation for toolbar (microsoft#24940) ProgressField implementation and stories (microsoft#25103) fix: Dropdown icon layout with no placeholder/value (microsoft#25049) chore: add a bundle size fixture (Button, Provider & theme) (microsoft#25113) feat: Adding subtle transition between states on Button components (microsoft#25106) Revert "chore: screener-run workflow should report to PR (microsoft#25096)" (microsoft#25115) chore: screener-run workflow should report to PR (microsoft#25096) fix(react-dialog): aria-* properties should be reassignable (microsoft#25092) fix(scripts): don't run publish if web-components are affected (microsoft#25095) ...

Adds the [action-workflow_run action](https://github.com/marketplace/actions/workflow_run-status) to automatically associate the screener-run workflow with the commit of the workflow that triggered it. This should result in the jobs showing up in PR status

…5096)" (microsoft#25115) This reverts commit 139a706.

ling1726 requested a review from a team as a code owner October 5, 2022 16:04

Hotell approved these changes Oct 5, 2022

View reviewed changes

msft-fluent-ui-bot assigned miroslavstastny Oct 5, 2022

ling1726 closed this Oct 6, 2022

ling1726 reopened this Oct 6, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 6, 2022

ling1726 merged commit 139a706 into microsoft:master Oct 6, 2022

ling1726 added a commit that referenced this pull request Oct 6, 2022

Revert "chore: screener-run workflow should report to PR (#25096)"

c989c58

This reverts commit 139a706.

ling1726 mentioned this pull request Oct 6, 2022

Revert "chore: screener-run workflow should report to PR" #25115

Merged

layershifter pushed a commit that referenced this pull request Oct 6, 2022

Revert "chore: screener-run workflow should report to PR (#25096)" (#…

64fb621

…25115) This reverts commit 139a706.

ling1726 mentioned this pull request Oct 13, 2022

Associate screener-run workflow with the parent commit #25213

Closed

NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022

Revert "chore: screener-run workflow should report to PR (microsoft#2…

6b570d2

…5096)" (microsoft#25115) This reverts commit 139a706.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: screener-run workflow should report to PR#25096

chore: screener-run workflow should report to PR#25096
ling1726 merged 1 commit intomicrosoft:masterfrom
ling1726:chore/screener-run-workflow-status

ling1726 commented Oct 5, 2022

Uh oh!

codesandbox-ci bot commented Oct 5, 2022

Uh oh!

size-auditor bot commented Oct 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ling1726 commented Oct 5, 2022

Uh oh!

codesandbox-ci bot commented Oct 5, 2022

Uh oh!

size-auditor bot commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Oct 6, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

size-auditor bot commented Oct 5, 2022 •

edited

Loading

fabricteam commented Oct 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Oct 5, 2022 •

edited

Loading

fabricteam commented Oct 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)