chore(react-dialog): updates stories#25070
Merged
bsunderhus merged 3 commits intomicrosoft:masterfrom Oct 5, 2022
Merged
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c59b423:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5a3ac20a28f7ae34ac52e9d8cc4e9517cd369c06 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1581 | 1572 | 5000 | |
| Button | mount | 1083 | 1065 | 5000 | |
| FluentProvider | mount | 1818 | 1829 | 5000 | |
| FluentProviderWithTheme | mount | 668 | 700 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 624 | 630 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 677 | 671 | 10 | |
| MakeStyles | mount | 2122 | 2106 | 50000 | |
| SpinButton | mount | 2974 | 3009 | 5000 |
layershifter
approved these changes
Oct 4, 2022
change/@fluentui-react-dialog-bbb01d69-5227-40c3-aaf3-053f1af35f0d.json
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Oct 4, 2022
Comment on lines
+24
to
+29
| subcomponents: { | ||
| DialogTrigger, | ||
| DialogSurface, | ||
| DialogTitle, | ||
| DialogActions, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Yeah, I was amazed when I found out about this! 🤩
…5f0d.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 5, 2022
* master: (62 commits) chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458) chore(react-dialog): updates stories (microsoft#25070) refactor Progress to remove label and description slots (microsoft#25067) fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059) chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007) (docs): update Icon docs with examples (microsoft#24768) Split button/primary hc fix (microsoft#25066) chore(react-utilities): restricts trigger API types (microsoft#25044) Add utilities export @fluentui/style-utilities v8 (microsoft#25065) chore: migrate whole repo to webpack 5 (microsoft#24542) applying package updates BREAKING: refactor `useTable` to be composable (microsoft#24947) Added shims to shim packages (microsoft#25048) Add Progress SPEC (microsoft#24418) applying package updates chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055) fix(Button): Remove margin added to buttons by Safari (microsoft#25052) fix: Menu triggers no longer take focus when they are mounted (microsoft#25016) chore: deletes react-trigger package (microsoft#25042) Fixed a minor typo: immmediately => immediately (microsoft#25036) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore(react-dialog): updates stories * chore: updates API comments * Update change/@fluentui-react-dialog-bbb01d69-5227-40c3-aaf3-053f1af35f0d.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
DialogTitlestories withDialogstoriesno focusable elementscenarios about Talkback issue Accessibility: Talkback does not access content within a dialog that contains no interactive content #24471DialogOpenChangeEventHandlerinsideDialogProps