Skip to content

Fixed a minor typo: immmediately => immediately#25036

Merged
layershifter merged 1 commit intomicrosoft:masterfrom
tony-xia:minor-typo
Oct 3, 2022
Merged

Fixed a minor typo: immmediately => immediately#25036
layershifter merged 1 commit intomicrosoft:masterfrom
tony-xia:minor-typo

Conversation

@tony-xia
Copy link
Contributor

@tony-xia tony-xia commented Oct 1, 2022

Current Behavior

New Behavior

Related Issue(s)

Fixes #

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6ae0bc:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 1, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 79174e4d44832bed28251cde2fa1217509b2a3c2 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1638 1701 5000
Button mount 1172 1154 5000
FluentProvider mount 1926 1910 5000
FluentProviderWithTheme mount 729 732 10
FluentProviderWithTheme virtual-rerender 667 677 10
FluentProviderWithTheme virtual-rerender-with-unmount 720 716 10
MakeStyles mount 2315 2269 50000
SpinButton mount 3404 3354 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 79.037 kB
24.059 kB
react-alert
Alert		 84.117 kB
21.07 kB
react-avatar
Avatar		 48.828 kB
13.842 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.796 kB
19.182 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.49 kB
7.489 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.278 kB
9.636 kB
react-button
CompoundButton		 43.303 kB
10.852 kB
react-button
MenuButton		 38.972 kB
10.536 kB
react-button
SplitButton		 46.418 kB
11.916 kB
react-button
ToggleButton		 52.145 kB
11.108 kB
react-card
Card - All		 67.17 kB
19.281 kB
react-card
Card		 62.852 kB
18.198 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.642 kB
24.19 kB
react-combobox
Dropdown (including child components)		 74.242 kB
24.089 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.156 kB
52.385 kB
react-components
react-components: FluentProvider & webLightTheme		 33.4 kB
11.008 kB
react-dialog
Dialog (including children components)		 82.438 kB
24.444 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.762 kB
7.706 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.806 kB
4.868 kB
react-menu
Menu (including children components)		 116.718 kB
35.78 kB
react-menu
Menu (including selectable components)		 119.787 kB
36.289 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.929 kB
31.542 kB
react-portal
Portal		 10.582 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-progress
Progress		 13.44 kB
5.247 kB
react-provider
FluentProvider		 15.761 kB
5.885 kB
react-radio
Radio		 36.39 kB
12.103 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.759 kB
10.064 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 33.342 kB
10.557 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.018 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.541 kB
14.646 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 79174e4d44832bed28251cde2fa1217509b2a3c2

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 190 166 1.14:1
AttachmentMinimalPerf.default 171 155 1.1:1
ListCommonPerf.default 719 668 1.08:1
DropdownManyItemsPerf.default 789 737 1.07:1
PortalMinimalPerf.default 176 165 1.07:1
SegmentMinimalPerf.default 395 369 1.07:1
ButtonSlotsPerf.default 625 591 1.06:1
CardMinimalPerf.default 603 571 1.06:1
FlexMinimalPerf.default 315 296 1.06:1
ListMinimalPerf.default 580 549 1.06:1
ListNestedPerf.default 628 592 1.06:1
AttachmentSlotsPerf.default 1231 1167 1.05:1
BoxMinimalPerf.default 383 369 1.04:1
HeaderMinimalPerf.default 408 391 1.04:1
ProviderMinimalPerf.default 428 410 1.04:1
RefMinimalPerf.default 237 228 1.04:1
IconMinimalPerf.default 711 682 1.04:1
TableMinimalPerf.default 459 443 1.04:1
TextMinimalPerf.default 396 380 1.04:1
AccordionMinimalPerf.default 155 151 1.03:1
AnimationMinimalPerf.default 586 567 1.03:1
CarouselMinimalPerf.default 527 510 1.03:1
DialogMinimalPerf.default 853 827 1.03:1
ListWith60ListItems.default 665 644 1.03:1
PopupMinimalPerf.default 681 664 1.03:1
DatepickerMinimalPerf.default 6315 6192 1.02:1
GridMinimalPerf.default 389 381 1.02:1
LoaderMinimalPerf.default 723 709 1.02:1
RosterPerf.default 2403 2367 1.02:1
SkeletonMinimalPerf.default 395 386 1.02:1
SliderMinimalPerf.default 1722 1693 1.02:1
DropdownMinimalPerf.default 2846 2812 1.01:1
EmbedMinimalPerf.default 4001 3977 1.01:1
StatusMinimalPerf.default 751 741 1.01:1
CustomToolbarPrototype.default 2849 2832 1.01:1
ChatMinimalPerf.default 813 816 1:1
FormMinimalPerf.default 432 431 1:1
LabelMinimalPerf.default 435 435 1:1
LayoutMinimalPerf.default 403 405 1:1
MenuButtonMinimalPerf.default 1915 1909 1:1
ProviderMergeThemesPerf.default 1315 1317 1:1
SplitButtonMinimalPerf.default 4742 4734 1:1
TooltipMinimalPerf.default 2506 2501 1:1
VideoMinimalPerf.default 811 812 1:1
ButtonMinimalPerf.default 183 184 0.99:1
ImageMinimalPerf.default 431 435 0.99:1
InputMinimalPerf.default 1229 1247 0.99:1
ItemLayoutMinimalPerf.default 1286 1297 0.99:1
RadioGroupMinimalPerf.default 483 488 0.99:1
TableManyItemsPerf.default 2164 2187 0.99:1
TextAreaMinimalPerf.default 545 553 0.99:1
AvatarMinimalPerf.default 202 207 0.98:1
ButtonOverridesMissPerf.default 1431 1460 0.98:1
ChatWithPopoverPerf.default 416 426 0.98:1
HeaderSlotsPerf.default 831 848 0.98:1
MenuMinimalPerf.default 914 932 0.98:1
ToolbarMinimalPerf.default 1046 1071 0.98:1
TreeMinimalPerf.default 846 864 0.98:1
CheckboxMinimalPerf.default 2296 2362 0.97:1
ReactionMinimalPerf.default 413 427 0.97:1
ChatDuplicateMessagesPerf.default 277 291 0.95:1
AlertMinimalPerf.default 292 312 0.94:1
DividerMinimalPerf.default 388 427 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1473 1440 5000
Breadcrumb mount 3450 3451 1000
Checkbox mount 3120 3230 5000
CheckboxBase mount 2793 2830 5000
ChoiceGroup mount 5199 5294 5000
ComboBox mount 1522 1475 1000
CommandBar mount 11339 11398 1000
ContextualMenu mount 13225 12974 1000
DefaultButton mount 1640 1630 5000
DetailsRow mount 4290 4289 5000
DetailsRowFast mount 4327 4404 5000
DetailsRowNoStyles mount 4106 4169 5000
Dialog mount 3729 3725 1000
DocumentCardTitle mount 706 680 1000
Dropdown mount 3848 3925 5000
FocusTrapZone mount 2388 2427 5000
FocusZone mount 2411 2449 5000
GroupedList mount 63017 71109 2
GroupedList virtual-rerender 29353 29600 2
GroupedList virtual-rerender-with-unmount 113080 111937 2
GroupedListV2 mount 676 682 2
GroupedListV2 virtual-rerender 626 623 2
GroupedListV2 virtual-rerender-with-unmount 665 670 2
IconButton mount 2337 2248 5000
Label mount 864 900 5000
Layer mount 5154 5115 5000
Link mount 973 1049 5000
MenuButton mount 2073 2029 5000
MessageBar mount 2722 2800 5000
Nav mount 3932 3853 1000
OverflowSet mount 1603 1708 5000
Panel mount 3025 3135 1000
Persona mount 1518 1551 1000
Pivot mount 1933 1976 1000
PrimaryButton mount 1847 1796 5000
Rating mount 8364 8415 5000
SearchBox mount 1873 1831 5000
Shimmer mount 3347 3546 5000
Slider mount 2516 2549 5000
SpinButton mount 5915 5633 5000
Spinner mount 955 966 5000
SplitButton mount 3650 3714 5000
Stack mount 1041 1020 5000
StackWithIntrinsicChildren mount 2995 2906 5000
StackWithTextChildren mount 5790 5721 5000
SwatchColorPicker mount 12576 12734 5000
TagPicker mount 3138 3155 5000
TeachingBubble mount 102253 103406 5000
Text mount 945 913 5000
TextField mount 1930 1928 5000
ThemeProvider mount 1826 1815 5000
ThemeProvider virtual-rerender 1316 1271 5000
ThemeProvider virtual-rerender-with-unmount 2617 2574 5000
Toggle mount 1330 1320 5000
buttonNative mount 633 636 5000

@layershifter
Copy link
Member

layershifter commented Oct 3, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 3, 2022

Pull request is closed

@layershifter layershifter reopened this Oct 3, 2022
@layershifter layershifter reopened this Oct 3, 2022
@layershifter layershifter merged commit 192e997 into microsoft:master Oct 3, 2022
GeoffCoxMSFT pushed a commit to GeoffCoxMSFT/fluentui that referenced this pull request Oct 3, 2022
@tony-xia @GeoffCoxMSFT
Fixed a minor typo: immmediately => immediately (microsoft#25036)
2e2c0c0
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 5, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
3e5d385 
* master: (62 commits)
  chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks (microsoft#24458)
  chore(react-dialog): updates stories (microsoft#25070)
  refactor Progress to remove label and description slots (microsoft#25067)
  fix(SplitButton): Remove borders from hover and pressed state in primary split buttons (microsoft#25059)
  chore(react-persona): Add vr, conformance, and unit tests (microsoft#25007)
  (docs): update Icon docs with examples (microsoft#24768)
  Split button/primary hc fix (microsoft#25066)
  chore(react-utilities): restricts trigger API types (microsoft#25044)
  Add utilities export @fluentui/style-utilities v8 (microsoft#25065)
  chore: migrate whole repo to webpack 5 (microsoft#24542)
  applying package updates
  BREAKING: refactor `useTable` to be composable (microsoft#24947)
  Added shims to shim packages (microsoft#25048)
  Add Progress SPEC (microsoft#24418)
  applying package updates
  chore(react-persona): Add bundle-size command for bundle-size fixtures (microsoft#25055)
  fix(Button): Remove margin added to buttons by Safari (microsoft#25052)
  fix: Menu triggers no longer take focus when they are mounted (microsoft#25016)
  chore: deletes react-trigger package (microsoft#25042)
  Fixed a minor typo: immmediately => immediately (microsoft#25036)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@tony-xia @NotWoods
Fixed a minor typo: immmediately => immediately (microsoft#25036)
d6d6bc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

@tomi-msft tomi-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tony-xia @fabricteam @layershifter @tomi-msft