stress test: convert cli scripts to typescript#24915
Merged
spmonahan merged 1 commit intomicrosoft:masterfrom Sep 22, 2022
Merged
stress test: convert cli scripts to typescript#24915spmonahan merged 1 commit intomicrosoft:masterfrom
spmonahan merged 1 commit intomicrosoft:masterfrom
Conversation
This change gives us better type checking (scripts are now covered by the `type-check` command) while also allowing interop with the source code. For example, we can add a command to generate fixtures from the `RandomTree` class. This was not possible when the scripts were written in JS as the source code is otherwise in Typescript.
Collaborator
📊 Bundle size report🤖 This report was generated against 3f105cca41d951f161edbb90be116565311e72d1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d146b0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3f105cca41d951f161edbb90be116565311e72d1 (build) |
behowell
approved these changes
Sep 22, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
This change gives us better type checking (scripts are now covered by the `type-check` command) while also allowing interop with the source code. For example, we can add a command to generate fixtures from the `RandomTree` class. This was not possible when the scripts were written in JS as the source code is otherwise in Typescript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Stress Test CLI scripts are written in JS with JSDoc type annotations. While this mostly works there is a fair bit of friction compared to using Typescript. Additionally, the rest of the application is written in TS which prevents scripts from using application source code.
New Behavior
Stress Test CLI scripts are written in Typescript. This allows:
type-checkcommand.fixturecommand to generate fixtures with theRandomTreeclass that is written in Typescript.This PR also refactors the CLI commands a bit based on usage.
Related Issue(s)
Fixes #24724